From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A01F331203 for ; Mon, 19 Oct 2026 09:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792400904; cv=none; b=RkHuSyYldjZ6MS7UFOmp+Qu//06m7iAacR7VSxmZDJF650cSw8NNrlPf70nO4J6yZKSByne1ZBUHw1WutibP5ulwAoZxfFiJf1+lO/B+Kvye7ustf21Z+Npp6nqn6+BWut8xSQ/r37DX8PA0b0Srgz8m2+O0+GZAYKTZZfqY77U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792400904; c=relaxed/simple; bh=ANWtDHrUN8yaLtWHmbxn0S/UOd3W2HnelMg3mN8P9Sg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qx19RngKM3TFtNu5IU1FFVA3b3fVoVNE4mRyIJRHWnfP+rOptvpzv/w+SHYz43pD++jvG/3ibz9UJT+0/ykSLW1cEiPIEoNdon+ngv9iF5XHuKcxePM8A6giTCbm/drtPF3LeyxTL9RinXM47YfpbHjS6OIL+UiDeU8q8xvKU2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=He0AHl1x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SpISH4L+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="He0AHl1x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SpISH4L+" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69J8Ykb02688759 for ; Mon, 19 Oct 2026 09:08:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iDOJUKPZ+vd5FVmRMKIpfjJCtt51gYVRZlZPGq8hbR0=; b=He0AHl1xU03PyNTv xDsm+upddU4Xsx967MQJT4Wt34HjxqKkeRZI44q+7420ZbSnex0wMlSdCpI7KeRS CkovQFWNZYbFqwMK1I8pXSatwO89sH4ShObIo0auHRPtOBek18pZh4iiPhWcKcJG sPqmATo88qW7jjs43fw0bbAgcuR2ZcG8BQ5m//Qiom59mQ/zXYJ5FaSxHGNasN5H qg1pnEk9iBohfJJITAZrEiILn9wSbAzyOViIBnWc4/1Hq9sbrW+lxiEpMK1ywBkT +PgTeVlBqzSnySNuH1a29xXmH7uT5jgfbT50qWkSKq7Lt1nSAhazIAELbxuBK8I7 +Z7KAQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdftn047t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Oct 2026 09:08:21 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93df7a9466bso31025285a.2 for ; Mon, 19 Oct 2026 02:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792400901; x=1793005701; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iDOJUKPZ+vd5FVmRMKIpfjJCtt51gYVRZlZPGq8hbR0=; b=SpISH4L+31opgNM3JGDUOi3zMxXLD0wmm0NdEmcLbeyE0577We3FZGyDzr1ozT2jQ0 kqA9deawQpXBSNR1BqBcVAr3a3DSmntlg0vn1IOYic9Pk8PIZidx+42hO3gLHnu/uUsa byWa/AdRkXGtKrO1f5atsbavMSE1OdLZMIZI/sUWWTQFxE/tuyW/HpyhB6fvJnR0Ap44 xq8EhYn7h+G9Chfc2xyuaLQ+oibPUXf/arLBc38hVkSVplvWbTYZ/P3Luo8N855zFWUo i8+OMMY7f+gdUfhwrq9vn9BkFaWUS4QTNArzlnWoov+wH/+2HaZQ0gk34nfJU1hYm+7r sYUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792400901; x=1793005701; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iDOJUKPZ+vd5FVmRMKIpfjJCtt51gYVRZlZPGq8hbR0=; b=zwUy6TpQml6/zA1MCoV356dcVDzG1h/swWN0HC/kfYUwizfJggXhQgpd2K8gsV9rrs xu2yHOxoQOJ8R+pAo8n8C5J5OSqD9y6HKfXvfkFopS/cRoO808OKUlMEmi8tWSY7GXs+ wPpcPlcN2hxQybBDRazGo96PsDTtWsQuTqRo3JjuHqrUa1tm0KlhjeTOx23hB4lTioh5 sfuXggBeG9UWDZL6+2o1b3B1x/gVEXHBO+PbTPGXyHQHvkUWvL/yzenUqHrxxdh0z26k mcK5hxWK2clq4ai7wMhvZ9Akjvdf4lie/u7PsKba78sihWujV6+31zDNwJyXcoXO6ARm UBvQ== X-Forwarded-Encrypted: i=1; AKwUvBxHHsR/R+LiOsgjg7Xpweb8jMjG7NfjYDAk4NtF0gYNI/qxwf+itg3Zl8hVvNcVDV7fOCfjXsWX3+BeGWA=@vger.kernel.org X-Gm-Message-State: AFq9FYKjj8Y8QPasj1Phz2TQkX1WLlF++pl8xA65cN9+zInOmPCeat13 rWnOw6WvlA1CPZxpfH3+DCCAKW1HUt8B6LuvZELfy3MTSH2UM5sD5lhPLLLKM3ajkQ5keT6WN5Q sbhWvOG9nbf9hTtUvur55q1HdU6/2I1GWfFoeKPs+e9pfPkbnOwZM07JYVI0ky/Uedmo= X-Gm-Gg: AYBFou0cR2wCXmU00r02aMhxCRnRQQe7hLpHee4q7MRfigVTWJgOGnYuFK+VWwp6B3n zu6ciIu/sAcBUF6DNWhWcZTIgubiKgaFGvSOV3NImvfJcCuO1pyadehNT5S4VrSWQEKX+zlBn5I mi/JyAdI4pG1GW8Hjm0YOuRz8G7917EaAitlEe+vqUNyLWCLz4YW9UomF/1An+cNEAqwg/J4WHD snPft2GL3Bze1K03N4G/VNj5SvyYqVkW11HcaGyk/GbYtLv5y6hU7LcvVHVCcs+2/xHE38b65Mi NJ/sTHbACyglA18xbM4BS6G0kuP5UAGck/HKthCXclAV0obiaydNpz2ljPb0VnMFsp4uCM72Lqi y8o+grD9aZXGOmeARss7q0w== X-Received: by 2002:a05:620a:4452:b0:93a:14c:329c with SMTP id af79cd13be357-93f29b38f59mr1324501085a.1.1792400900967; Mon, 19 Oct 2026 02:08:20 -0700 (PDT) X-Received: by 2002:a05:620a:4452:b0:93a:14c:329c with SMTP id af79cd13be357-93f29b38f59mr1324497185a.1.1792400900469; Mon, 19 Oct 2026 02:08:20 -0700 (PDT) Received: from [192.168.226.26] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c4090dd10ebsm339452466b.22.2026.10.19.02.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 02:08:19 -0700 (PDT) Message-ID: <20553686-c073-4b13-a23b-a4936da33dad@oss.qualcomm.com> Date: Mon, 19 Oct 2026 11:08:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/a6xx: Don't set GPU freq before the GMU freq table is built To: eng.m7mdhashim.1@gmail.com, Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20261018-msm-gmu-freq-guard-v1-1-dd92dcccee86@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20261018-msm-gmu-freq-guard-v1-1-dd92dcccee86@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE5MDAzNiBTYWx0ZWRfX9aIAu+vW6BE9 KduYmM7ykjaCQ9Mur2CfL7dmjHpQ306MqKtN7Xo1e5fU3A9l4G0WjojyPvMq1yGqtt1DZmKMRXz CmXG2aRLNWt47XXim73mr/Wpax3gxg0= X-Proofpoint-GUID: QE-zBIXCsgHs-935Oqnz7kt9NNP-46br X-Proofpoint-ORIG-GUID: QE-zBIXCsgHs-935Oqnz7kt9NNP-46br X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE5MDAzNiBTYWx0ZWRfX75REryqUuf4w +6jmp19FPqnIX47CsVwXTbtZRiAGN4rZWSMX+GbGlsTHdhpH6Jle8G7zXgjh14J3nQCYIrql+LQ fJAT0JBqe/cxTitdVWE4CAzCgidmhPa9LrC6ujTBJMGeo6zCyn/n873DLXTlXEzli00bKGLlJ78 TpLo9DfpQ5eh26hxzwvOivUa7bRBcGfNIy7pVZXVGAAGahnJbcThh5VRQLS2IYG48eTwKucc08h begkWPai7LRIvUYxLq9u/WnwhEkF1dQHGIcUG5dh8N6MNgp9OHl9P3lQkA6vOeutvDXGINf5/rb FV7eo8qGnlVArwzNDzASFtw9RLBbwPPwgKuRZflJmFAPbaNYayTlQzaJv/QTwAXk2xcfbycrBWL CRhVkdRQmoI9Baf2tIj/fW1R3odVcK6iEyvPoqXYI0NFpYZG09/AKqAIa8dzgCQP9/xoAOKEA8m vwYtrx1agCG0buDbeig== X-Authority-Analysis: v=2.4 cv=OvTaWC/t c=1 sm=1 tr=0 ts=6ad5de05 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=pGLkceISAAAA:8 a=TId0fF7HYP2RL42ZpU8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-19_03,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610190036 On 10/18/26 8:29 PM, Mohammed AlHashim via B4 Relay wrote: > From: Mohammed AlHashim > > a6xx_gpu_init() registers devfreq through adreno_gpu_init() -> > msm_gpu_init() -> msm_devfreq_init(), and only afterwards calls > a6xx_gmu_init(), which fills gmu->gpu_freqs[] and sets > gmu->nr_gpu_freqs. The devfreq sysfs node is visible in that window, > so a write to min_freq or max_freq can reach a6xx_gmu_set_freq() while > nr_gpu_freqs is still 0. [...] > If you'd rather fix the ordering, so devfreq is registered after > a6xx_gmu_init(), I'm happy to rework it that way. I think that's the cleaner fix. Konrad