From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1766015AbdAKQek (ORCPT ); Wed, 11 Jan 2017 11:34:40 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:56183 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765839AbdAKQd6 (ORCPT ); Wed, 11 Jan 2017 11:33:58 -0500 From: Arnd Bergmann To: Daniel Vetter Cc: Daniel Vetter , Daniel Vetter , Benjamin Gaignard , Jani Nikula , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds Date: Wed, 11 Jan 2017 17:33:21 +0100 Message-ID: <2059511.haYOJvAx2D@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20170111162713.veyyu56sbjaym3fe@phenom.ffwll.local> References: <20170111133357.3664191-1-arnd@arndb.de> <20170111162713.veyyu56sbjaym3fe@phenom.ffwll.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:FpzclL7GmVVTWtgWUK0IPbcxCkk0bCnwZRTapqnQU0US+AWYyB2 PtKtc1nvVQqgY2r0D3IaAvfsMGVByffR3o1k+RYzK9+VeM07r32VLUta9l3T6ikXjOXiDFl chbkhV1Lsk7WUDS5q+Z2FWEkdlheC7pTxjr1mHJCO9AnNPQgztxcevapVBmumgLimTGL+eB 84OpcZ62ITOJVHGtrp7uA== X-UI-Out-Filterresults: notjunk:1;V01:K0:pEckzH1hLA4=:0aKBI2FjMQ1ZuMp/Kb2zV/ L5Lj7gd0aWznJ0iXtm7yWwzQJKiqJqWf3kPfQvJOpWrSujxX+7fJIdGgzvlOeBdeIFApUkWAN E3Jg/Cq7ubNuh42lbmI4Yn6q0561slcxOudzUJ/4kyqsAGWt7e0u5emUaH2XzbrtUnSJDgJjV 7A0QNruJXoYd81OzNowu9TdM3rQdB+j9IQ34dWWEbUUWP0QtvCQWi37IP8TtA5B1qEZ+GxyFK z5Tr9rnHwTwaqZByU9GCLBXyZ/jr/UTdUnQbGRp/pSXytTFc5v/tI5GYtip+NgkDl9ghLIdFp YOzGrlWEvrxKvTuZU7O6nem7WXv92Ac5GDltI9L9aq7cdSfQdKXRmN1CNEUYgIrrbUzqx0Ss/ zRY3YGPOSNNGb5gFWVPh5DSODRHl1S+WfhQW8h7PZpFTFXQEpzFbY+UWLFpElBej8xwyVpjRk DKHo0DWCms9GODNutgzjICFSvHRnxKSL6+Fb/RWkHHigvpAT4THbUx18uZysuWHE0yNox10p1 ZkRzswrDYLPmJavMhWn8ILOF1l028IUE5DspejYuL0ekPrhl3lYXirPW3BSA9YzrfhHUCxLfO FfampZA41yA4BR4jN+qxkVkzr0x3LPu6pNl4+W2DP9qUi4KnIaso91hHE9rTf6HlodFGlF3Hg YUcKHbZC9Ni5JvJx13eDxoxzOQxFjDgBzW9g6JYF7JjKi9RZB9YqYMBuIl3oYZr4JgSJjOgHG gXSsU3ZqxeLlqUnM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, January 11, 2017 5:27:13 PM CET Daniel Vetter wrote: > On Wed, Jan 11, 2017 at 02:33:34PM +0100, Arnd Bergmann wrote: > > When building DRM without an MMU, we run into a compile-time error because > > pte_wrprotect() is not defined: > > > > drivers/gpu/drm/drm_vm.c: In function 'drm_mmap_dma': > > drivers/gpu/drm/drm_vm.c:496:9: error: implicit declaration of function 'pte_wrprotect' [-Werror=implicit-function-declaration] > > > > The line is not meaningful here, so we can simply add another > > compile-time check around it. > > > > Fixes: 62a0d98a188c ("drm: allow to use mmuless SoC") > > Signed-off-by: Arnd Bergmann > > We don't need drm_vm.c on modern drivers, and the idea was to simply not > compile it when not needed. See: > > commit 99c48e1e38f0aeaa107ad67c8d91f6c9d9d567a9 > Author: Benjamin Gaignard > Date: Wed Jan 4 10:12:56 2017 +0100 > > drm: compile drm_vm.c only when needed > > > How did you manage to enable this stuff? > -Daniel This was a randconfig build, the DRM specific symbols here are CONFIG_DRM=y CONFIG_DRM_MIPI_DSI=y # CONFIG_DRM_DP_AUX_CHARDEV is not set # CONFIG_DRM_DEBUG_MM is not set # CONFIG_DRM_DEBUG_MM_SELFTEST is not set CONFIG_DRM_KMS_HELPER=y CONFIG_DRM_KMS_FB_HELPER=y # CONFIG_DRM_FBDEV_EMULATION is not set CONFIG_DRM_LOAD_EDID_FIRMWARE=y CONFIG_DRM_GEM_CMA_HELPER=y CONFIG_DRM_KMS_CMA_HELPER=y CONFIG_DRM_VM=y # # I2C encoder or helper chips # # CONFIG_DRM_I2C_CH7006 is not set CONFIG_DRM_I2C_SIL164=y # CONFIG_DRM_I2C_NXP_TDA998X is not set CONFIG_DRM_ARM=y CONFIG_DRM_HDLCD=y CONFIG_DRM_HDLCD_SHOW_UNDERRUN=y # CONFIG_DRM_MALI_DISPLAY is not set # # ACP (Audio CoProcessor) Configuration # CONFIG_DRM_VGEM=y CONFIG_DRM_ROCKCHIP=y CONFIG_ROCKCHIP_ANALOGIX_DP=y CONFIG_ROCKCHIP_DW_HDMI=m CONFIG_ROCKCHIP_DW_MIPI_DSI=y CONFIG_ROCKCHIP_INNO_HDMI=m # CONFIG_DRM_UDL is not set CONFIG_DRM_ARMADA=y CONFIG_DRM_ATMEL_HLCDC=m CONFIG_DRM_RCAR_DU=y # CONFIG_DRM_RCAR_HDMI is not set CONFIG_DRM_RCAR_LVDS=y # CONFIG_DRM_SHMOBILE is not set CONFIG_DRM_SUN4I=y CONFIG_DRM_TILCDC=m CONFIG_DRM_TILCDC_SLAVE_COMPAT=y CONFIG_DRM_MSM=y CONFIG_DRM_MSM_REGISTER_LOGGING=y CONFIG_DRM_MSM_HDMI_HDCP=y CONFIG_DRM_MSM_DSI=y # CONFIG_DRM_MSM_DSI_PLL is not set # CONFIG_DRM_MSM_DSI_28NM_PHY is not set # CONFIG_DRM_MSM_DSI_20NM_PHY is not set CONFIG_DRM_MSM_DSI_28NM_8960_PHY=y # CONFIG_DRM_FSL_DCU is not set # CONFIG_DRM_TEGRA is not set CONFIG_DRM_PANEL=y # # Display Panels # CONFIG_DRM_PANEL_SIMPLE=m CONFIG_DRM_PANEL_JDI_LT070ME05000=m CONFIG_DRM_PANEL_PANASONIC_VVX10F034N00=m # CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0 is not set # CONFIG_DRM_PANEL_SHARP_LQ101R1SX01 is not set # CONFIG_DRM_PANEL_SHARP_LS043T1LE01 is not set CONFIG_DRM_BRIDGE=y # # Display Interface Bridges # CONFIG_DRM_ANALOGIX_ANX78XX=y CONFIG_DRM_DUMB_VGA_DAC=m CONFIG_DRM_DW_HDMI=m CONFIG_DRM_DW_HDMI_AHB_AUDIO=m # CONFIG_DRM_NXP_PTN3460 is not set CONFIG_DRM_PARADE_PS8622=m # CONFIG_DRM_SIL_SII8620 is not set # CONFIG_DRM_SII902X is not set # CONFIG_DRM_TOSHIBA_TC358767 is not set CONFIG_DRM_TI_TFP410=y CONFIG_DRM_ANALOGIX_DP=y # CONFIG_DRM_I2C_ADV7511 is not set CONFIG_DRM_VC4=m CONFIG_DRM_ETNAVIV=m # CONFIG_DRM_ETNAVIV_REGISTER_LOGGING is not set CONFIG_DRM_ARCPGU=m CONFIG_DRM_MXS=y CONFIG_DRM_MXSFB=m CONFIG_DRM_MESON=y CONFIG_DRM_LEGACY=y # CONFIG_DRM_LIB_RANDOM is not set No idea what did it in the end. I also have some older build fixes applied, so it may be something that happens on my tree but not on plain linux-next. Arnd