From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AFFCDB474 for ; Tue, 17 Oct 2023 07:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234699AbjJQH45 (ORCPT ); Tue, 17 Oct 2023 03:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232300AbjJQH4y (ORCPT ); Tue, 17 Oct 2023 03:56:54 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 647AC93; Tue, 17 Oct 2023 00:56:52 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S8mQs5jvzzvQ67; Tue, 17 Oct 2023 15:52:05 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 17 Oct 2023 15:56:49 +0800 Subject: Re: [PATCH net-next v11 0/6] introduce page_pool_alloc() related API To: Jakub Kicinski CC: , , , , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Matthias Brugger , AngeloGioacchino Del Regno , , , References: <20231013064827.61135-1-linyunsheng@huawei.com> <20231016182725.6aa5544f@kernel.org> From: Yunsheng Lin Message-ID: <2059ea42-f5cb-1366-804e-7036fb40cdaa@huawei.com> Date: Tue, 17 Oct 2023 15:56:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20231016182725.6aa5544f@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/10/17 9:27, Jakub Kicinski wrote: > On Fri, 13 Oct 2023 14:48:20 +0800 Yunsheng Lin wrote: >> v5 RFC: Add a new page_pool_cache_alloc() API, and other minor >> change as discussed in v4. As there seems to be three >> comsumers that might be made use of the new API, so >> repost it as RFC and CC the relevant authors to see >> if the new API fits their need. > > I have looked thru the v4 discussion (admittedly it was pretty huge). > I can't find where the "cache" API was suggested. Actually, the discussion happened in V3 as both of discussions in V3 and V4 seems to be happening concurrently: https://lore.kernel.org/all/f8ce176f-f975-af11-641c-b56c53a8066a@redhat.com/ > And I can't figure out now what the "cache" in the name is referring to. > Looks like these are just convenience wrappers which return VA instead > of struct page.. Yes, it is corresponding to some API like napi_alloc_frag() returning va instead of 'struct page' mentioned in patch 5. Anyway, naming is hard, any suggestion for a better naming is always welcomed:) > . >