From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>, kvm@vger.kernel.org
Cc: David Laight <David.Laight@ACULAB.COM>,
linux-kernel@vger.kernel.org, "Tian,
Kevin" <kevin.tian@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH v2 1/3] vfio: trivially use __aligned_u64 for ioctl structs
Date: Thu, 31 Aug 2023 10:45:50 +0200 [thread overview]
Message-ID: <205cfbcb-a989-dc72-8f5d-46d2a00b01d9@linaro.org> (raw)
In-Reply-To: <20230829182720.331083-2-stefanha@redhat.com>
On 29/8/23 20:27, Stefan Hajnoczi wrote:
> u64 alignment behaves differently depending on the architecture and so
> <uapi/linux/types.h> offers __aligned_u64 to achieve consistent behavior
> in kernel<->userspace ABIs.
>
> There are structs in <uapi/linux/vfio.h> that can trivially be updated
> to __aligned_u64 because the struct sizes are multiples of 8 bytes.
> There is no change in memory layout on any CPU architecture and
> therefore this change is safe.
>
> The commits that follow this one handle the trickier cases where
> explanation about ABI breakage is necessary.
>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> include/uapi/linux/vfio.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-08-31 8:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 18:27 [PATCH v2 0/3] vfio: " Stefan Hajnoczi
2023-08-29 18:27 ` [PATCH v2 1/3] vfio: trivially " Stefan Hajnoczi
2023-08-31 8:45 ` Philippe Mathieu-Daudé [this message]
2023-09-11 6:06 ` Tian, Kevin
2023-08-29 18:27 ` [PATCH v2 2/3] vfio: use __aligned_u64 in struct vfio_device_gfx_plane_info Stefan Hajnoczi
2023-09-07 16:25 ` Jason Gunthorpe
2023-09-11 6:07 ` Tian, Kevin
2023-09-15 20:04 ` Alex Williamson
2023-09-18 14:15 ` Stefan Hajnoczi
2023-08-29 18:27 ` [PATCH v2 3/3] vfio: use __aligned_u64 in struct vfio_device_ioeventfd Stefan Hajnoczi
2023-09-11 6:08 ` Tian, Kevin
2023-08-29 21:10 ` [PATCH v2 0/3] vfio: use __aligned_u64 for ioctl structs David Laight
2023-08-30 8:32 ` David Laight
2023-08-30 21:53 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=205cfbcb-a989-dc72-8f5d-46d2a00b01d9@linaro.org \
--to=philmd@linaro.org \
--cc=David.Laight@ACULAB.COM \
--cc=alex.williamson@redhat.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®