From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758073AbcEFAgA (ORCPT ); Thu, 5 May 2016 20:36:00 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:60717 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756269AbcEFAf6 (ORCPT ); Thu, 5 May 2016 20:35:58 -0400 From: "Rafael J. Wysocki" To: Steve Muckle Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: cpufreq governors broken with !CONFIG_SMP? Date: Fri, 06 May 2016 02:39:11 +0200 Message-ID: <20628091.X3uHbXY5oF@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160506002519.GB14673@sky.smuckle.net> References: <20160505234922.GA14673@sky.smuckle.net> <1961527.dEtpL4HAvs@vostro.rjw.lan> <20160506002519.GB14673@sky.smuckle.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 05, 2016 05:25:19 PM Steve Muckle wrote: > On Fri, May 06, 2016 at 02:09:07AM +0200, Rafael J. Wysocki wrote: > > In turn, schedutil should probably depend on CONFIG_SMP. > > In the long term I wonder if it's worth putting PELT under its own > separate feature or just removing #ifdef CONFIG_SMP. > > Aside from task migration CPU frequency updates there's also task > creation and deletion which would apply on UP. The tunable > infrastructure being created for scheduler-guided frequency may be of > interest on UP also. I agree, but I was talking short-term. :-) We need to fix this for 4.6 (which most likely is 2 weeks away only) and I don't think it hurts anyone if schedutil depends on CONFIG_SMP to start with.