From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752703AbcLLML0 (ORCPT ); Mon, 12 Dec 2016 07:11:26 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:40788 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbcLLMLY (ORCPT ); Mon, 12 Dec 2016 07:11:24 -0500 X-AuditID: cbfee61b-f796f6d000004092-95-584e93ea8f55 From: Bartlomiej Zolnierkiewicz To: Robert Jarzmik Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Olof Johansson , Russell King , Daniel Mack , Haojian Zhuang , Cyril Bur Subject: Re: [RFC PATCH 15/23] arm: use kconfig fragments for ARCH_PXA defconfigs (part 1) Date: Mon, 12 Dec 2016 13:11:20 +0100 Message-id: <2063576.NTX1QzvF1P@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <87a8c415hs.fsf@belgarion.home> References: <1481027938-31831-1-git-send-email-b.zolnierkie@samsung.com> <87a8c415hs.fsf@belgarion.home> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t9jAd1Xk/0iDK7NFLb4O+kYu8XxC6/Y LZr+vmKxuLDO3GLT42usFpd3zWGzuH2Z1+LU9c9sFrPeCDtwerQ097B5/P41idGjf91nVo+d s+6ye2xeUu9x5UQTq8fnTXIe23cvZwngiHKzyUhNTEktUkjNS85PycxLt1UKDXHTtVBSyEvM TbVVitD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbxq+GT6wFZ/gqzvSuZm9gvM/dxcjJISFg IrHr2Tw2CFtM4sK99UA2F4eQwFJGifurDrFDOF8ZJU4+WcoKUsUmYCUxsX0VYxcjB4eIgLbE zW3+IGFmgflMElOb7EHCwgIxEvuvioCEWQRUJSYcvs4EEuYV0JRo/RIJEhYV8JLYsq+dCcTm FNCReLmhiRVi0z5GiT/zP4Bt4hUQlPgx+R4LxHh5iX37p7JC2FoS63ceZ5rAKDALSdksJGWz kJQtYGRexSiRWpBcUJyUnmuUl1quV5yYW1yal66XnJ+7iREci8+kdzAe3uV+iFGAg1GJh9ch 1TdCiDWxrLgy9xCjBAezkghvOTCShXhTEiurUovy44tKc1KLDzGaAj04kVlKNDkfmCbySuIN TcxNzI0NLMwtLU2MlMR5G2c/CxcSSE8sSc1OTS1ILYLpY+LglGpgNBJL8/S5X8uQtfJTfa+j 1qWic7GfKp4z9mryqD2Zu9RL/sTkaRsu7dkXvFF1YltPryFP3dvzhZ5uJ+KZVlxWlFy5d4X2 RuF1h07+sNkc+EL80Z61q7OyNkntZ9k66aftxsgfsx9F3zu+YV697jTLs7Nu7N9RdeN42Lwf aastEj4W/uaOnRop76nEUpyRaKjFXFScCACWgxWD2wIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Saturday, December 10, 2016 10:46:23 AM Robert Jarzmik wrote: > Bartlomiej Zolnierkiewicz writes: > > > Replace [lpd270,lubbock,mainstone,pxa255-idp]_defconfig-s with > > a Makefile target using merge_config. > > > > The patch was verified with doing: > > > > $ make [lpd270,...]_defconfig > > $ make savedefconfig > > > > and comparing resulting defconfig files (before/after the patch). > > > > Cc: Daniel Mack > > Cc: Haojian Zhuang > > Cc: Robert Jarzmik > > Cc: Cyril Bur > > Signed-off-by: Bartlomiej Zolnierkiewicz > > Hi Bartolomiej, > > It's a bit hard to judge without any context for me, especially I'm receiving > patches 11 to 21 but not the others. I suppose the advantage of defconfig Sorry about that. > fragments was already discussed somewhere, could you point me to that please ? http://marc.info/?l=linux-kernel&m=148102838302106&w=2 I've put the patches on hold for now after the feedback from Olof & Arnd. > One small thing that could be improved is the "pxa_basic*" names. > > I think pxa_basic1 is "pxa_refboards" or something like that, as these are the > initial reference designs as far as I know from Intel and validation vehicles > rather that form factors. > > In the same way, pxa_basic2 is rather "pxa_sharpsl" as these are sharp designs. > > And pxa_basic3 looks like Motorola platforms, so "pxa_motorola" perhaps ? > > I noticed imote2.config ended up based on pxa_basic3, while I would have > expected it to be based on pxa_basic1 as it looks like a reference board to me > ... Thank you for your comments. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics