From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B30C84343E7 for ; Fri, 31 Jul 2026 15:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785510218; cv=none; b=i0eeVqgQUN5G4yOLoCGpzwwognr/2yv9R4LUs3cFXVjTGFaTNTLNPY71WhoT0h/bvzjoqpp+8gjj/KXBTau3K1xhhRLs3qToHcv4uPmBYi4bXbnpR7PltyQAlRvCQw6NKOHEwVwWJ/r+AhVCJNzhde7ikoqYUdTlF3Bhl49lErA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785510218; c=relaxed/simple; bh=6/CNlPNYU6kgWajfaLgIveCVtakvelDM7nTd2OKsQs4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=je/EcPPFeDTpB6vDKu1kCTm7ZtsgXj1zJ8q3gSbFGeVPqdIeYsUtts5CEBmrfCHEyJHYFTsHFoIqUS+p3dqiBzd+hXM1Q+uK83I7TwvYcK1Rr3aE1cmyViEjqxRpkY1NGs68uYsxhp4+dZxWDINEopAhuXYAbhTt/bphqRLBhJs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=zBTpXXhU; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="zBTpXXhU" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7eb42a2f5feso541262a34.1 for ; Fri, 31 Jul 2026 08:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1785510213; x=1786115013; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z+Mb8GC1uJx0jhs18l79B+Kqw1w0ITSCvV2PCYoDYXE=; b=zBTpXXhU1SXydJ4bwQ3E5XhJD5MtDVuNaOwYvbVWH3rt/ZY+UR984IyQF2DqpbzGwi tokoCvuLq88Qw94YSW1wqy7TxSRO2zR//to0pih7BxlpzT5SPNTGw6sQP9pAYAqwK5fj 2nvY5ItvCYOTDBBu22HE+BU2xajJ1o43YDkVas80lL97tVIcQZAYUT423XeK6uZBHiZO uoFlOUSsdQTMv6RuTfpjZ22BHot72603luOfkiyxuRmqyK8q1Ro3L/L+cQCWSkjcHK6I j3epA/xxmDR9PJ5Mg+IbEQ9HKEsOzi3uA5dMT7+gScRL18tKS0l9g1/hF5erSCf80/Mb QlVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785510213; x=1786115013; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z+Mb8GC1uJx0jhs18l79B+Kqw1w0ITSCvV2PCYoDYXE=; b=Xdt5vU3V/QtO2eJ/gTJ2ZWgQ1c/BwpKLjtj2JMzro+qiNBQ+QV7rex7QZZxam8ua26 8QoEyU/0MqGRdam2V4g41aLv83sJDuXm4T4lvCLeCqDi9IB39nz1aPiRluqXFx0XvrZc QoJxBTd2XjecwmS/2dDH/6nsBsmPqWlj75irmGgt0UnFsh2XFdwjhB1GPmS+L0EUc17X 5kYV1grONWgQSEGwveQS3BePBs5n4KJtSz/Pw4BEmQReAbrBSTKsTR9wH6y9ITdI1ArE AimznGjUEnCuKW2tIfEM3aQzbmO2yQmyC8vgoHOCEukeFP9gpoQ1G/zY0ozKHi4yQNig hHlw== X-Forwarded-Encrypted: i=1; AHgh+RrVxk7MyFkMQYGriN1nlnX+iW3sRmbqm/+HnsEamkXD+brTwdAauhpbjCE+eefDGyjsqBpZED7xHZq96lg=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ/stQlyBAO70BBK7p24LUR6Z39R9qyuJ0Kr9hcfxFdJaNBhki mtwdkpa3e/uvkhu9qbh7JsJBZrDcgBfFxOa2G+rGzrYgAPfZzLxC582DM1Pm8IYTHY4= X-Gm-Gg: AR+sD10ZjW4wemPMUtdVvRu2dOKgO/B0YRlwgEH11ge2NBT/FjsWQoo+g8VwMSNL2vh 5RHVnN2vC31TggG8HF4n9YFGBgggNtanaGQFUfX+B1pdXcRuhYLJy9jgW9EBSXA6U8lE+2Zclxz H+BOSHvUHArhGMZYuaYQtmR8X6C7H2gmkbyol96UxDI7bj6ujnGgU5FKTFt72DsxM6iFOMNcKvI Y+IDtLT0xKy4eVLdLe03ys6Qak4CQyoIOlg8+g0nKfBfQqrMbeAkqQ6P8fJUhFHObPfzJExTTib GFPBcSKzpJdoOcC87SOf7wqOe8stS39raFir8rxhDcV2PY+0F/aVaoEndP/YeBaJ1/I8PrlvZlx utgmGRA2R4fl3CnCfaUgUWLU4kJkiv0/Gp8vsEkqptllkWcS+Iir935PsKx0WKhrnjEH+X8znRc syfI5XR1O46Vp76yH4+MlGSdfqLIrnLDpjcVEoQl5cIEue9+KuzxffcOJNjrsdEspDwMc9orMvS Ff4nb5yD12xZYAmCMC2o1KaqpieBC1XepCSJDoejhYTjyY= X-Received: by 2002:a05:6820:2acd:b0:6ac:a994:8a02 with SMTP id 006d021491bc7-6ae4320bb65mr669668eaf.12.1785510213169; Fri, 31 Jul 2026 08:03:33 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-458f66c1d89sm1220597fac.13.2026.07.31.08.03.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 08:03:30 -0700 (PDT) Message-ID: <20683d73-32fe-4605-93e4-b02da0172e2c@kernel.dk> Date: Fri, 31 Jul 2026 09:03:29 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 4/9] io-uring/rw: Use accessor for hrtimer_sleeper ->task field To: "Paul E. McKenney" , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner Cc: "Peter Zijlstra (Intel)" , linux-kernel@vger.kernel.org, kernel-team@meta.com, io-uring@vger.kernel.org References: <20260731004019.3530210-4-paulmck@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260731004019.3530210-4-paulmck@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/30/26 6:40 PM, Paul E. McKenney wrote: > The hrtimer_sleeper structure's ->task field is used as a flag to indicate > that the associated hrtimer has expired. This means that the hrtimer > handler can be storing to this field while other code is loading from it > to check for expiry. Note that additional races appear for hrtimers that > can be restarted, which could be argued to be a user error. However, that > is no reason to let the compiler introduce additional confusion, and to > this end, the hrtimer_sleeper_task_get() was introduced, use of which also > has the benefit of avoiding open-code access to hrtimer_sleeper innards. > > Therefore, apply this accessor to the io_hybrid_iopoll_delay() function. Seems fine to me, but for some reason you didn't CC all the people on the series. Hence I don't know if each can stand on its own. A quick grep tells me that, no, that is not the case, as hrtimer_sleeper_task_get() isn't a thing in the tree right now. That's a slight nudge to please don't do partial CCs, it's impossible to tell without needing to dig further. -- Jens Axboe