From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753442AbcEINMm (ORCPT ); Mon, 9 May 2016 09:12:42 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:65160 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbcEINMk (ORCPT ); Mon, 9 May 2016 09:12:40 -0400 From: Arnd Bergmann To: Florian Fainelli Cc: Florian Fainelli , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, bhelgaas@google.com Subject: Re: [PATCH v2 1/2] Documentation: DT: bindings: Add Broadcom STB PCIe bindings Date: Mon, 09 May 2016 15:12:12 +0200 Message-ID: <20692845.Ts1cTL7t9V@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <572BBF2E.5010606@broadcom.com> References: <1462475700-1654-1-git-send-email-f.fainelli@gmail.com> <4513390.VWu0VVAxOl@wuerfel> <572BBF2E.5010606@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jeOhQWLkz8VGnjPyHdA97liHJpCU9BPO2P34iDLuwJojTskOFtd pVW81Vt6o65GpLy0zgD/xfTwWp+Oy71PUExtfBToakqTOu6pu+z+zRg0CmcUBwoxi4BuLzC IBaBQNj4MuJQL7xWKupO80FIt11Eco5jNWsxunzv4WbZZSYkWGt6/66lsofrUje636COEMM /cATues/MuMyysrXaLfmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mIoP3cn2avU=:NNpXV29a0f7kZvcEdiD0h2 r5LuOLHt661DWTXHj/apmmtAsZ4Nrk32TFQqgyEYEq6qgInOeoMd2+EEYh4ANLPsXx5sCn522 onpxB1bixm5o7BbQ1oWaEe07c/fHKpGyKpGxf0638sXwWThZWXhW3a+sDAAcYE0LGvd7PyQDt 2oUNKLBswDxKSmbPin5D8Y5RY6OCDZWA1+zu5k1dpkInyahMpGv8lsvnlaO+mO+Si4+6Xs8R5 4e2MBeWw4cZ/KdJR7E64/oBdRL8PLc3EdtDdrfoEAgJs4lXqoqN5pI9QKxaaAGtZQyfdi1eR3 hdQi8LhymtBDdsM789weQVQQAT41ZcDCJgjphaGsEiYZzwXPpZhfGUPBoTbDod8lGeGdv/AN3 ocxLJAgy3n9NxhDcWYbcI2uKx/QZjyC9mMLr1ehmoOGsxAbMfwyqmjKP2GDUHZay6Jp79UHAW VJ6Zxgu1C/1o/TrjFdCHSq2zEttFE4cWluuWAIetKBwr7TLV1/mJ2Fwr3Hn6iflZNMLxbzRiR Emzx9wFO1WY808vk+Qd1dwPkhRH43fmG7ZcpnJf+kyxwpnwcnUKGXfuvyrsFN6sCvV2dsqzt8 aPFhHqYK9I9Q2WJRqmNoilQ6xLQ/PCX1R96b6MMkUzbLX73IUclaR3/D0r+xypYCJEGC2Y3dN 966SEnLflbQpGd9RlikM5QAcdcUmIm/2K+aHhDz3EUcl1dTQvGBVEa8TYeianfZvpWGs+h+Ad 3AyzpqBR3rx7PQ2M Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 05 May 2016 14:46:22 Florian Fainelli wrote: > > > > >> +- brcm,gen: integer that indicates desired forced generation of link: 1 => 2.5 > >> + Gbps, 2 => 5.0 Gbps, 3 => 8.0 Gbps. Will override the auto-negotation if > >> + specified. > > > > to repeat my earlier comment from v1: > > > > Shouldn't the link generation be probed automatically? > > It is, but if the property is present, we can foce the link negotiation, > We have had cases where this was desired and helpful. > Right, I missed that this is listed as 'optional', so that seems perfectly fine. Thanks, Arnd