From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751690AbdGROwp (ORCPT ); Tue, 18 Jul 2017 10:52:45 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37339 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbdGROwn (ORCPT ); Tue, 18 Jul 2017 10:52:43 -0400 Subject: Re: [PATCH] pid: kill pidhash_size in pidhash_init To: Kefeng Wang , Andrew Morton , linux-kernel@vger.kernel.org References: <1500389267-49222-1-git-send-email-wangkefeng.wang@huawei.com> From: Pasha Tatashin Message-ID: <20702e4f-10c1-ae91-0c0d-572516b92349@oracle.com> Date: Tue, 18 Jul 2017 10:52:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1500389267-49222-1-git-send-email-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Pavel Tatashin On 07/18/2017 10:47 AM, Kefeng Wang wrote: > After commit 3d375d78593c ("mm: update callers to use HASH_ZERO flag"), > drop unused pidhash_size in pidhash_init(). > > Signed-off-by: Kefeng Wang > --- > kernel/pid.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/kernel/pid.c b/kernel/pid.c > index 731c4e5..c69c30d 100644 > --- a/kernel/pid.c > +++ b/kernel/pid.c > @@ -575,13 +575,10 @@ struct pid *find_ge_pid(int nr, struct pid_namespace *ns) > */ > void __init pidhash_init(void) > { > - unsigned int pidhash_size; > - > pid_hash = alloc_large_system_hash("PID", sizeof(*pid_hash), 0, 18, > HASH_EARLY | HASH_SMALL | HASH_ZERO, > &pidhash_shift, NULL, > 0, 4096); > - pidhash_size = 1U << pidhash_shift; > } > > void __init pidmap_init(void) >