From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933476AbbI1M1x (ORCPT ); Mon, 28 Sep 2015 08:27:53 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:44098 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932477AbbI1M1v (ORCPT ); Mon, 28 Sep 2015 08:27:51 -0400 From: "Rafael J. Wysocki" To: "Chen, Yu C" Cc: "Wysocki, Rafael J" , "jiang.liu@linux.intel.com" , "Zhang, Rui" , "Brown, Len" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle Date: Mon, 28 Sep 2015 14:56:09 +0200 Message-ID: <2077382.8itqOgEaxv@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <36DF59CE26D8EE47B0655C516E9CE64026587A89@SHSMSX101.ccr.corp.intel.com> References: <1439172686-16360-1-git-send-email-yu.c.chen@intel.com> <14896395.L30bH9BMzP@vostro.rjw.lan> <36DF59CE26D8EE47B0655C516E9CE64026587A89@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, September 28, 2015 01:51:09 AM Chen, Yu C wrote: > Hi, Rafael, > > > -----Original Message----- > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki > > Sent: Sunday, September 27, 2015 9:30 PM > > To: Chen, Yu C > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, Len; linux- > > kernel@vger.kernel.org; linux-pm@vger.kernel.org > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before > > suspend-to-idle > > > > On Saturday, September 26, 2015 02:37:19 PM Chen, Yu C wrote: > > > Hi, Rafael, > > > > > > > -----Original Message----- > > > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > > > > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki > > > > Sent: Friday, September 25, 2015 9:57 PM > > > > To: Chen, Yu C > > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, > > > > Len; linux- kernel@vger.kernel.org; linux-pm@vger.kernel.org > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq > > > > setting before suspend-to-idle > > > > > > > > On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote: > > > > > Hi,Rafael, thanks a lot for your review, will resend v2 version. > > > > > > > > > > > -----Original Message----- > > > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > > > > > Sent: Friday, September 25, 2015 9:24 AM > > > > > > To: Chen, Yu C > > > > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; > > > > > > Brown, Len; linux- kernel@vger.kernel.org; > > > > > > linux-pm@vger.kernel.org > > > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq > > > > > > setting before suspend-to-idle > > > > > > > > > > > > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote: > > > > > > > > But I'd rather define a global acpi_irq variable, store irq in it > > > > and access it directly from acpi_freeze_prepare(). And it doesn't > > > > have to depend on CONFIG_SUSPEND as it is just the IRQ number > > actually used by ACPI. > > > > > > > OK, I've convert it to a global variable acpi_inuse_irq. > > > > Why do you need the "inuse" part? Why is acpi_irq not sufficient? > Because the name of acpi_irq is already used by acpi irq handler at > drivers/acpi/osl.c: > request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq) Ah, this is the name of the handler. I forgot about that, sorry. Well, it might be worth renaming the handler to something like acpi_interrupt(), then. Thanks, Rafael