From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, richardcochran@gmail.com,
p.zabel@pengutronix.de, yoshihiro.shimoda.uh@renesas.com,
geert+renesas@glider.be, wsa+renesas@sang-engineering.com,
robh@kernel.org, biju.das.jz@bp.renesas.com,
prabhakar.mahadev-lad.rj@bp.renesas.com,
mitsuhiro.kimura.kc@renesas.com, masaru.nagai.vx@renesas.com
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH 1/6] net: ravb: Check return value of reset_control_deassert()
Date: Tue, 28 Nov 2023 09:19:21 +0200 [thread overview]
Message-ID: <20811ebf-04e0-4196-9d0e-bd46a88065dd@tuxon.dev> (raw)
In-Reply-To: <b23a5e0c-cc55-b7b2-a6dc-1eac0a674814@omp.ru>
On 27.11.2023 18:39, Sergey Shtylyov wrote:
> On 11/27/23 12:04 PM, Claudiu wrote:
>
>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>
>> reset_control_deassert() could return an error. Some devices cannot work
>> if reset signal de-assert operation fails.
>
> Well, I think all devices can't work if the reset line is connected at all. :-)
I was thinking at the fact that the de-assert support was added just 2
years ago, while the driver seems to be ~8 years old.
>
>> To avoid this check the return
>> code of reset_control_deassert() in ravb_probe() and take proper action.
>
> I'd also mention moving of the free_nedev() call...
ok
>
>> Fixes: 0d13a1a464a0 ("ravb: Add reset support")
>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
> [...]
>
> MBR, Sergey
next prev parent reply other threads:[~2023-11-28 7:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 9:04 [PATCH 0/6] net: ravb: Fixes for the ravb driver Claudiu
2023-11-27 9:04 ` [PATCH 1/6] net: ravb: Check return value of reset_control_deassert() Claudiu
2023-11-27 11:49 ` Philipp Zabel
2023-11-27 16:39 ` Sergey Shtylyov
2023-11-28 7:19 ` claudiu beznea [this message]
2023-11-27 16:39 ` Sergey Shtylyov
2023-11-27 9:04 ` [PATCH 2/6] net: ravb: Use pm_runtime_resume_and_get() Claudiu
2023-11-27 16:47 ` Sergey Shtylyov
2023-11-27 9:04 ` [PATCH 3/6] net: ravb: Make write access to CXR35 first before accessing other EMAC registers Claudiu
2023-11-27 9:04 ` [PATCH 4/6] net: ravb: Start TX queues after HW initialization succeeded Claudiu
2023-11-27 9:04 ` [PATCH 5/6] net: ravb: Stop DMA in case of failures on ravb_open() Claudiu
2023-11-27 9:04 ` [PATCH 6/6] net: ravb: Keep reverse order of operations in ravb_remove() Claudiu
2023-11-27 17:16 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20811ebf-04e0-4196-9d0e-bd46a88065dd@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masaru.nagai.vx@renesas.com \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®