From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbaJPQvE (ORCPT ); Thu, 16 Oct 2014 12:51:04 -0400 Received: from mail.eperm.de ([89.247.134.16]:54076 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbaJPQvC (ORCPT ); Thu, 16 Oct 2014 12:51:02 -0400 X-AuthUser: sm@eperm.de From: Stephan Mueller To: Jason Cooper Cc: Grant Likely , Geert Uytterhoeven , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel crypto API interface specification Date: Thu, 16 Oct 2014 18:50:58 +0200 Message-ID: <2081738.uvS0jMPrv1@myon.chronox.de> User-Agent: KMail/4.14.1 (Linux/3.16.4-200.fc20.x86_64; KDE/4.14.1; x86_64; ; ) In-Reply-To: <20141016150604.GK17447@titan.lakedaemon.net> References: <7502136.9BkWHTZ0th@myon.chronox.de> <20141016132501.GI17447@titan.lakedaemon.net> <20141016150604.GK17447@titan.lakedaemon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, 16. Oktober 2014, 11:06:05 schrieb Jason Cooper: Hi Jason, > On Thu, Oct 16, 2014 at 09:25:01AM -0400, Jason Cooper wrote: > > + Grant, Geert, > > > > Stephan has created some great example code for both the kernel crypto > > API and the userspace crypto API. As examples tend to bitrot, I was > > wondering if the code could serve as test code. Then it would have a > > triple role: API regression testing, crypto test suite, and reference > > implementation. > > > > Original patch is here: > > https://lkml.kernel.org/r/7502136.9BkWHTZ0th@myon.chronox.de > > > > On Thu, Oct 16, 2014 at 09:19:08AM +0200, Stephan Mueller wrote: > > > Am Mittwoch, 15. Oktober 2014, 13:58:00 schrieb Jason Cooper: > > > > On Tue, Oct 14, 2014 at 09:46:50PM +0200, Stephan Mueller wrote: > ... > > > > > Perhaps the userspace API example should be a separate file with this > > > > text at the top? Seems odd having it at the end. Also, if you copied > > > > it from cryptsetup, is the copyright info correct? > > > > > > I did not copy it from cryptsetup. I only used it as a basis, especially > > > with the data structure handling in _kcapi_cipher_crypt. But you are > > > right, I changed the license for the user space by taking the > > > cryptsetup license.> > > Ok. It looks like Geert and Grant took part in the kernel test > > unconference, so I'm adding them to the Cc. I hope they can give us > > some pointers as to where we could hook in this code. Then we can > > simply refer to it from the userspace API document. > > tools/testing/selftests/crypto would be a good location for the example > code in the next version of this patch. Make sure to take a look at > tools/testing/selftests/README.txt. Well, I have written a FIPS 140-2 CAVS test harness covering all ciphers NIST is interested. Maybe this can go there? > > thx, > > Jason. -- Ciao Stephan