mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@oss.qualcomm.com>,
	<linux-fsd@tesla.com>, "'Krzysztof	Kozlowski'" <krzk@kernel.org>,
	"'Peter Griffin'" <peter.griffin@linaro.org>,
	"'Rob	Herring'" <robh@kernel.org>,
	"'Conor Dooley'" <conor+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/5] arm64: dts: fsd: Re-order nodes to match coding style
Date: Thu, 10 Sep 2026 21:29:46 +0530	[thread overview]
Message-ID: <2084663827.61789093083145.JavaMail.epsvc@epcpadp2new> (raw)
In-Reply-To: <20260909-dts-samsung-cleanup-strict-v1-4-1b755a446b22@oss.qualcomm.com>



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Sent: Wednesday, September 9, 2026 7:48 PM
> To: Alim Akhtar <alim.akhtar@samsung.com>; linux-fsd@tesla.com;
> Krzysztof Kozlowski <krzk@kernel.org>; Peter Griffin
> <peter.griffin@linaro.org>; Rob Herring <robh@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Krzysztof Kozlowski
> <krzysztof.kozlowski@oss.qualcomm.com>
> Subject: [PATCH 4/5] arm64: dts: fsd: Re-order nodes to match coding style
> 
> Re-order several top-level and MMIO nodes to match coding style - ordering
> by name or by unit address, as pointed out by dt-check-style,
> e.g.:
> 
>   fsd.dtsi:981: [child-address-order] child node @10040000 out of address
> order
>   fsd.dtsi:315: [child-name-order] child node 'arm-pmu' out of name order
>   fsd.dtsi:348: [child-name-order] child node 'clock' out of name order
> 
> While moving chunks of code, also re-order a few properties (I2S, SPI and
> CAN nodes) to fix:
> 
>   fsd.dtsi:661: [property-order] property 'clocks' out of canonical order
> (should sort before 'samsung,syscon-phandle')
>   fsd.dtsi:936: [property-order] property 'pinctrl-names' must be placed after
> 'pinctrl-0'
>   fsd.dtsi:936: [property-order] property 'pinctrl-names' out of canonical
> order (should sort before 'samsung,spi-src-clk')
> 
> Moving several nodes already creates unreviewable commit, thus reshuffling
> the properties allows to skip changing the same line twice without loss of
> readability.
> 
> Signed-off-by: Krzysztof Kozlowski
> <krzysztof.kozlowski@oss.qualcomm.com>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>




  reply	other threads:[~2026-09-11  2:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 14:17 [PATCH 0/5] arm64: dts: fsd: Cleanups with new dt-style-check Krzysztof Kozlowski
2026-09-09 14:17 ` [PATCH 1/5] arm64: dts: fsd: Fix indentation of CPU nodes Krzysztof Kozlowski
2026-09-10 15:19   ` Alim Akhtar
2026-09-09 14:17 ` [PATCH 2/5] arm64: dts: fsd: evb: Correct node order Krzysztof Kozlowski
2026-09-10 14:52   ` Alim Akhtar
2026-09-09 14:17 ` [PATCH 3/5] arm64: dts: fsd: Move idle states out of CPUs node Krzysztof Kozlowski
2026-09-10 15:26   ` Alim Akhtar
2026-09-09 14:17 ` [PATCH 4/5] arm64: dts: fsd: Re-order nodes to match coding style Krzysztof Kozlowski
2026-09-10 15:59   ` Alim Akhtar [this message]
2026-09-09 14:17 ` [PATCH 5/5] arm64: dts: fsd: Re-order properties " Krzysztof Kozlowski
2026-09-10 16:01   ` Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2084663827.61789093083145.JavaMail.epsvc@epcpadp2new \
    --to=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsd@tesla.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®