From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Robert Foss" <robert.foss@linaro.org>,
"Neil Armstrong" <narmstrong@baylibre.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>
Cc: kernel@collabora.com, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@linux.ie>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Maxime Ripard <maxime@cerno.tech>,
Pi-Hsun Shih <pihsun@chromium.org>,
Sam Ravnborg <sam@ravnborg.org>,
Tzung-Bi Shih <tzungbi@google.com>, Xin Ji <xji@analogixsemi.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: anx7625: Use uint8 for lane-swing arrays
Date: Fri, 8 Apr 2022 10:21:47 +0200 [thread overview]
Message-ID: <20848108-31bc-357c-224b-9cbdd465b195@collabora.com> (raw)
In-Reply-To: <20220408013034.673418-1-nfraprado@collabora.com>
Il 08/04/22 03:30, Nícolas F. R. A. Prado ha scritto:
> As defined in the anx7625 dt-binding, the analogix,lane0-swing and
> analogix,lane1-swing properties are uint8 arrays. Yet, the driver was
> reading the array as if it were of uint32 and masking to 8-bit before
> writing to the registers. This means that a devicetree written in
> accordance to the dt-binding would have its values incorrectly parsed.
>
> Fix the issue by reading the array as uint8 and storing them as uint8
> internally, so that we can also drop the masking when writing the
> registers.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2022-04-08 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 1:30 Nícolas F. R. A. Prado
2022-04-08 8:21 ` AngeloGioacchino Del Regno [this message]
2022-04-19 17:00 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20848108-31bc-357c-224b-9cbdd465b195@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@chromium.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=pihsun@chromium.org \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=tzungbi@google.com \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®