From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756795AbbLDWVA (ORCPT ); Fri, 4 Dec 2015 17:21:00 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:63922 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754120AbbLDWU6 (ORCPT ); Fri, 4 Dec 2015 17:20:58 -0500 From: Arnd Bergmann To: Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: Kyungmin Park , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil Subject: [PATCH] [media] exynos4-is: make VIDEO_SAMSUNG_EXYNOS4_IS tristate Date: Fri, 04 Dec 2015 23:20:09 +0100 Message-ID: <2086080.9y3TX8CFJu@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:j3MUlucSrPNQBp5pLjgUTrCiLkCiYofb8qgVt2M+j+OxMSSNgC6 qweVK2IwCaKMQGbPoEE+GXwB7Q6hYI8pk4osNaST+iAkdPGOiDfbEzawVb2OUic43gYpdcI vG8Zc1BCtnx5gwlmJN//WIwL9/wvPqRqXADxAqzN2mI3zB/MgJnKKEZ2Lq0wRwrmBgVCuWT fPxBu2rOPLWBrblyCTdjw== X-UI-Out-Filterresults: notjunk:1;V01:K0:IxYlSDSl0Ec=:qOno+hZgkHFowiwoz3coxS qZnHAZjBuXVYD03bMwditD07GAIl3PPwPfHk5Dj4iGtj9T0Ng5dbHttOjPzQm15uRUFPVfdIB BB/SA9YCiNoGWOE4rk6/2F84XsEeUxFLCNJXdld1A0Qpq8hXbJSotmztwJx8FaO89A2+hrqhS sl3eQo3nxT/FliLvStxQYKrB0vWJwAR4lsk3xIbnaJ2zi6CWylISYTmGwTQMddWxYW6PU0xCy R/Hgxwv4agI4K+7oR7KavsaA7rfrkDS3Pgk1xcubHN/2wfgW+JRgWR6b9NxMrE4kpTOzNBJpc L/OaTBXawfdGKc7dJPjmQHLtcCE5OsQaAL6fF0l7w0Ycg8oe5OqO2n/vrotvfxEEJvICtsiuY puFAnUq4b5KjsdzFbUvcnVV/MUV2bR4VT+Lx/EZN8w2EfQCVobpkFyK6aFjKTRMXywDi2BAu5 BKQH62Mu0N6Tm/AU/uaVSjkzMysxJ+uSe3JTYY/UjjNEuKmTYkAvNoRP6J1aXE5yloa+MS4p5 vEX10ahr5+4mnK3AFS+izxA788v6OIhZGwi9GgxhoJEB3Pjpfn7wbBOsuD+fCkLpLbEgMp7UV nl3RmNsW3v5Vo351drln74sggXHrlRD+cvcooFrmThmulS+L6hxkC2WYzOV33mWrKIJhJKjfG zPICKUS1LRRJCy9A6MVo7aqOmcrKWk3a9AQwCne+ALLm17ZACBFEYSnuSz/NaOzHOlFmG/HGh +qkgIAoQepRi0vX7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With CONFIG_V4L2=m and VIDEO_SAMSUNG_EXYNOS4_IS=y, we can select the individual drivers as built-in code when that should not be possible: drivers/built-in.o: In function `s5pcsis_set_fmt': policy.c:(.text+0x13afdc): undefined reference to `v4l_bound_align_image' drivers/built-in.o: In function `s5pcsis_probe': policy.c:(.text+0x13b440): undefined reference to `v4l2_of_parse_endpoint' policy.c:(.text+0x13b72c): undefined reference to `v4l2_subdev_init' Changing VIDEO_SAMSUNG_EXYNOS4_IS to tristate means that the dependency from CONFIG_V4L2 propates to the individual Kconfig symbols and they can only be built as loadable modules if V4L2 or any other of the dependencies itself is a module. Signed-off-by: Arnd Bergmann diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig index 40423c6c5324..57d42c6172c5 100644 --- a/drivers/media/platform/exynos4-is/Kconfig +++ b/drivers/media/platform/exynos4-is/Kconfig @@ -1,6 +1,6 @@ config VIDEO_SAMSUNG_EXYNOS4_IS - bool "Samsung S5P/EXYNOS4 SoC series Camera Subsystem driver" + tristate "Samsung S5P/EXYNOS4 SoC series Camera Subsystem driver" depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API depends on ARCH_S5PV210 || ARCH_EXYNOS || COMPILE_TEST depends on OF && COMMON_CLK