From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408AbbIKEos (ORCPT ); Fri, 11 Sep 2015 00:44:48 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:35418 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbIKEor (ORCPT ); Fri, 11 Sep 2015 00:44:47 -0400 X-AuditID: cbfee68e-f79c56d000006efb-35-55f25c3decff Date: Fri, 11 Sep 2015 04:44:45 +0000 (GMT) From: MyungJoo Ham Subject: Re: [PATCH] PM / devfreq: Fix incorrect type issue. To: Xiaolong Ye , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "yizhang@marvell.com" , "kliu5@marvell.com" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20150911043910788@myungjoo.ham Msgkey: 20150911043910788@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150911043910788@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <2087694045.934751441946684139.JavaMail.weblogic@ep2mlwas04a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsWyRsSkRNc25lOowbE34haXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugStjz6ZjTAUreCvW/T3G0sD4g6eLkZNDSEBdYtGSk2wgtoSAicTb aReZIGwxiQv31gPFuYBqljJKXDv6nR2m6MiOJlaIxBxGiQuv1zF2MXJwsAioSizeFwpisgno Scz8nAxSLixgI3Fv9RVGkHIRgYNMEh/mPGKFWKwksWbfKxYQm1dAUOLkzCcsEPNVJSb3rIeK q0kcX/sWaq+4xIW5l6BsXokZ7U+h6uUkpn1dwwxhS0ucn7WBEeaBxd8fQ8X5JY7d3gH1mIDE 1DMHoWq0JO4e/ws1k09izcK3LDD1u04tZ4bZdX/LXKheCYmtLU/A7mcWUJSY0v2QHeRfZgFN ifW79NG9wivgKbH85m1wGEoItHJILFg1AWwXC9AN3yYfYpnAqDgLSc8sJGNnIYxFVrKAkWUV o2hqQXJBcVJ6kZFecWJucWleul5yfu4mRmBaOP3vWd8OxpsHrA8xCnAwKvHwWqh+ChViTSwr rsw9xGgKtHkis5Rocj4w+eSVxBsamxlZmJqYGhuZW5opifMmSP0MFhJITyxJzU5NLUgtii8q zUktPsTIxMEp1cBoyPRu7rJ5sxIKRQUKNj7MeROUrf4sV/2wbebCIN5HP3wPp1x61zf57qGO 95FfqvkC3lke+DmTfdp3Lf30/HvPxTIuNPb3Trp9PFpq9VfjniUi5z7qx5r93SIZvnJ7y+Jj SsFlX3dN9VgaxLfwpMHqoqwOqZsfJ1+oMNW8fKteSSXwtBtvdfMNJZbijERDLeai4kQAWXgR cgYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBKsWRmVeSWpSXmKPExsVy+t/tPl3bmE+hBlMuC1pc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q+NYK0MDAyNToJqEtIw9 m44xFazgrVj39xhLA+MPni5GTg4hAXWJRUtOsoHYEgImEkd2NLFC2GISF+6tB4pzAdXMYZS4 8HodYxcjBweLgKrE4n2hICabgJ7EzM/JIOXCAjYS91ZfYQQpFxE4yCTxYc4jVoj5ShJr9r1i AbF5BQQlTs58wgIxX1Vics96qLiaxPG1b9kh4uISF+ZegrJ5JWa0P4Wql5OY9nUNM4QtLXF+ 1gZGmDsXf38MFeeXOHZ7BxOELSAx9cxBqBotibvH/0LN5JNYs/AtC0z9rlPLmWF23d8yF6pX QmJryxOw+5kFFCWmdD9kB/mXWUBTYv0ufXSv8Ap4Siy/eZttAqPMLCSpWUi6ZyF0IytZwMiy ilE0tSC5oDgpvcJErzgxt7g0L10vOT93EyM41TxbsoOx4YL1IUYBDkYlHl4L1U+hQqyJZcWV uYcYJTiYlUR4DeSAQrwpiZVVqUX58UWlOanFhxhNgdE0kVlKNDkfmAbzSuINjY1NzExMLU0s DEzNlcR51VY+CxUSSE8sSc1OTS1ILYLpY+LglGpgvHA0uZSn4NZ21Q/FDCaHH8inXNY70cS7 JeF6bfXPjq03LfqSJa6t3BAV3Xt9+bzsfeYrxM4v7j603pYrd4JpVpNhzeZVT/d6CZm9u7e1 U2kNx7SS8qnzq6b576w6cTylTY3xkPV6NbE6p9ldCZEip5+XNx6Yt3uPg2Dg1KOv/vSePxXw 7MJlZiWW4oxEQy3mouJEAJlZhGxLAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8B4iqVl004078 > time_in_state in struct devfreq is defined as unsigned long, so > devm_kzalloc should use sizeof(unsigned long) as argument instead > of sizeof(unsigned int), otherwise it will cause unexpected result > in 64bit system. > > Signed-off-by: Xiaolong Ye > Signed-off-by: Kevin Liu Thanks! Signed-off-by: MyungJoo Ham Which SoC are you working with? Are you going to upstream your 64bit devfreq driver soon? Cheers, MyungJoo > --- > drivers/devfreq/devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index ca1b362..ac9845a 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -482,7 +482,7 @@ struct devfreq *devfreq_add_device(struct device *dev, > devfreq->profile->max_state * > devfreq->profile->max_state, > GFP_KERNEL); > - devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned int) * > + devfreq->time_in_state = devm_kzalloc(dev, sizeof(unsigned long) * > devfreq->profile->max_state, > GFP_KERNEL); > devfreq->last_stat_updated = jiffies; > -- > 1.7.9.5 {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I