mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Wang <liwang@kylinos.cn>
To: Bernd Schubert <bernd@bsbernd.com>, Miklos Szeredi <miklos@szeredi.hu>
Cc: Joanne Koong <joannelkoong@gmail.com>,
	fuse-devel@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: fix kernel NULL pointer dereference in fuse_uring_add_to_pq()
Date: Thu, 23 Apr 2026 10:04:51 +0800	[thread overview]
Message-ID: <2088c32d-e01f-4553-b4ab-eb69739878e5@kylinos.cn> (raw)
In-Reply-To: <4ff484d8-c1a3-4828-b500-796f4fb8790c@bsbernd.com>

Hi Bernd,

On 22/04/2026 19:39, Bernd Schubert wrote:
> 
> I don't think this patch is right. The existing order is
> 
> 	queue = kzalloc_obj(*queue, GFP_KERNEL_ACCOUNT);
> 	pq = kzalloc_objs(struct list_head, FUSE_PQ_HASH_SIZE);
> 	queue->fpq.processing = pq;
> 	fuse_pqueue_init(&queue->fpq); =====> INIT_LIST_HEAD() of pg
> 
> 
> I need to look at Miklos' patches, I guess it sends to fuse-io-uring,
> although that is not ready yet.
> 
> 
> Thanks,
> Bernd

The test is based on 
git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#for-next
It seems the code ordering has been changed.

Thanks,
Li

  reply	other threads:[~2026-04-23  2:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 10:36 Li Wang
2026-04-22 11:18 ` Jingbo Xu
2026-04-23  1:52   ` Li Wang
2026-04-22 11:39 ` Bernd Schubert
2026-04-23  2:04   ` Li Wang [this message]
2026-04-22 19:18 ` Joanne Koong
2026-04-23  6:44   ` Li Wang
2026-04-23  7:17     ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2088c32d-e01f-4553-b4ab-eb69739878e5@kylinos.cn \
    --to=liwang@kylinos.cn \
    --cc=bernd@bsbernd.com \
    --cc=fuse-devel@lists.linux.dev \
    --cc=joannelkoong@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®