From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CC583CAE75 for ; Thu, 2 Jul 2026 10:53:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782989596; cv=none; b=plZK5pQZmWe/vJBMrJe45blgPu2uta7viET2Q8R+3YbL29OWc7w/iXUqN8JHUNVWJPWlKkqXDZFl3cHXdYJAGIc59CFYEysOR0NPTwubMONBK+X8tZtPKnKMquXTy9H4jo2C2qlp6rQUQuuSLUmZjAOHdNUuCcawhDJ2KpXUWLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782989596; c=relaxed/simple; bh=6U6wDTcPfBB7WCZEXQJ3tm/lEteQLn1NIyqW2IV28qk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ClMBq0FqWSZyuiuqnDuoxf+MV/lmn763IwwsYlTEuQu5HQ7xXxi4a27ldfsnUaNmFU2qFxpsC25OX/awCgREIj39DAkpwyfZURiqvZwLO4pguw5xG+Q8kTgsgDmK64CksrgGd2wIX+KoTB5/YbNWX/P5VY9qreGoP2u6/h1qiVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Kc0kFa5b; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kDiHHH+/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Kc0kFa5b"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kDiHHH+/" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 662AZOiu3591734 for ; Thu, 2 Jul 2026 10:53:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2eCfS2QL6sqR3JAm60+hzD+iml/Wt1WkpXB1sDtuyys=; b=Kc0kFa5b0Rr0n1+N CPGUizMo5VTQGB7CRMFllSvXlO7MWQOY7rtnn2GcFQtl2FtXqPwMqfq4Wo8CzuQx rAjwutY6EZ9gIT1gqcxZM17mPUufz196G97KqjCVb8CoiHkIU4kwjdeFL/yRf02F NqCOhgoZ2TURweEyV/6Ime6argJmikYqxJvO+9yK8COAY2whj/GGNa5aVbdrlnkK xnWeYG+U3D6KPQw/KA1nbwCmsLUs3r0Y3xZvXaSqNkSnO0Lu+VCGaleaEcDR4WdN oK8XqnU52IKGmzi/SNqSE4h3yU9Krun1S4nUEdM0k9orFpHlaXomdE+N1HqLqetJ Ef7fbQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5h7n9b4h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 10:53:14 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c27616421so4217561cf.2 for ; Thu, 02 Jul 2026 03:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782989593; x=1783594393; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2eCfS2QL6sqR3JAm60+hzD+iml/Wt1WkpXB1sDtuyys=; b=kDiHHH+/OJkYXSox9mbHVcjc/6toUNDj+QKavxPM5QZrb4X976UUq89qMrWPF26DiV tARzBOOC+LBENEGwSJgUSg6AGeEkWk9+nmszH2GO4nDGfJDPwExn/ZBvMRMPB4PSxtC2 x44lxmN07g6qQi3wP9dc7wYZzVFuZwYXrFA/0AwjPBVGjVSMY0/wnK55WEwxfRpYpWjH NfCqQ62f8U1wQ3SC05ic4a/QcYVY2XGotWLAwhkHCIc+iPGsUJEeFl98+0Fx99+/Reth ZJLVka0PUBno3P/OWILZpwktqCulXq2HhAyj2qgFVvk/opS0FzhVphGUqh3RzXfR3F0s tGbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782989593; x=1783594393; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2eCfS2QL6sqR3JAm60+hzD+iml/Wt1WkpXB1sDtuyys=; b=gDNukxp8GS/0//ptr+LjR4Yt6DAuSCFmTxKW0Ob7MSzVIJ/WNXjy32kficRNT8J7A7 AZNmL7qr74uLawV7x6jUgSP0aDLxo5dXX7w9Osw+Qh3XL7qnMnt0BcIdwkew5ksgrxTF g3FTEZ/IaX9SQLi2+9PJMEA6eYCE+CKwKnd7fwffmavuuuRWb+vntRlx0fEGvwztTscu MXWu2G8uVXtGEFubN12dCDbqA/nnjZx+QW8zTrFdQBdQEL7zgah6UERIHjYszd7o3HPW Ro8+hsLKtpKCV+sOuHUGFX/5eKxqwOMhzG7tFDmADjIxL02zP86xiesU/3ydfVQAjPXA XTgg== X-Forwarded-Encrypted: i=1; AFNElJ+Cc/ncrdH/DuOuU8Xifj5MbnERuDBrMvhUU8K+CgKeB9Qv0/tJUESs9EMjmyZyADascIwgOMyIB80GVlQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzo/aDIx2PBRZa38iEQuA35HaE1n8gClxCNBr0JVc6iTgqxmkwo nb67w3R9W+MHjSPRIFjVUvziFELAyu9o1ZHCx2sH97f3Yv8+OACRzRL7IHaGHb1cOSxOm+dksZL 3ue2lge54ytvfDYJ7WvBp61LH+e7APsTpjZo/y3GV/47IOmskKJRtsewqDEMBJr9y/v4= X-Gm-Gg: AfdE7cmKhtmyjrX1jsbk8qAnV+GrEfAKNxHpSOE96PoD8R3L6IVdczA7Cv9cfGe3BjU qDPqyOnoQ11U47K8N7b1brcdDr4QouAfmtt/N9y1wyJM872q/7FyYAV/bPgTg6SCoAKS8iJhRJo FasBFZiAlmbdoi7qm1IFm3EmfwNBfy8mYwUSpzQEkvQHSumKrnMIp2MQQcKTKOrUE3V/Tkx1jh5 JQIsP1y0QBHF/7DWzhEMzEr1t+EMEYj7W+/pYIEfowIvhXvWMQHKH7xL/AxOaNvNls3ko306t0m nGq+oKSrqf1ACbYH8ZClmIPdnQixrlz17z6+VgJ29GIql6o5ToifMz6GXgHAwU3p5hlqe8xoFMt fiFs/imG0Urm2Ud39YG35qNq0CHx6YvypCsQ= X-Received: by 2002:a05:622a:14d1:b0:51c:a85:bf91 with SMTP id d75a77b69052e-51c26a76bc9mr42280131cf.3.1782989593202; Thu, 02 Jul 2026 03:53:13 -0700 (PDT) X-Received: by 2002:a05:622a:14d1:b0:51c:a85:bf91 with SMTP id d75a77b69052e-51c26a76bc9mr42280071cf.3.1782989592797; Thu, 02 Jul 2026 03:53:12 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-698ad13625dsm813217a12.31.2026.07.02.03.53.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:53:10 -0700 (PDT) Message-ID: <208bb65f-d287-49db-8b36-2b07f5284078@oss.qualcomm.com> Date: Thu, 2 Jul 2026 12:53:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] firmware: qcom: tzmem: guard against IS_ERR() in the cleanup handler To: Bartosz Golaszewski , Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260701-qcom-scm-code-shrink-v1-0-02f5ce02c95a@oss.qualcomm.com> <20260701-qcom-scm-code-shrink-v1-1-02f5ce02c95a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260701-qcom-scm-code-shrink-v1-1-02f5ce02c95a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDExMyBTYWx0ZWRfX3fIIWu9dtiH2 S8idbeWjH7JbM7z6CwcXQUdKMi34HGpSg5Ih0CiIkAJKKwkDpJRFP/4oIer12eUgSlDfTgxyZWl NGKJJO0DemzkHs4/hsVs7fA+y6RMLmzwa9cOFCP1d49ZLiUALH7QCXodIKRa2cMTULfbO+mAP/2 CSnm9+SXlr6kJ15BB3cUdNvWuMf+NASQpwhAQ96feFlnba4W/kGS6FWLdeodU81B95NLRVN2Bt7 4HzQTePLI417UAzEEuyEjLBQ1I0mtmQfmJ1qFr9Cxq8sO5ur/RLAvGYE/f5TGfRyAleSlgH6I1L 2Gs/JTh4MJgVjqex9/m3x81qEYUMVGfOGv9qROmtFpxiThSmnXERfGxNWLAWe5nt2cG5WvFsKy+ q8dfYAixORBihQKkfFPfr6vXR2kjfhh51q9TRsiIT255zUBYhsquFqEQC8xsq7cNlYYC6X1RpY2 XwAbRMzjhkNgHkydSTQ== X-Proofpoint-ORIG-GUID: MfaMzf9ZGq2jdq8XVeJVxqSLs-u43NE1 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDExMyBTYWx0ZWRfXxn0l4oBdz52n 0syCpDKKfh8WrJ3trLVz+F+wBogLleNIjDzN4FuVpG9NfBHh9/pXCQQc41QgZBr4Yg6Kh3SBS4T bnxRuw7CUiK8R8gnH5fxwZzzbYBUnNg= X-Proofpoint-GUID: MfaMzf9ZGq2jdq8XVeJVxqSLs-u43NE1 X-Authority-Analysis: v=2.4 cv=WMBPmHsR c=1 sm=1 tr=0 ts=6a46431a cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=2mVBGBvLARuhPHERpnQA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020113 On 7/1/26 3:38 PM, Bartosz Golaszewski wrote: > We currently only silently skip NULL-pointers in the cleanup handler for > tzmem. It's possible that we get passed a pointer holding an ERR_PTR() > value so skip it too. > > Signed-off-by: Bartosz Golaszewski > --- Reviewed-by: Konrad Dybcio Konrad