From: Robin Murphy <robin.murphy@arm.com>
To: Joerg Roedel <joro@8bytes.org>,
Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: Yuqi Jin <jinyuqi@huawei.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/iova: Replace cmpxchg with xchg in queue_iova
Date: Fri, 4 Sep 2020 10:58:14 +0100 [thread overview]
Message-ID: <208d2f74-1a04-f01e-b885-c175b0480784@arm.com> (raw)
In-Reply-To: <20200904093732.GN6714@8bytes.org>
Hi Joerg,
On 2020-09-04 10:37, Joerg Roedel wrote:
> Adding Robin.
Did you miss that I've reviewed this already? :)
https://lore.kernel.org/linux-iommu/3afcc7b2-0bfb-b79c-513f-1beb66c5f164@arm.com/
Robin.
> On Thu, Aug 27, 2020 at 04:43:54PM +0800, Shaokun Zhang wrote:
>> From: Yuqi Jin <jinyuqi@huawei.com>
>>
>> The performance of the atomic_xchg is better than atomic_cmpxchg because
>> no comparison is required. While the value of @fq_timer_on can only be 0
>> or 1. Let's use atomic_xchg instead of atomic_cmpxchg here because we
>> only need to check that the value changes from 0 to 1 or from 1 to 1.
>>
>> Cc: Joerg Roedel <joro@8bytes.org>
>> Signed-off-by: Yuqi Jin <jinyuqi@huawei.com>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>> drivers/iommu/iova.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c
>> index 45a251da5453..30d969a4c5fd 100644
>> --- a/drivers/iommu/iova.c
>> +++ b/drivers/iommu/iova.c
>> @@ -579,7 +579,7 @@ void queue_iova(struct iova_domain *iovad,
>>
>> /* Avoid false sharing as much as possible. */
>> if (!atomic_read(&iovad->fq_timer_on) &&
>> - !atomic_cmpxchg(&iovad->fq_timer_on, 0, 1))
>> + !atomic_xchg(&iovad->fq_timer_on, 1))
>> mod_timer(&iovad->fq_timer,
>> jiffies + msecs_to_jiffies(IOVA_FQ_TIMEOUT));
>> }
>> --
>> 2.7.4
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
>
next prev parent reply other threads:[~2020-09-04 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 8:43 Shaokun Zhang
2020-08-27 19:41 ` Robin Murphy
2020-09-04 9:37 ` Joerg Roedel
2020-09-04 9:58 ` Robin Murphy [this message]
2020-09-04 10:10 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=208d2f74-1a04-f01e-b885-c175b0480784@arm.com \
--to=robin.murphy@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jinyuqi@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®