From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A13C93D5258 for ; Tue, 2 Jun 2026 11:12:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780398769; cv=none; b=g1nC7W+I0vO7td2OWS/X+MUnOu8j1JlzCOtK9eS1Yl8o5+uOAFYjklMWwqiJMvvUS+px7pR7IDNXgiozmOavRgvwRmpafY/J21qmO0fZwcAOKIwftI6LB+Ko2j9K1VhNLVXCbotTUL9oC38/8qQyh1lfr6wFZR5DITq6vnTpBNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780398769; c=relaxed/simple; bh=OR388PN+R8iXCryfYfMn0uk00Bh1a+mLKoUwk2NbhB8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rPnJWZl0uZONT1RHz+YwHOJTm7QANL7YkaIz0p66cui8ngpGfOgSYMGDUraaBM6q8WxoXv57gkm/hg5YoLiQy8XUQDMxc/donE5U/38Vh4vAlta405Xp5rPFCIUM3aPzbpuL78bbI4JAcvOAJJzB77C+P5rbwj/pvPDBN4z9esU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com; spf=pass smtp.mailfrom=arista.com; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b=OYnVs0+1; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arista.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="OYnVs0+1" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-490b3637b90so3186235e9.3 for ; Tue, 02 Jun 2026 04:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1780398761; x=1781003561; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YKEseg4pTB9VF+7SmfAwywfYvp28t3PBtR5WqnsSCWw=; b=OYnVs0+1EyzuooQiMhz9iOp1wnAgxLSE8RDTucDoTL8Y4Vb4d+NWfjOz5ShPE+TSRv GfbfLznb2yOG3Vqgjq4xYoZFB2JE4TatGJIZDFTkKc967Gc0I+IWqyTRbVpLQ/Wh5/Km uAGlVLevTfPvWfJmHk9UFVknvVVLPwhF3K+bdtUnPNdkT+ZRyRT/BM4yGtSwp1qHyjuN 3GxQKF+T8+Eq61G4/U/gYw61K/4JBegTZSSETaABP1XApFmrYKYQ/srMDcHXQN32EGAD 1VGqZIypWLeSlpLgXJ7tazlGcu+tr2GwQAW2TTrqjMLD/5Cg1SKhUhcy+zHE2xrnbeCA XVbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780398761; x=1781003561; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YKEseg4pTB9VF+7SmfAwywfYvp28t3PBtR5WqnsSCWw=; b=In2JWmSMcom5EfEjNChtNhk2LnxLW97TBu5/OE8syW2YPXYG/dd2e31YiD/GR4I/g/ rz1kOQ+MwNAJfnj7CzX482w6JHynN53lgFbw4G55vtua40HGaPkUWlkVC/37brbEzAg3 uA9JbNKUj80qEph0U4d5RQ/x/bXxGxDxR43AgkJnYIQXXF872gQps8oljXp228Rtb2GJ pdkEb5N45stQwAudeL5agYkq8+eRuRo4fbGz5viNj676jQwUNf9s+GyDtru0nWr+rHCL N6G2dLZ/H8TIsozfRM5R2GZLMhCPYn5wGF9mIbRs+bltcnQr0ITVzSOuBnLnvlHknnMM 8ItA== X-Forwarded-Encrypted: i=1; AFNElJ8khJ/hIQ0fJgRlhSiFDaUGcGT4gImIJ2D9F5KIJ/qvTPIepNPnxP3b6hSpoRigu8vZ8WDSmAX1u6+gF9E=@vger.kernel.org X-Gm-Message-State: AOJu0YxEPJhwhvx7GyiXDypjx0c+uoqH0TGsoTpr6xZIRlqJbGKP2Riy 29pb9JUB2jwLHABXVqF0Vb6EHUJhGEgFS8dpBm3Axp0zVuhHRf47mi1xu205OuVOhg== X-Gm-Gg: Acq92OFgsOgdTI7OBvQImSh0T8s9TvY4zZwdTZTZ2Q7vVsPqEi36tLIEb+UiWLeKwEX xfms/NwB9lXMmsjFwNQBrX7yntf1WZ6dKuy26rP+O6AqN9+yGuKiqSpKmlnfsJsq19/gYsM390C yUAMW+EDNRNYo+U7Tj5fkB7bkCULmDKcQwLbU/0I5tCd5S55sjFt6VMRJUjIMq6H4/wLTlNWoe/ 9paqj1SjvEI4xbBVp1Qg/0/27DMTkhhUY87SaW7EQOkhQ3202xO4MjhNRN3QZBkV7vlzjuSeUBs yYfV4qCEfKy0fqtl4IZHoFr5r2yVrdIQi+lLoPYet73aicajNASdBGhCAdCZihxdPMtNP/VRy/Z NX9oKIhX4JGe9gucMCoEkfAPY1mbUJZjZ1YJKqMyjx5VxQKpYJA1StJeydNQrF0vpPX7dXtyupP 84ICgqODJA8ZTcEEsmEAmNszpO0IQTdMpcpw== X-Received: by 2002:a05:600c:1d86:b0:48e:60a3:220a with SMTP id 5b1f17b1804b1-490a28aa789mr287889775e9.0.1780398760904; Tue, 02 Jun 2026 04:12:40 -0700 (PDT) Received: from [10.83.43.186] ([159.134.255.34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b0daefbbsm102675545e9.0.2026.06.02.04.12.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 04:12:40 -0700 (PDT) Message-ID: <208dc7c2-971b-4335-bd64-a107be8c6018@arista.com> Date: Tue, 2 Jun 2026 12:12:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4] net: tg3: guard napi_disable and pci_disable_device calls To: Jakub Kicinski Cc: pavan.chebbi@broadcom.com, mchan@broadcom.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260527115535.1686932-1-yurypm@arista.com> <20260601195049.766544fb@kernel.org> Content-Language: en-US From: "Yury M." In-Reply-To: <20260601195049.766544fb@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/2/26 03:50, Jakub Kicinski wrote: > On Wed, 27 May 2026 11:55:35 +0000 Yury Murashka wrote: >> During PCIe hot-plug events, uncorrectable errors can be reported and >> AER recovery for the tg3 device is initiated by the AER kernel driver. >> The tg3_io_error_detected function is the AER error recovery handler. > IDK, I really hate this NAPI specific tracking. Can we add a callback > to struct pci_error_handlers to let the driver know that things went > fully belly up and the driver should pack up its toys? Sounds to me > like the key issue here is that there's a side exit thru the state > machine. 1. We already have a similar check in the bnxt driver. Please check the BNXT_STATE_NAPI_DISABLED flag. 2. I'm trying to fix a specific issue in this specific driver. 3. Your suggested changes are a long-term option for the fix. They require a redesign of the AER feature. Plus, I'm not sure they will be accepted.