mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Takashi Sato" <sho@bsd.tnes.nec.co.jp>
To: "Andreas Dilger" <adilger@clusterfs.com>,
	"Mingming Cao" <cmm@us.ibm.com>
Cc: <linux-kernel@vger.kernel.org>, <Ext2-devel@lists.sourceforge.net>
Subject: Re: [Ext2-devel] [RFC][8/21]ext3 modify variables to exceed 2G
Date: Fri, 14 Apr 2006 18:23:24 +0900	[thread overview]
Message-ID: <208e01c65fa5$17a3c850$4168010a@bsd.tnes.nec.co.jp> (raw)
In-Reply-To: <20060413171445.GT17364@schatzie.adilger.int>

Thank you for your comment, Andreas.

> Takashi-san, please, it would make the code much more maintainable if the
> changes made here would use new types for filesystem-wide block offsets
> and for file-relative block offsets, as was previously discussed, instead
> of just changing some variables to be unsigned long.  Like:
> 
> typedef unsigned long ext3_fsblk_t; # block offset in the filesystem
> typedef unsigned long ext3_fscnt_t; # block count in the filesystem
> typedef unsigned long ext3_fileblk_t; # block offset in a file

I agree that, but it will need a lots of work...
Mingming, you got same comment from Andreas in "Extend ext3
filesystem limit from 8TB to 16TB", did you do something about
this?

Cheers, sho

  reply	other threads:[~2006-04-14  9:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-13  7:06 sho
2006-04-13 17:14 ` [Ext2-devel] " Andreas Dilger
2006-04-14  9:23   ` Takashi Sato [this message]
2006-04-14 14:59     ` Mingming Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='208e01c65fa5$17a3c850$4168010a@bsd.tnes.nec.co.jp' \
    --to=sho@bsd.tnes.nec.co.jp \
    --cc=Ext2-devel@lists.sourceforge.net \
    --cc=adilger@clusterfs.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®