From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B429C4361B for ; Fri, 11 Dec 2020 18:10:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39C6B23106 for ; Fri, 11 Dec 2020 18:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730375AbgLKQ5Y (ORCPT ); Fri, 11 Dec 2020 11:57:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:39466 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729257AbgLKQ4v (ORCPT ); Fri, 11 Dec 2020 11:56:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4547BB066; Fri, 11 Dec 2020 16:56:09 +0000 (UTC) Subject: Re: [PATCH 0/3] block: blk_interposer - Block Layer Interposer To: Jens Axboe , Mike Snitzer , Sergei Shtepa , hch@lst.de Cc: "johannes.thumshirn@wdc.com" , "koct9i@gmail.com" , "ming.lei@redhat.com" , "josef@toxicpanda.com" , "steve@sk2.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pavel Tide , dm-devel@redhat.com References: <1607518911-30692-1-git-send-email-sergei.shtepa@veeam.com> <20201209135148.GA32720@redhat.com> <20201210145814.GA31521@veeam.com> <20201210163222.GB10239@redhat.com> <20201211163049.GC16168@redhat.com> <1ee7652e-b77f-6fa4-634c-ff6639037321@kernel.dk> From: Hannes Reinecke Message-ID: <208edf35-ecdc-2d73-4c48-0424943a78c0@suse.de> Date: Fri, 11 Dec 2020 17:56:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1ee7652e-b77f-6fa4-634c-ff6639037321@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/20 5:33 PM, Jens Axboe wrote: > On 12/11/20 9:30 AM, Mike Snitzer wrote: >> While I still think there needs to be a proper _upstream_ consumer of >> blk_interposer as a condition of it going in.. I'll let others make the >> call. > > That's an unequivocal rule. > >> As such, I'll defer to Jens, Christoph and others on whether your >> minimalist blk_interposer hook is acceptable in the near-term. > > I don't think so, we don't do short term bandaids just to plan on > ripping that out when the real functionality is there. IMHO, the dm > approach is the way to go - it provides exactly the functionality that > is needed in an appropriate way, instead of hacking some "interposer" > into the core block layer. > Which is my plan, too. I'll be working with the Veeam folks to present a joint patchset (including the DM bits) for the next round. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer