From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>,
Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: qcom-geni: update frequency table to fix timing parameters
Date: Tue, 11 Aug 2026 21:26:45 +0530 [thread overview]
Message-ID: <208f6a30-603e-4c0e-a7a9-a6e647b95d69@oss.qualcomm.com> (raw)
In-Reply-To: <8a6581f8-e9e3-4c02-8d26-245c102e7428@oss.qualcomm.com>
On 8/11/2026 6:12 PM, Mukesh Savaliya wrote:
>
>
> On 8/11/2026 2:53 PM, Kathiravan Thirumoorthy wrote:
>> In IPQ5424, to meet the setup and hold timing requirements in the
>> standard mode, update the frequency table with the values recommended by
> Changes are fore FAST mode too, please update the commit log accordingly.
There are no changes to the FAST mode. As mentioned below, I just
removed the extra space between values 4 and 3.
>> HW design team.
>>
>> Also remove the stray space in the I2C_MAX_FAST_MODE_FREQ entry.
>>
>> Cc: <stable@vger.kernel.org>
>> Fixes: 85c34532849d ("i2c: qcom-geni: fix I2C frequency table to
>> achieve accurate bus rates")
>> Fixes: 506bb2ab0075 ("i2c: qcom-geni: Support systems with 32MHz
>> serial engine clock")
>> Signed-off-by: Kathiravan Thirumoorthy
>> <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>> drivers/i2c/busses/i2c-qcom-geni.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c
>> b/drivers/i2c/busses/i2c-qcom-geni.c
>> index 658636c1ee0e..00013b41a6f5 100644
>> --- a/drivers/i2c/busses/i2c-qcom-geni.c
>> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
>> @@ -188,8 +188,8 @@ static const struct geni_i2c_clk_fld
>> geni_i2c_clk_map_19p2mhz[] = {
>> /* source_clock = 32 MHz */
>> static const struct geni_i2c_clk_fld geni_i2c_clk_map_32mhz[] = {
>> - { I2C_MAX_STANDARD_MODE_FREQ, 8, 14, 18, 38 },
>> - { I2C_MAX_FAST_MODE_FREQ, 4, 3, 9, 19 },
>> + { I2C_MAX_STANDARD_MODE_FREQ, 12, 9, 10, 26 },
>> + { I2C_MAX_FAST_MODE_FREQ, 4, 3, 9, 19 },
>> { I2C_MAX_FAST_MODE_PLUS_FREQ, 2, 3, 5, 15 },
>> {}
>> };
>>
>
next prev parent reply other threads:[~2026-08-11 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 9:23 [PATCH 0/2] I2C SCL counter updates for Qualcomm IPQ5424 SoC Kathiravan Thirumoorthy
2026-08-11 9:23 ` [PATCH 1/2] i2c: qcom-geni: update frequency table to fix timing parameters Kathiravan Thirumoorthy
2026-08-11 12:42 ` Mukesh Savaliya
2026-08-11 15:56 ` Kathiravan Thirumoorthy [this message]
2026-08-11 9:23 ` [PATCH 2/2] i2c: qcom-geni: Add I2C frequency table for firmware-based SEs Kathiravan Thirumoorthy
2026-08-11 12:42 ` Mukesh Savaliya
2026-08-11 15:59 ` Kathiravan Thirumoorthy
2026-08-11 12:41 ` [PATCH 0/2] I2C SCL counter updates for Qualcomm IPQ5424 SoC Mukesh Savaliya
2026-08-11 16:00 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=208f6a30-603e-4c0e-a7a9-a6e647b95d69@oss.qualcomm.com \
--to=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®