mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>, Vlim <vlim@gigadevice.com>
Cc: Michael Walle <michael@walle.cc>,
	Victor Lim <victorswlim@gmail.com>,
	"tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
	"p.yadav@ti.com" <p.yadav@ti.com>,
	"richard@nod.at" <richard@nod.at>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"vikhyat.goyal@amd.com" <vikhyat.goyal@amd.com>,
	"amit.kumar-mahapatra@amd.com" <amit.kumar-mahapatra@amd.com>,
	"alejandro.carmona@amd.com" <alejandro.carmona@amd.com>
Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
Date: Tue, 6 Dec 2022 12:37:02 +0100	[thread overview]
Message-ID: <208ffab6-a20b-c6f0-7ea7-cb258a7c894c@kontron.de> (raw)
In-Reply-To: <20221206091846.02f6396f@xps-13>

On 06.12.22 09:18, Miquel Raynal wrote:
> Hi Vlim,
> 
> vlim@gigadevice.com wrote on Tue, 6 Dec 2022 01:27:13 +0000:
> 
>> Hi, Michael,
>>
>> I will redo the patch following this doc.
>> At the meantime, can you point out a few mistakes that I am making so that I can correct it in the next submit.
> 
> Here are a few:
> - The title is wrong (git log --oneline <file> for hints)
> - The commit log is useless
> - Don't make unrelated changes in your commit, one change == one commit
> - Don't change how the code looks like for no reason or justification
> 
> And please avoid top posting when answering.

Here are some more:

* sending (almost) the same wrong patch again ignoring feedback from
maintainers
* not using version prefixes in your subject line (PATCH v2: ...)
* not adding a changelog to your patch
* keeping your replies off the mailing list (probably your @gigadevice
address is not subscribed!?)

  parent reply	other threads:[~2022-12-06 11:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-04  8:00 Victor Lim
2022-12-05  8:22 ` Michael Walle
     [not found]   ` <TY0PR06MB5658B73E2F22472D0AF48BDBBB1B9@TY0PR06MB5658.apcprd06.prod.outlook.com>
2022-12-06  8:17     ` Michael Walle
2022-12-06  8:18     ` Miquel Raynal
     [not found]       ` <TY0PR06MB5658CAF1B83FF3CF92846AA0BB1B9@TY0PR06MB5658.apcprd06.prod.outlook.com>
2022-12-06  8:44         ` Miquel Raynal
2022-12-06 11:37       ` Frieder Schrempf [this message]
2022-12-06 11:44         ` Frieder Schrempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=208ffab6-a20b-c6f0-7ea7-cb258a7c894c@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=alejandro.carmona@amd.com \
    --cc=amit.kumar-mahapatra@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    --cc=victorswlim@gmail.com \
    --cc=vigneshr@ti.com \
    --cc=vikhyat.goyal@amd.com \
    --cc=vlim@gigadevice.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®