From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964946AbcIGJbd (ORCPT ); Wed, 7 Sep 2016 05:31:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52578 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359AbcIGJba (ORCPT ); Wed, 7 Sep 2016 05:31:30 -0400 Subject: Re: [PATCH] usb: phy: add USB_SUPPORT dependency To: Arnd Bergmann , Kishon Vijay Abraham I References: <20160906125516.1551565-1-arnd@arndb.de> Cc: linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: <20915b65-8be3-cee4-cac1-eab512ab74f5@redhat.com> Date: Wed, 7 Sep 2016 11:31:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160906125516.1551565-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 07 Sep 2016 09:31:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 06-09-16 14:54, Arnd Bergmann wrote: > The driver now calls of_usb_get_dr_mode_by_phy, which is part of the > USB core layer, and it fails to build when that is not provided: > > drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe': > phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to `of_usb_get_dr_mode_by_phy' > > We already have a couple of other PHY drivers with a dependency > on USB_SUPPORT, so that seems to be the easiest fix here. > > An alternative would be to adjust the #ifdef in include/linux/usb/of.h > to also check for CONFIG_USB_SUPPORT. > > Signed-off-by: Arnd Bergmann > Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode") Good catch, patch LGTM: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index c42ddf3c8ed8..985dff8558e5 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -260,6 +260,7 @@ config PHY_SUN4I_USB > depends on RESET_CONTROLLER > depends on EXTCON > depends on POWER_SUPPLY > + depends on USB_SUPPORT > select GENERIC_PHY > help > Enable this to support the transceiver that is part of Allwinner >