mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@it.uu.se>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	David Howells <dhowells@redhat.com>,
	Mikael Pettersson <mikpe@it.uu.se>,
	Orion Poplawski <orion@cora.nwra.com>
Subject: Re: [PATCH] tty: Fix transient pty write() EIO
Date: Sun, 16 Jun 2013 19:31:53 +0200	[thread overview]
Message-ID: <20925.63113.555846.464236@pilspetsen.it.uu.se> (raw)
In-Reply-To: <1371153397-3687-1-git-send-email-peter@hurleysoftware.com>

Peter Hurley writes:
 > Commit 699390354da6c258b65bf8fa79cfd5feaede50b6
 > ('pty: Ignore slave pty close() if never successfully opened')
 > introduced a bug with ptys whereby a write() in parallel with an
 > open() on an existing pty could mistakenly indicate an I/O error.
 > 
 > Only indicate an I/O error if the condition on open() actually exists.
 > 
 > Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
 > Signed-off-by: Peter Hurley <peter@hurleysoftware.com>

I've tested this for two days on 3.9.0 (where the bug reproduces
easily for me, for some reason I can't seem to trigger it with
3.10-rc5), and with the patch I no longer see the bug.

Tested-by: Mikael Pettersson <mikpe@it.uu.se>

 > ---
 >  drivers/tty/pty.c | 13 +++++--------
 >  1 file changed, 5 insertions(+), 8 deletions(-)
 > 
 > diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
 > index 9c2f1bc..dd08d3d 100644
 > --- a/drivers/tty/pty.c
 > +++ b/drivers/tty/pty.c
 > @@ -238,14 +238,9 @@ static void pty_flush_buffer(struct tty_struct *tty)
 >  
 >  static int pty_open(struct tty_struct *tty, struct file *filp)
 >  {
 > -	int	retval = -ENODEV;
 > -
 >  	if (!tty || !tty->link)
 > -		goto out;
 > -
 > -	set_bit(TTY_IO_ERROR, &tty->flags);
 > +		return -ENODEV;
 >  
 > -	retval = -EIO;
 >  	if (test_bit(TTY_OTHER_CLOSED, &tty->flags))
 >  		goto out;
 >  	if (test_bit(TTY_PTY_LOCK, &tty->link->flags))
 > @@ -256,9 +251,11 @@ static int pty_open(struct tty_struct *tty, struct file *filp)
 >  	clear_bit(TTY_IO_ERROR, &tty->flags);
 >  	clear_bit(TTY_OTHER_CLOSED, &tty->link->flags);
 >  	set_bit(TTY_THROTTLED, &tty->flags);
 > -	retval = 0;
 > +	return 0;
 > +
 >  out:
 > -	return retval;
 > +	set_bit(TTY_IO_ERROR, &tty->flags);
 > +	return -EIO;
 >  }
 >  
 >  static void pty_set_termios(struct tty_struct *tty,
 > -- 
 > 1.8.1.2
 > 

  reply	other threads:[~2013-06-16 17:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06 11:54 Strange intermittent EIO error when writing to stdout since v3.8.0 Markus Trippelsdorf
2013-06-06 14:18 ` Peter Hurley
2013-06-06 14:37   ` Markus Trippelsdorf
2013-06-07 15:39     ` Peter Hurley
2013-06-07 16:07       ` Markus Trippelsdorf
2013-06-07 18:22       ` Mikael Pettersson
2013-06-13 10:39         ` Markus Trippelsdorf
2013-06-13 14:16           ` Peter Hurley
2013-06-13 14:51             ` Markus Trippelsdorf
2013-06-13 15:25               ` [PATCH] tty: Debug EIO from write() Peter Hurley
2013-06-13 16:16                 ` Markus Trippelsdorf
2013-06-13 16:29                   ` Peter Hurley
2013-06-13 19:56                     ` [PATCH] tty: Fix transient pty write() EIO Peter Hurley
2013-06-16 17:31                       ` Mikael Pettersson [this message]
2013-06-11 22:14       ` Strange intermittent EIO error when writing to stdout since v3.8.0 Orion Poplawski
2013-06-13 10:38         ` Markus Trippelsdorf
2013-06-07 19:56     ` David Howells
2013-06-06 14:41 ` Mikael Pettersson
2013-06-06 17:31 ` David Howells
2013-06-06 18:41   ` Markus Trippelsdorf
2013-06-08 18:56 ` Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20925.63113.555846.464236@pilspetsen.it.uu.se \
    --to=mikpe@it.uu.se \
    --cc=dhowells@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=orion@cora.nwra.com \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®