Re: mmotm 2009-04-24-18-14 uploaded - NVidia indigestion

[Valdis.Kletnieks@vt.edu]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

On Tue, 28 Apr 2009 08:15:57 +0200, Nick Piggin said:

Here's the code (pretty much *all* the code):

> #include <linux/version.h>
> #include <linux/utsname.h>
> int main() {
> 	if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)) {
> 		return 0;
> 	} else {
> 		return 1;
> 	}
> }

> Hmm, yes if you build without -O, then it appears like the compiler
> trips over this. I wouldn't be unhappy with just removing the BUILD_BUG_ON,
> but shouldn't the module be using -O[s2]?

It's a little autoconfig chunk from vendor code that determines if we're
building on a sane/recent kernel.  Not the sort of thing you'd expect to
need to invoke the frikking optimizer for program *correctness* :)



[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]