From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E37D299A8C; Thu, 13 Nov 2025 18:09:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763057375; cv=none; b=V0ZCqBnhrbDM+yxX8rTch0rx1aqzquLHD2LyRl+xdIZ2uTj2UAY3sal6RCxtIX5pXv5Z5LOyuPjQ5jP12ujfUOKMF8DM3y3FJmJzC3ao2gmvW4FtXTI0K1AjOKUqYYgCUKax1uIDo99aL7OSvsXJYb6Gp7hI/PaFIGZQr1AwfRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763057375; c=relaxed/simple; bh=+WfrJYAcG5cVtaeOgZk4Ik7SVUGLhfv+q/98SoorJR0=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=AMEc5pebWVex25mUxgcDMMvSFcEM6kEJqIyX2tKk3owWzqsP6QkeIEP82IWCgL+celrccyeea5F7PoH7ZbvB9hFzkQerHIjFW3qz8G2KJc8N7P5zQcSBK6HMTTuPZdi+x7DOfI68j/ULuxzxnoV+O+gKRkZ4WdJXx4WGP26pj8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=LGdw+TmK; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="LGdw+TmK" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B448026599; Thu, 13 Nov 2025 19:09:23 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4JuVBlzQUfkY; Thu, 13 Nov 2025 19:09:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1763057363; bh=+WfrJYAcG5cVtaeOgZk4Ik7SVUGLhfv+q/98SoorJR0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=LGdw+TmKg4/ga7JVk6RR2cNrViS4yxLbbMGIC7edjZ4aMgmEVjBt2KUJeymOIP65b izz/D3nd1BuwLkh+CFH7Ecn4mgsSeVDYaoIG7pg+L3nZfW0HAMtR9DBAX5xbTbaIJB WswuogQCKQq6+4bzGcg2nbVgu1wU8GCuFSAQ49Cp4DxZL4NyWbKe7E66JqvDlN/h1I dJarBGWmf4T6agr9xwBxGSYPLqT89m6hFwA5HDdHGAcve9ZGPDVpBHv9bGcqRaybiR zPtODu5O5AOYvlq+InKRc29oMvW/xjwBbg/RBiarpyOrMMQ1ZXWX98JHIrspjH//EM OEKCxNtOVesAQ== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Thu, 13 Nov 2025 18:09:22 +0000 From: Kaustabh Chakraborty To: Miaoqian Lin Cc: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/bridge: samsung-dsim: Fix device node reference leak in samsung_dsim_parse_dt In-Reply-To: <20251029074121.15260-1-linmq006@gmail.com> References: <20251029074121.15260-1-linmq006@gmail.com> Message-ID: <209646801ba4a40da89aa16853524756@disroot.org> X-Sender: kauschluss@disroot.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On 2025-10-29 07:41, Miaoqian Lin wrote: > The function samsung_dsim_parse_dt() calls of_graph_get_endpoint_by_regs() > to get the endpoint device node, but fails to call of_node_put() to release > the reference when the function returns. This results in a device node > reference leak. > > Fix this by adding the missing of_node_put() call before returning from > the function. > > Found via static analysis and code review. > > Fixes: 77169a11d4e9 ("drm/bridge: samsung-dsim: add driver support for exynos7870 DSIM bridge") Is the Fixes: tag correct? This is what I get for relevant code: 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2074) endpoint = of_graph_get_endpoint_by_regs(node, 1, -1); 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2075) nr_lanes = of_property_count_u32_elems(endpoint, "data-lanes"); 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2076) if (nr_lanes > 0 && nr_lanes <= 4) { 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2077) /* Polarity 0 is clock lane, 1..4 are data lanes. */ 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2078) of_property_read_u32_array(endpoint, "lane-polarities", 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2079) lane_polarities, nr_lanes + 1); 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2080) for (i = 1; i <= nr_lanes; i++) { 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2081) if (lane_polarities[1] != lane_polarities[i]) 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2082) DRM_DEV_ERROR(dsi->dev, "Data lanes polarities do not match"); 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2083) } 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2084) if (lane_polarities[0]) 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2085) dsi->swap_dn_dp_clk = true; 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2086) if (lane_polarities[1]) 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2087) dsi->swap_dn_dp_data = true; 74629c49e66cc (Marek Vasut 2023-05-14 08:46:25 -0300 2088) } This should be a fix for 74629c49e66c instead.