mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: TAKANO Mitsuhiro <takano32@gmail.com>, soc@lists.linux.dev
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Mikko Rapeli <mikko.rapeli@linaro.org>,
	Vincent Mailhol <mailhol@kernel.org>
Subject: Re: [PATCH] arm64: defconfig: drop four symbols that no longer exist
Date: Wed, 11 Nov 2026 21:38:12 +0100	[thread overview]
Message-ID: <2097d211-8d96-4038-b21d-6285e5a16c53@kernel.org> (raw)
In-Reply-To: <20261111202914.2558187-1-takano32@gmail.com>

On 11/11/2026 21:29, TAKANO Mitsuhiro wrote:
> None of these symbols exists any more, so the lines look like options that
> can still be chosen:
> 
>   NFS_V4_1                  folded into NFS_V4 (7537db24806f, 2025-12-04)
>   SLIM_QCOM_CTRL            driver removed     (7cbba32a2d62, 2025-09-12)
>   NET_VENDOR_PACKET_ENGINES vendor removed     (aec3202247b4, 2026-04-22)
>   SCHED_DEBUG               option removed     (b52173065e0a, 2025-03-17)
> 
> Three of the lines went stale when their symbol disappeared.  The Ethernet
> line was added by commit 32379ad4060b ("arm64: defconfig: Drop unused
> Ethernet vendors") on 2026-04-29, a week after the packetengines vendor
> directory had been removed, so it was stale from the start.
> 

Nothing below is suitable for git commit, drop.

> Scanning every Kconfig definition in the tree leaves no other stale line
> in this file.  Similar leftovers remain in other architectures'
> defconfigs; those are not touched here.
> 
> Mikko Rapeli sent a patch for the SLIM_QCOM_CTRL line in December 2025,
> and Vincent Mailhol's "configs: cleanup obsolete or incorrect assignments"
> series carried the NFS_V4_1 and SLIM_QCOM_CTRL lines in March 2026; both
> submissions are still unmerged.  This patch covers all four lines and
> would supersede those hunks; I am happy to drop the corresponding hunk if
> either author would rather keep their own.
> 
> Tested as configuration text only: "make ARCH=arm64 defconfig" on v7.4-rc2
> with and without this change gives a byte-identical .config, and "make
> savedefconfig" emits none of the four lines.  No kernel was built or
> booted from this change.
> 
> The change and the changelog text were produced with an AI coding
> assistant (Hermes Agent, model deepseek-v4.1-flash) working from the tree

This goes to changelog, not commit msg, so under ---.

> and the git history.  I reviewed the diff and the reasoning, and I am
> responsible for the submission.

Not suitable for git log.



Best regards,
Krzysztof

      reply	other threads:[~2026-11-11 20:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 20:29 TAKANO Mitsuhiro
2026-11-11 20:38 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2097d211-8d96-4038-b21d-6285e5a16c53@kernel.org \
    --to=krzk@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=mikko.rapeli@linaro.org \
    --cc=soc@lists.linux.dev \
    --cc=takano32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®