From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2B84C197A0 for ; Tue, 21 Nov 2023 00:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232706AbjKUAin (ORCPT ); Mon, 20 Nov 2023 19:38:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjKUAil (ORCPT ); Mon, 20 Nov 2023 19:38:41 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FC4ACF; Mon, 20 Nov 2023 16:38:38 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AL0PcS3011703; Tue, 21 Nov 2023 00:38:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=0/itjaExNH+7XRC48OKXd7v1XRJUqmRluEPlRqEzoNo=; b=iT1oVFCcfWdHht+NRhxX/OQZO5DqZEJ12z3TpJ+FPZUUGywr5jqtJpslS1GMIlysTyS/ cRBOoD0yuIVC7rAMgEZuRTSoFPazuzlZz4Kj5M4ahHACOI03HHOw0IuaSWGcBJGyH3gE Km3mB3/g5/ZGJ0HR3l0F6gMiSJyK2bhAgLfXjjq2RfCD4FhvKZQVVmmt0TdpHzXsW2kL FVgwFdhimZXrIphKWa+toHcMPmIzlBcQlM3vxjR3HhuWAdqTVgY+FOTRLEZCVCX1qBaU 4a2kgGlIbvOH6w0h3ekD46mE6hkZtzvm29jrX3Vq7jPq/H1cVjfqwkOa1bUz5BoyHlIe dg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ug30mj69p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 00:38:31 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AL0cUuM017814 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 00:38:30 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 20 Nov 2023 16:38:28 -0800 Message-ID: <209d6082-35b6-4403-9dc4-a02c0da4fb94@quicinc.com> Date: Tue, 21 Nov 2023 08:38:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/16] arm64: dts: qcom: sm8550-aim300: add SM8550 AIM300 To: Dmitry Baryshkov , , , , , , , CC: , , , <-cc=kernel@quicinc.com> References: <20231117101817.4401-1-quic_tengfan@quicinc.com> <20231117101817.4401-7-quic_tengfan@quicinc.com> From: Tengfei Fan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: kQtM2r9cFGnnoXTNNLOr7I652NoG47h_ X-Proofpoint-ORIG-GUID: kQtM2r9cFGnnoXTNNLOr7I652NoG47h_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-20_22,2023-11-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210001 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 11/17/2023 6:28 PM, Dmitry Baryshkov 写道: > On 17/11/2023 12:18, Tengfei Fan wrote: >> Add a minimal DTS for the new QRD8550 board, serial, UFS and USB should >> be working. > > An explanation of what is AIM300 would be welcomed. > >> >> Signed-off-by: Tengfei Fan >> --- >>   arch/arm64/boot/dts/qcom/Makefile          |   1 + >>   arch/arm64/boot/dts/qcom/sm8550-aim300.dts | 490 +++++++++++++++++++++ >>   2 files changed, 491 insertions(+) >>   create mode 100644 arch/arm64/boot/dts/qcom/sm8550-aim300.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile >> b/arch/arm64/boot/dts/qcom/Makefile >> index d6cb840b7050..ea5d4a07671a 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -229,5 +229,6 @@ dtb-$(CONFIG_ARCH_QCOM)    += sm8450-hdk.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += sm8450-qrd.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += sm8450-sony-xperia-nagara-pdx223.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += sm8450-sony-xperia-nagara-pdx224.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += sm8550-aim300.dtb > > My email client suggests that alignment is broken here. I checked the code after apply this patch, and find this code alignment have not issue, so I will check if have some format issue when I do this patch. > >>   dtb-$(CONFIG_ARCH_QCOM)    += sm8550-mtp.dtb >>   dtb-$(CONFIG_ARCH_QCOM)    += sm8550-qrd.dtb >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-aim300.dts >> b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts >> new file mode 100644 >> index 000000000000..202b979da8ca >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/sm8550-aim300.dts >> @@ -0,0 +1,490 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights >> reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include >> +#include "sm8550.dtsi" >> +#include "pm8010.dtsi" >> +#include "pm8550.dtsi" >> +#include "pm8550b.dtsi" >> +#include "pm8550ve.dtsi" >> +#include "pm8550vs.dtsi" >> +#include "pmk8550.dtsi" >> +#include "pmr735d_a.dtsi" >> +#include "pmr735d_b.dtsi" >> + >> +/ { >> +    model = "Qualcomm Technologies, Inc. SM8550 AIM300"; >> +    compatible = "qcom,sm8550-aim300", "qcom,sm8550"; >> + >> +    aliases { >> +        serial0 = &uart7; >> +    }; >> + >> +    chosen { >> +        stdout-path = "serial0:115200n8"; >> +    }; >> + >> +    pmic-glink { >> +        compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink"; >> +        #address-cells = <1>; >> +        #size-cells = <0>; >> +        orientation-gpios = <&tlmm 11 GPIO_ACTIVE_HIGH>; >> + >> +        connector@0 { >> +            compatible = "usb-c-connector"; >> +            reg = <0>; >> +            power-role = "dual"; >> +            data-role = "dual"; >> + >> +            ports { >> +                #address-cells = <1>; >> +                #size-cells = <0>; >> + >> +                port@0 { >> +                    reg = <0>; >> + >> +                    pmic_glink_hs_in: endpoint { >> +                        remote-endpoint = <&usb_1_dwc3_hs>; >> +                    }; >> +                }; >> + >> +                port@1 { >> +                    reg = <1>; >> + >> +                    pmic_glink_ss_in: endpoint { >> +                        remote-endpoint = <&usb_1_dwc3_ss>; >> +                    }; >> +                }; >> +            }; >> +        }; >> +    }; >> + >> +    vph_pwr: vph-pwr-regulator { > > It's not demanded, I think, but I'd suggest 'regulator-vph-pwr' to allow > all regulators to be grouped together. Thanks this comments, I will sync your comments with internal team, then I will update sync result to you. > >> +        compatible = "regulator-fixed"; >> +        regulator-name = "vph_pwr"; >> +        regulator-min-microvolt = <3700000>; >> +        regulator-max-microvolt = <3700000>; >> + >> +        regulator-always-on; >> +        regulator-boot-on; >> +    }; >> +}; > > Other than that looks good to me. > -- Thx and BRs, Tengfei Fan