From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbbABKuX (ORCPT ); Fri, 2 Jan 2015 05:50:23 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35625 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751036AbbABKuT convert rfc822-to-8bit (ORCPT ); Fri, 2 Jan 2015 05:50:19 -0500 Subject: Re: [PATCH v7 2/4] fpga manager: add sysfs interface document Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: text/plain; charset=utf-8 From: Pantelis Antoniou In-Reply-To: <20150102051200.GI4873@amd> Date: Fri, 2 Jan 2015 12:50:10 +0200 Cc: atull , Greg Kroah-Hartman , jgunthorpe@obsidianresearch.com, hpa@zytor.com, Michal Simek , Michal Simek , rdunlap@infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, grant.likely@linaro.org, iws@ovro.caltech.edu, linux-doc@vger.kernel.org, broonie@kernel.org, philip@balister.org, rubini@gnudd.com, s.trumtrar@pengutronix.de, jason@lakedaemon.net, kyle.teske@ni.com, nico@linaro.org, balbi@ti.com, m.chehab@samsung.com, davidb@codeaurora.org, rob@landley.net, davem@davemloft.net, cesarb@cesarb.net, sameo@linux.intel.com, akpm@linux-foundation.org, linus.walleij@linaro.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devel@driverdev.osuosl.org, delicious.quinoa@gmail.com, dinguyen@opensource.altera.com, yvanderv@opensource.altera.com Content-Transfer-Encoding: 8BIT Message-Id: <20FF5ACF-DA9F-4FBA-AA87-490A73D02A2E@konsulko.com> References: <1419007551-10040-1-git-send-email-atull@opensource.altera.com> <1419007551-10040-3-git-send-email-atull@opensource.altera.com> <20150102051200.GI4873@amd> To: Pavel Machek X-Mailer: Apple Mail (2.1993) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, > On Jan 2, 2015, at 07:12 , Pavel Machek wrote: > > >> +What: /sys/class/fpga_manager//firmware >> +Date: October 2014 >> +KernelVersion: 3.18 >> +Contact: Alan Tull >> +Description: Name of the FPGA image file to load using firmware class. > > This is wrong interface, right? The only use of this string is to pass > it to udev. We should simply pass "fpga-0" as a firware name, and let > udev figure it out, no need to to prepare name in separate component, > then pass it to kernel, which passes it back to udev. > No. No dependencies on udev please. This should hook directly to the firmware loader interface which does not rely on userspace at all. >> +What: /sys/class/fpga_manager//reset >> +Date: October 2014 >> +KernelVersion: 3.18 >> +Contact: Alan Tull >> +Description: Write 1 to reset the FPGA > > Does 0 need to be written there to pull the fpga out of reset? Is this > a suitable interface? > > Pavel > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html Regards — Pantelis