From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3979E1EE7C6 for ; Wed, 29 Jul 2026 21:00:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785358838; cv=none; b=Xy9t229gVqY0ru9CC9jhd+lJjCli9Zd+XTklyECu03UX1hRkfjFbF2KdYIXq0ZSDBZHNrYA3Ph4c3nUUkqc+0aK/IT9x8dJzNjFQmnba+7i8AAVcJdiWgNL+3iq3Yr2ptlOLPFY60oNh1lx7L7L3KSqpZ1xcD1LxwzG5+HSo9JM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785358838; c=relaxed/simple; bh=QvumVUf0NKLlj/MvzqdvQvP1razEAsjMmXjAj7XnD6E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ORgFrmkeXIOLnjn/X8cQUDnBPfb/G7p9tvbxzmLcr+mjjVFu1zeR075c3tkGUbJp13ykRpeHEFamyCHeb/NW7pC1tqWfpxoCGOi1xwtC/U9ULuovEf+UhZcyWE4RyaYjbmkoIR+G1eqFQ4zPN2aSwQ0K11NtnYwwgBqYvsy3t2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XAUsPHGE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kfk2ne3W; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XAUsPHGE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kfk2ne3W" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TKJ1qi2782322 for ; Wed, 29 Jul 2026 21:00:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SXSfyuVk7nhwcBFF7oOD5gqIy16PcYgsT0nnHNUvLMM=; b=XAUsPHGErG+uIyOh Qppnx6ZlEq26SqFbuOa7mJ4MyQ35FbpgJojUedz/7pgsxAlb9UWoVDeiOQAYcgAa XRtJTN91d/p6vfbZNkkT2YKdWIVPoiW34SG5c9s2bY1YhoFejUXxnCEpxnYnDo4L zVoUt3T+whGnWYMrD7y6nHQEYxeMAI2/7zSRpk4BxN9O0o2xFdUAtOtJi634menl gK1ixuKd8u8sUg76GqsDtgRnQ5gPtLA7TtTyPG/CL7hLWHUzNDUQt/jspktM3ZiV yjiuEA9f4fwHGRKvr4aJoLKFOIWlbpsPAVH7PKFC9KUPXzYCT4PlWVDrrQccVWOw zNVobg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqresr4cg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 21:00:24 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cc5faecf01so29210555ad.1 for ; Wed, 29 Jul 2026 13:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785358719; x=1785963519; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SXSfyuVk7nhwcBFF7oOD5gqIy16PcYgsT0nnHNUvLMM=; b=kfk2ne3Wgvirds6bqUw/iowfmuV8XhPSJCdwhkKD9GYurF90/NG92pmaYX3O6ZNUEX mijGTnQQwG3rqbqu1kg0ycY1kY1F8+KD8vGTzkPoUu+Plfwx//nYvCjfe/je+xJUEYl7 aYJ7gyXltrOlzhPpXBwPKutWdTK8FoE/IBhk3QnnnEN9qbgmAka4xLZjGCALdyZvwLrx tFx+I+L8RAUsDZR/9lQUAREGX2zMiG/rBRbB8P0/v7fALXv4h3TzhDwVBa8tfyPbHXJj p/VFL3yL9zEONmB3OukGpbSgRdp5p5hGxjz+9hfEV3zNEcjlYwl+XavY2pRQiNXFoC0G RxcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785358719; x=1785963519; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SXSfyuVk7nhwcBFF7oOD5gqIy16PcYgsT0nnHNUvLMM=; b=TJr7YgHazkmz+CX97+mdHUYDEvpjv09WOquE0pOYah6GeF2hmaKNNKsOfBz+WAll8q vmHV7H6XfPl8GIUfsXnNiwl1JDPellxNqJXV85scH68NQz9/GeCs2k8XHxVnh4Q8LZwd GwWFSBgJSKk1D2H+Rq33meusVcYC7FmYi7gO+n/q4HxfbWaJWoggeKxERxYcK8yM/QkL I2N+iv9qDrn95z2AqFImxCJ0/VLKKa62mCpMMWrnBiXtXAOW/Tjixbm6vLZFDGKbk2p3 QcbCXyc5RDBwqhrvsias2I8cgmj5GpOFJIB6ZgA2PME/BZ0Lg4Rs27sGCX26wj88V1QD nXtQ== X-Forwarded-Encrypted: i=1; AHgh+RpoeUPlcKn88JvJZ2YTqrz8iW494zqXdf3dVUpc/uer7jiWTybRE7FGZZP6bBkqvepeqoXrX2totHuwQcc=@vger.kernel.org X-Gm-Message-State: AOJu0YwinVyfhRBOn7CveVm2IaR2iiMhz3u62FhPOUqC4vgmm03bTF4y Q+7AdzKRi3gae5TjClStZOW2z3hL41zWoyi9MOqXvPVF7+HN6rYMZm3BkbjtgHNbvDgpRfk2eoP fX2leRVtbN3BVFRtGYXReIJWeV2DXWJ3Kug9/I4py7bxOFVbczSYKJBwWUkMCmMoCz6Q= X-Gm-Gg: AR+sD111JXnromf0VMj1/wcSgKe722topchXoHbtu33nNmf4WhbPXnR5seGt95SNF9p ri17x15bjE39so2HGbbT4+0MmsreRcKVbYehiRi00fvn0aHjMQQnQLt5StnXwHtZUaqNqhP0PvM T5ZNxtQ+bpNs+VAIgMLbKBYlQ+QYBQKc+QY8n4h6me5k4qggRFrSoIryRpk1yIWncZe/q9o63fm eTdxECcr9vO7IcJXE+1FqIUjBErBW0BOY0IkgAT5V1e9v4auuzXNoVPsETyqErO564kI0MdU5xB grw2cx3eAqp2wZ3BnMIJu/eHw3ECH1DfoxUBwH6iPZ8qwJsHCzd8N1xqFBOWbR3Po21S+xz0wr0 yIeqrApHLUOugvfXFoKeokrGv5LshZqN4eNxdGHWdO2thvqQVw03rGA== X-Received: by 2002:a05:6a21:1fc3:b0:3aa:c964:3c27 with SMTP id adf61e73a8af0-3c8ba5b7f3fmr8831058637.46.1785358718812; Wed, 29 Jul 2026 13:58:38 -0700 (PDT) X-Received: by 2002:a05:6a21:1fc3:b0:3aa:c964:3c27 with SMTP id adf61e73a8af0-3c8ba5b7f3fmr8831033637.46.1785358718423; Wed, 29 Jul 2026 13:58:38 -0700 (PDT) Received: from [10.226.59.182] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e72643a12sm19719815c88.5.2026.07.29.13.58.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 13:58:38 -0700 (PDT) Message-ID: <20a19c5e-6f1b-4549-8a72-a8a99126f73e@oss.qualcomm.com> Date: Wed, 29 Jul 2026 14:58:36 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] accel/qaic: use sizeof(*trans_hdr) for transaction length check To: Muhammad Bilal Cc: carl.vanderlip@oss.qualcomm.com, ogabbay@kernel.org, dan.carpenter@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260617212520.59801-1-meatuni001@gmail.com> Content-Language: en-US From: Jeff Hugo In-Reply-To: <20260617212520.59801-1-meatuni001@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=BqOtB4X5 c=1 sm=1 tr=0 ts=6a6a69e9 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=pGLkceISAAAA:8 a=GD8_rapH8p4utXL01xcA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDE1OCBTYWx0ZWRfX0Y/pqCj6t/bl 1I4rjMOMYd4IHSFvNa3CgAo9utPhSptl9bHYB+II+TDm08upiF2I9Usiq/v2yBLh/OBq47dzUjy Bm2u52CxxSr6JSGTsn2RDr8uDEwnAXE= X-Proofpoint-ORIG-GUID: UAH4gg0QZz6wyXQ0KFWi_2PDnjQW-Slx X-Proofpoint-GUID: UAH4gg0QZz6wyXQ0KFWi_2PDnjQW-Slx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDE1OCBTYWx0ZWRfXyz0IAjuSSy7w nTmyfzARD4QApYEE+GnsLhZhIHLFQ0zKeSiJrq0i4UUja2vkIJxsMfOyy1WV4fNue6sZ+xJ2KRv oy/cZPhkKLSRsdClbaGpPJ3hxTgWSrSGAcC1reAPfOd3HoHeZZi830bzIkIt2To1OEw6w8E//fn xfTKmwqPXTMANuBVUmzaQ+zfIjWGmIRvS0mIXAMghAiTwk0Zsz/E+XOzsi2K9nF8leWnmzzcmz/ 203wM5VMQMTQFrxoD9T9ac7mWNV1smJ8ZMFRKl3nV44bd445Z9koJFnMcI8aHkAJdynrX0NGTeW lWTcmLEzbqkezwVA5yVWFaL3x+S23IJLuIrO6aTK/7vUkJ0SpUwTO1hNsZxyFWoy0oGBBrNtr0x pCLJxhLN0mt4iEu+y6WJ/PPuNxanKnFNnZF44siUEv4sKkN5c/AODs7rzL4yjFzTXFblprwCMF8 zUJfIlNf5DrXh4UIaJg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_07,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290158 On 6/17/2026 3:25 PM, Muhammad Bilal wrote: > In encode_message() the per-transaction lower-bound check compares > trans_hdr->len against sizeof(trans_hdr), i.e. the size of the pointer, > instead of sizeof(*trans_hdr), the size of struct qaic_manage_trans_hdr. > > Every other length check in this file (encode_message() at the loop > guard, decode_message(), etc.) correctly uses sizeof(*trans_hdr), so > this is an inconsistency. On 64-bit builds the pointer and the struct > are both 8 bytes, so the check is correct by coincidence and there is > no behavioural change. On 32-bit builds the pointer is 4 bytes, which > weakens the minimum-length check below the 8-byte header size. > > Use sizeof(*trans_hdr) so the check validates against the actual > transaction header size on all builds. > > Fixes: ea33cb6fc278 ("accel/qaic: tighten bounds checking in encode_message()") > Signed-off-by: Muhammad Bilal Applied to drm-misc-fixes -Jeff