From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through
Date: Sat, 4 Aug 2018 21:01:46 -0500 [thread overview]
Message-ID: <20a2e89f-1715-9659-f65f-5ace0b2073fb@embeddedor.com> (raw)
In-Reply-To: <20180722221717.fgx6nzljnfrw3d5a@earth.universe>
Hi Sebastian,
On 07/22/2018 05:17 PM, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote:
>> On 17 July 2018 at 23:47, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
>>> It seems that a *break* is missing in order to avoid a fall-through.
>>> Otherwise, the calculation of *data* makes no sense.
>>>
>>> Addresses-Coverity-ID: 1271172 ("Missing break in switch")
>>> Fixes: 87c2d9067893 ("power: max77693: Add charger driver for Maxim 77693")
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>> ---
>>> drivers/power/supply/max77693_charger.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Thanks, queued to power-supply's fixes branch.
>
I think this should be tagged for stable.
Thanks
--
Gustavo
prev parent reply other threads:[~2018-08-05 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 21:47 Gustavo A. R. Silva
2018-07-18 6:14 ` Krzysztof Kozlowski
2018-07-19 13:54 ` Gustavo A. R. Silva
2018-07-22 22:17 ` Sebastian Reichel
2018-08-05 2:01 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20a2e89f-1715-9659-f65f-5ace0b2073fb@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=b.zolnierkie@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®