From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00755C433EF for ; Tue, 5 Jul 2022 03:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233864AbiGEDso (ORCPT ); Mon, 4 Jul 2022 23:48:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbiGEDsm (ORCPT ); Mon, 4 Jul 2022 23:48:42 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ACB02BE5; Mon, 4 Jul 2022 20:48:40 -0700 (PDT) X-UUID: bcc7d7e370f349a9af44f17cd9bf2b93-20220705 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:66dbdefe-f985-4aec-a552-dd4ee86892a9,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACT ION:release,TS:-5 X-CID-META: VersionHash:0f94e32,CLOUDID:9bc68d86-57f0-47ca-ba27-fe8c57fbf305,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: bcc7d7e370f349a9af44f17cd9bf2b93-20220705 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 413294378; Tue, 05 Jul 2022 11:48:33 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 5 Jul 2022 11:48:31 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Tue, 5 Jul 2022 11:48:31 +0800 Message-ID: <20a5ac6a0e089a11f82f2d6eaa303a775b11e3a3.camel@mediatek.com> Subject: Re: [PATCH v15 04/16] drm/mediatek: dpi: Remove output format of YUV From: CK Hu To: Bo-Chen Chen , , , , , , , CC: , , , , , , , , , , , , Date: Tue, 5 Jul 2022 11:48:31 +0800 In-Reply-To: <20220701035845.16458-5-rex-bc.chen@mediatek.com> References: <20220701035845.16458-1-rex-bc.chen@mediatek.com> <20220701035845.16458-5-rex-bc.chen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Bo-Chen: On Fri, 2022-07-01 at 11:58 +0800, Bo-Chen Chen wrote: > DPI is not support output format as YUV, but there is the setting of > configuring output YUV. Therefore, remove them in this patch. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, CK > > Fixes: 9e629c17aa8d ("drm/mediatek: Add DPI sub driver") > Signed-off-by: Bo-Chen Chen > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 31 ++++++-------------------- > ---- > 1 file changed, 6 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index f66a121ba0c9..3473ee18ad97 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -54,13 +54,7 @@ enum mtk_dpi_out_channel_swap { > }; > > enum mtk_dpi_out_color_format { > - MTK_DPI_COLOR_FORMAT_RGB, > - MTK_DPI_COLOR_FORMAT_RGB_FULL, > - MTK_DPI_COLOR_FORMAT_YCBCR_444, > - MTK_DPI_COLOR_FORMAT_YCBCR_422, > - MTK_DPI_COLOR_FORMAT_XV_YCC, > - MTK_DPI_COLOR_FORMAT_YCBCR_444_FULL, > - MTK_DPI_COLOR_FORMAT_YCBCR_422_FULL > + MTK_DPI_COLOR_FORMAT_RGB > }; > > struct mtk_dpi { > @@ -373,24 +367,11 @@ static void mtk_dpi_config_disable_edge(struct > mtk_dpi *dpi) > static void mtk_dpi_config_color_format(struct mtk_dpi *dpi, > enum mtk_dpi_out_color_format > format) > { > - if ((format == MTK_DPI_COLOR_FORMAT_YCBCR_444) || > - (format == MTK_DPI_COLOR_FORMAT_YCBCR_444_FULL)) { > - mtk_dpi_config_yuv422_enable(dpi, false); > - mtk_dpi_config_csc_enable(dpi, true); > - mtk_dpi_config_swap_input(dpi, false); > - mtk_dpi_config_channel_swap(dpi, > MTK_DPI_OUT_CHANNEL_SWAP_BGR); > - } else if ((format == MTK_DPI_COLOR_FORMAT_YCBCR_422) || > - (format == MTK_DPI_COLOR_FORMAT_YCBCR_422_FULL)) { > - mtk_dpi_config_yuv422_enable(dpi, true); > - mtk_dpi_config_csc_enable(dpi, true); > - mtk_dpi_config_swap_input(dpi, true); > - mtk_dpi_config_channel_swap(dpi, > MTK_DPI_OUT_CHANNEL_SWAP_RGB); > - } else { > - mtk_dpi_config_yuv422_enable(dpi, false); > - mtk_dpi_config_csc_enable(dpi, false); > - mtk_dpi_config_swap_input(dpi, false); > - mtk_dpi_config_channel_swap(dpi, > MTK_DPI_OUT_CHANNEL_SWAP_RGB); > - } > + /* only support RGB888 */ > + mtk_dpi_config_yuv422_enable(dpi, false); > + mtk_dpi_config_csc_enable(dpi, false); > + mtk_dpi_config_swap_input(dpi, false); > + mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_RGB); > } > > static void mtk_dpi_dual_edge(struct mtk_dpi *dpi)