From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B08FC433F5 for ; Wed, 30 Mar 2022 08:10:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244147AbiC3IMY (ORCPT ); Wed, 30 Mar 2022 04:12:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233372AbiC3IMV (ORCPT ); Wed, 30 Mar 2022 04:12:21 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 894B71C5 for ; Wed, 30 Mar 2022 01:10:35 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id p15so39844649ejc.7 for ; Wed, 30 Mar 2022 01:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2Bx33AfU/HrMdmUVrutEhCI4XtzN6zsWPn96wMBqWfQ=; b=tB9ZV4xNkTjWB+JfChV1RXPd3jTDRvTlqgUVZYBP73R087rphFaYQlaPGbG10bTd8R pIKQ6ekTnt11peeMgweBaV6uj4ndWFbf3VcF/DGmbU5F2D/yOES7wCXZSPPwwCFD5xsb fCgioai7oet8z9ESFfxsTNgmSyNvezi0kmrxk1ygD6fHzUwhh4fj9ZC/l/7SUKlSu0bH F8rOagD4youDcBgNXFC23Iqu4mLEld97nRv1ev2JFw0htFR0QzgyGSbsmbYOWhyeV2F0 F/kpEbXStSTMndFlA0o7wctslBAJLaldhLL9AU6MxBflZum8YWO/WNhG0+IUoCJo2RNJ UJxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2Bx33AfU/HrMdmUVrutEhCI4XtzN6zsWPn96wMBqWfQ=; b=jRLeW5P2O+gOUTfFYIXJSo5lo38eEXEdsopjfv2oeVxkA7bsoE0+rFH+4s2EeA4yhv 0ueBQ47iVma1XINKue6QE899UABEf32KuselJU0zg4AEB/pm2eKbvHLLVG2P45+Sp3we E7IbKRtY8Tp0NSEpu5NgT3tqcxCDGyqy0pdaCZlYfCMVVPGVQPke+k+YtXIbnUJ3U/Lj qP6BbyFYZxoOE3qy1QZdFpSEEqql9zFNP2AI5x8SYZpBlqhPUWcK4beMbofHT9ExKJ4O 2JbjqnDl13broS9wCT9IbVNzIcW8euxS2ssUBVMg+hOwaROk5E9c6wrwhVA9dKlK8Ewe s9+w== X-Gm-Message-State: AOAM5336acnfbG/tjAEypO3Lc3KH7VoLLroGHPW1QRsZWOaes7gttQMU p90/7Q2vrMGn9YDFMDmdNAyExw== X-Google-Smtp-Source: ABdhPJyr3a3ngbzY3rpCE8sm/h/E4CpGMIzRZRj13oMVUUOM4QcQjBwxtlOdEeguU+Me2VirmtUfNA== X-Received: by 2002:a17:907:86a3:b0:6da:870c:af44 with SMTP id qa35-20020a17090786a300b006da870caf44mr38389614ejc.445.1648627834085; Wed, 30 Mar 2022 01:10:34 -0700 (PDT) Received: from [192.168.0.162] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id b17-20020aa7dc11000000b00412ae7fda95sm1129147edu.44.2022.03.30.01.10.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 01:10:33 -0700 (PDT) Message-ID: <20a7dc75-93d9-dcb1-9f2a-b962a1f84d31@linaro.org> Date: Wed, 30 Mar 2022 10:10:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 4/5] dt-bindings: phy: uniphier-usb3hs: Fix incorrect clock-names and reset-names Content-Language: en-US To: Kunihiko Hayashi , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski Cc: Masami Hiramatsu , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1648617651-9004-1-git-send-email-hayashi.kunihiko@socionext.com> <1648617651-9004-5-git-send-email-hayashi.kunihiko@socionext.com> From: Krzysztof Kozlowski In-Reply-To: <1648617651-9004-5-git-send-email-hayashi.kunihiko@socionext.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/03/2022 07:20, Kunihiko Hayashi wrote: > There is no clock-names and reset-names for Pro5 SoC, that should have two > properties, "gio" and "link" like usb3-ssphy. > > And according to the existing PXs2 devicetree, the clock-names for PXs2 SoC > should have "link" and "phy", and minItems of clocks should be 2. > > Fixes: 134ab2845acb ("dt-bindings: phy: Convert UniPhier USB3-PHY conroller to json-schema") > Signed-off-by: Kunihiko Hayashi > --- > .../phy/socionext,uniphier-usb3hs-phy.yaml | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml > index 33946efcac5e..1bbd164f2527 100644 > --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml > @@ -31,12 +31,14 @@ properties: > const: 0 > > clocks: > - minItems: 1 > + minItems: 2 > maxItems: 3 > > clock-names: > oneOf: > - - const: link # for PXs2 > + - items: # for Pro5 > + - const: gio > + - const: link > - items: # for PXs3 with phy-ext Similarly to our other discussion, it would be good to convert it to allOf:if:then: constraining it per compatible. The change itself is ok: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof