From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 05/11] staging: rtl8192e: Remove unused variables numqry_..
Date: Wed, 25 Jan 2023 21:08:53 +0100 [thread overview]
Message-ID: <20aedc3bd3cc860ee8d86d205461f479ac201fea.1674675808.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1674675808.git.philipp.g.hortmann@gmail.com>
numqry_phystatus, numqry_phystatusCCK and numqry_phystatusHT are
initialized and increased but never read. Remove dead code.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ----
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 ---
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index b4651cea07a1..f62547e54261 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1308,8 +1308,6 @@ static void _rtl92e_query_rxphystatus(
static u8 check_reg824;
static u32 reg824_bit9;
- priv->stats.numqry_phystatus++;
-
is_cck_rate = rx_hal_is_cck_rate(pdrvinfo);
memset(precord_stats, 0, sizeof(struct rtllib_rx_stats));
pstats->bPacketMatchBSSID = precord_stats->bPacketMatchBSSID =
@@ -1341,7 +1339,6 @@ static void _rtl92e_query_rxphystatus(
if (is_cck_rate) {
u8 report;
- priv->stats.numqry_phystatusCCK++;
if (!reg824_bit9) {
report = pcck_buf->cck_agc_rpt & 0xc0;
report >>= 6;
@@ -1416,7 +1413,6 @@ static void _rtl92e_query_rxphystatus(
precord_stats->RxMIMOSignalQuality[1] = -1;
}
} else {
- priv->stats.numqry_phystatusHT++;
for (i = RF90_PATH_A; i < RF90_PATH_MAX; i++) {
if (priv->brfpath_rxenable[i])
rf_rx_num++;
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
index 70767238e721..e38de4d8a467 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
@@ -185,9 +185,6 @@ enum reset_type {
struct rt_stats {
unsigned long received_rate_histogram[4][32];
unsigned long num_process_phyinfo;
- unsigned long numqry_phystatus;
- unsigned long numqry_phystatusCCK;
- unsigned long numqry_phystatusHT;
unsigned long received_bwtype[5];
unsigned long rxoverflow;
unsigned long rxint;
--
2.39.1
next prev parent reply other threads:[~2023-01-25 20:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 20:08 [PATCH v2 00/11] staging: rtl8192e: Remove unused variables from struct rt_stats Philipp Hortmann
2023-01-25 20:08 ` [PATCH v2 01/11] staging: rtl8192e: Remove unused variables rxrdu and rxok Philipp Hortmann
2023-01-25 20:08 ` [PATCH v2 02/11] staging: rtl8192e: Remove unused variables rxdatacrcerr and rxmgmtcrcerr Philipp Hortmann
2023-01-25 20:08 ` [PATCH v2 03/11] staging: rtl8192e: Remove unused variables rxcrcerrmin and friends Philipp Hortmann
2023-01-25 20:08 ` [PATCH v2 04/11] staging: rtl8192e: Remove unused variables numpacket.. and received_pre Philipp Hortmann
2023-01-25 20:08 ` Philipp Hortmann [this message]
2023-01-25 20:08 ` [PATCH v2 06/11] staging: rtl8192e: Remove unused variables num_proc.., recei.. and rxov Philipp Hortmann
2023-01-25 20:09 ` [PATCH v2 07/11] staging: rtl8192e: Remove unused variables rxint, ints and shints Philipp Hortmann
2023-01-25 20:09 ` [PATCH v2 08/11] staging: rtl8192e: Remove unused variables txov.., txbeokint and txbkokint Philipp Hortmann
2023-01-25 20:09 ` [PATCH v2 09/11] staging: rtl8192e: Remove unused variables txviok.., txvook.. and txbea Philipp Hortmann
2023-01-25 20:09 ` [PATCH v2 10/11] staging: rtl8192e: Remove unused variables txbeac.., txman.. and txcmdp Philipp Hortmann
2023-01-25 20:09 ` [PATCH v2 11/11] staging: rtl8192e: Remove unused variables txbytes.., txbyt.. and signa Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20aedc3bd3cc860ee8d86d205461f479ac201fea.1674675808.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®