From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457F3C43381 for ; Mon, 11 Mar 2019 14:18:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FA512075C for ; Mon, 11 Mar 2019 14:18:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="zLnaVKr1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727790AbfCKOSg (ORCPT ); Mon, 11 Mar 2019 10:18:36 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39780 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727762AbfCKOSe (ORCPT ); Mon, 11 Mar 2019 10:18:34 -0400 Received: by mail-lj1-f195.google.com with SMTP id g80so4213435ljg.6 for ; Mon, 11 Mar 2019 07:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=weLVDWMXOiIBSGNex18C86cJB6n0z/TV7g9lXzrJcfs=; b=zLnaVKr1CmbhbaV8RBh+83dqUrMNhdBKVv1P+dH0d+8prIdV+veyBLToYFdFgqpbrB YOC0rm71kxJl18ihAOLQ5k3ippovefF9wV5G8oJ+qPoUX6Dtwaw3TkYu53LH8dNSJvlu in+MI+cZ+Wxh8R739Ic8YB852DjlUHPE1IVH9F3JcaM7BaLF5XUWRhxfCtMT2MX4toFQ XBe55M7zyk81sEZKjthCjEiPRRNhU0ekATNgSJgbrXtgEkmNUHA9ynIGyjtlryZpvYkN jUNbiVjJxb4Pj2gRy9acZGQQMq2ZWgrFcTlWdh2d8lFATgQWgd70RuLi3JSOw+x/hnty ympg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=weLVDWMXOiIBSGNex18C86cJB6n0z/TV7g9lXzrJcfs=; b=cEOZw34k234pr6GZGuJVH8V52036zG9JdNMuIdUapeE/djOVBG7ENbEvIMih881NRG Cj1TKY473NY484iLc0j7U5/V2E+H4a8ixeYMxgTio5wmi/nNeKhnGCJ4H9wYC6cv+WRd KabHttM1F+PcoULbjYzguXyX5HtmDsLjUPo9wdd3U8Z3NWTro32UIudY4hmMlm9yGntY cXkBcHrGrpuFucn3OwNKB5/bmFDEloEuoKbmyjtR+CygmQhPTNluLagS4obHQBjqBQ8s ykbHAtqLp1TwnCfvHf0uUCyZzX4f8mFQ/3rGSi97YvYhHk0i5d1EBdlzAYlTkMoPeYjD Ld+Q== X-Gm-Message-State: APjAAAV+YraL7r878u2OZvpNruYKTYEiGJMpLwYND987piJkfkdaVN9L vvboJ/YhGmFyzBIeEIM7K4d67ndGDHo= X-Google-Smtp-Source: APXvYqzYShqHW8zGFuMsZzaeV76v8hZczrJUfe1RFNLFATmH8v3cFo3CbnNJ0SRdsfVupI031MRdxA== X-Received: by 2002:a2e:5d88:: with SMTP id v8mr16627997lje.150.1552313912187; Mon, 11 Mar 2019 07:18:32 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.87.168]) by smtp.gmail.com with ESMTPSA id n13sm1112049lfb.89.2019.03.11.07.18.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 07:18:31 -0700 (PDT) Subject: Re: [PATCH v2] net: renesas: fix a missing check of of_get_phy_mode To: Geert Uytterhoeven , Kangjie Lu Cc: pakki001@umn.edu, "David S. Miller" , Vladimir Zapolskiy , Geert Uytterhoeven , Simon Horman , Chris Brandt , netdev , Linux-Renesas , Linux Kernel Mailing List References: <20190311074939.517-1-kjlu@umn.edu> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <20b2afad-4983-3d97-2440-9745352342da@cogentembedded.com> Date: Mon, 11 Mar 2019 17:18:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2019 01:59 PM, Geert Uytterhoeven wrote: >> of_get_phy_mode may fail and return a negative error code; >> the fix checks the return value of of_get_phy_mode and >> returns NULL of it fails. >> >> Signed-off-by: Kangjie Lu > >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> @@ -3187,6 +3187,8 @@ static struct sh_eth_plat_data *sh_eth_parse_dt(struct device *dev) >> return NULL; >> >> pdata->phy_interface = of_get_phy_mode(np); >> + if (pdata->phy_interface < 0) >> + return NULL; > > sh_eth_plat_data.phy_interface has type phy_interface_t. > This is an enum containing only positive values, hence it is unsigned. > So the condition can never be true. Good catch, thank you! My gcc doesn't warn but doesn't generate the code for the branch either... [...] > Gr{oetje,eeting}s, > > Geert MBR, Sergei