From: Andrew Lunn <andrew@lunn.ch>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Yang Li <yang.lee@linux.alibaba.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] leds: trigger: netdev: add additional mode for unified tx/rx traffic
Date: Fri, 9 Jun 2023 16:36:48 +0200 [thread overview]
Message-ID: <20b33e91-1058-4ddd-9502-9b2018594e96@lunn.ch> (raw)
In-Reply-To: <20230609135103.14221-4-ansuelsmth@gmail.com>
On Fri, Jun 09, 2023 at 03:51:03PM +0200, Christian Marangi wrote:
> Add additional mode for unified tx/rx traffic. LED will blink on both tx
> or rx traffic.
>
> This is especially useful for PHY and Switch that supports LEDs hw
> control that doesn't support split tx/rx traffic but supports blinking
> on any kind of traffic in the link.
>
> On mode set from sysfs we check if we have enabled split tx/rx mode and
> reject enabling activity mode to prevent wrong and redundant
> configuration.
TRIGGER_NETDEV_TX + TRIGGER_NETDEV_RX = TRIGGER_NETDEV_ACTIVITY:
When calling into the driver, it probably makes the drivers simpler if
you do this simplification. Within the trigger code, keep them
separate, because that is what the user has configured.
I know such a simplification will make the marvell PHY driver simpler.
Andrew
prev parent reply other threads:[~2023-06-09 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 13:51 [PATCH 0/3] leds: trigger: netdev: add additional modes Christian Marangi
2023-06-09 13:51 ` [PATCH 1/3] leds: trigger: netdev: add additional specific link speed mode Christian Marangi
2023-06-09 14:25 ` Andrew Lunn
2023-06-09 13:51 ` [PATCH 2/3] leds: trigger: netdev: add additional specific link duplex mode Christian Marangi
2023-06-09 13:51 ` [PATCH 3/3] leds: trigger: netdev: add additional mode for unified tx/rx traffic Christian Marangi
2023-06-09 14:36 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20b33e91-1058-4ddd-9502-9b2018594e96@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®