From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752776AbdK0PN7 (ORCPT ); Mon, 27 Nov 2017 10:13:59 -0500 Received: from esa6.dell-outbound.iphmx.com ([68.232.149.229]:20476 "EHLO esa6.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434AbdK0PN5 (ORCPT ); Mon, 27 Nov 2017 10:13:57 -0500 IronPort-PHdr: =?us-ascii?q?9a23=3AyCKLdRXsQB7XamRUfR96vmV0XWLV8LGtZVwlr6E/?= =?us-ascii?q?grcLSJyIuqrYbRKFt8tkgFKBZ4jH8fUM07OQ6PGwHzRYqb+681k6OKRWUBEEjc?= =?us-ascii?q?hE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAAjwOhRo?= =?us-ascii?q?LerpBIHSk9631+ev8JHPfglEnjSwbLdxIRmssQndqtQdjJd/JKo21hbHuGZDdf?= =?us-ascii?q?5MxWNvK1KTnhL86dm18ZV+7SleuO8v+tBZX6nicKs2UbJXDDI9M2Ao/8LrrgXM?= =?us-ascii?q?TRGO5nQHTGoblAdDDhXf4xH7WpfxtTb6tvZ41SKHM8D6Uaw4VDK/5KptVRTmij?= =?us-ascii?q?oINyQh/W/XlMJ+kb5brhyiqRxxwYHUYZ2aOvVxca7GYdMVXmhBUtpNWyBdAI6x?= =?us-ascii?q?aZYEAeobPeZfqonwv1wDoxykCgm2BePvzSVEiHn33a0/1OQhFx3J3A0+ENIKtH?= =?us-ascii?q?TUq874O7oMXuCxyKnE1ynMb/RT2Trk7oXDbxMvoemUUL9xcsfd01cjGg3bglmK?= =?us-ascii?q?tIDoPzyY2v4JvmWY9+ZsSP6jh3Q6pwx+rDWj3Nogh4rTio8Wy13I7Th1zYk7KN?= =?us-ascii?q?GiVUJ2YN+pHIFTuiyaLYd6X8MvTmButS0n0LMJo4S7czIPyJk/wh7fbOGIfJaQ?= =?us-ascii?q?7xL4UeaRPS94hHV4eLKjnxqy8Vavyun7VsSszllKtTBKn9bWun8QyRPT7syHRu?= =?us-ascii?q?J6/ke8xTaAzAfT6vxCIU8pi6bXMZ8hwqYwlpoWvkXPBDP5mELzjKOOd0Uk/Pan?= =?us-ascii?q?6/j/b7jnpZKQLZF4hw/gPqg0h8CyAes1PhIKUmWY4ei80afs/Uz9QLVElP02la?= =?us-ascii?q?zZvYjdK8sBvK65AghV3pwl5Ra+Cjem19IYkmUGLF1bfBKHi4/pNkrTL//mCfe/?= =?us-ascii?q?h06gnytsx/DDJrHhGInCLmDfkLf9erZw80pcyAs1zdBC6JNYE6wBIOnoVULqqt?= =?us-ascii?q?zYAQE2Mxauz+bkFtp9zIUeVnyLAqODN6PSq1CI7Po1I+aQfI8VpCr9K/896v7o?= =?us-ascii?q?k3A5hUIScre33ZYMdnC4EeppI1+DbXrvnNgBC2EKsRQ6TODwj12CSzFTbW6oX6?= =?us-ascii?q?0g/jE7FJ6mDYDbS4CpgbyB2jq7H5JPamBFFF+MC3HoeJuAW/oXdiKSLdFukiYe?= =?us-ascii?q?WbiiVYAhzxeuuxH+y7Z9KerU4CIY5trf040h5OTS0xE/8zMyAcmb3EmGRmdzmG?= =?us-ascii?q?IDTjtw16d69wg1nliZ3Kd7g9RcFNpO9/1OTwE2PILdyOo8DMr9DFHvZNCMHQKD?= =?us-ascii?q?S8+nBncVT9c2xdQPbkJ5HP2ugxTHmSGtBulGxPSwGJUo//eEjDDKLMFnxiOe2Q?= =?us-ascii?q?=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HEAAC1Khxah2Ka6ERSChkBAQEBAQEBA?= =?us-ascii?q?QEBAQEHAQEBAQGEEn4nB4N4mTWBfYIAln4KhTsCGoRTQxQBAQEBAQEBAQEBAhA?= =?us-ascii?q?BAQEKCwkIKC+COCKCRgEBAQECASMEDUUMBAIBCBEEAQEBAgIjAwICAkQBCAgCB?= =?us-ascii?q?AENBQiKEgimGoFtOop6AQEBAQEBAQMBAQEBAQEBAQEBAR2BD4IrggeDPoMrhHE?= =?us-ascii?q?yMQKCW4JDIAWiRpUDk1eWOoE6NoFzb06CKYJigXN3AYkSgRQBAQE?= X-IPAS-Result: =?us-ascii?q?A2HEAAC1Khxah2Ka6ERSChkBAQEBAQEBAQEBAQEHAQEBAQG?= =?us-ascii?q?EEn4nB4N4mTWBfYIAln4KhTsCGoRTQxQBAQEBAQEBAQEBAhABAQEKCwkIKC+CO?= =?us-ascii?q?CKCRgEBAQECASMEDUUMBAIBCBEEAQEBAgIjAwICAkQBCAgCBAENBQiKEgimGoF?= =?us-ascii?q?tOop6AQEBAQEBAQMBAQEBAQEBAQEBAR2BD4IrggeDPoMrhHEyMQKCW4JDIAWiR?= =?us-ascii?q?pUDk1eWOoE6NoFzb06CKYJigXN3AYkSgRQBAQE?= From: X-LoopCount0: from 10.166.132.152 X-IronPort-AV: E=Sophos;i="5.44,465,1505797200"; d="scan'208";a="179224885" X-DLP: DLP_GlobalPCIDSS To: , CC: , , , , Subject: RE: [PATCH] r8152: disable rx checksum offload on Dell TB dock Thread-Topic: [PATCH] r8152: disable rx checksum offload on Dell TB dock Thread-Index: AQHTZCXOoLMDLHu/wkW2RntQo+oZTqMh/h4AgAAPSoCAAAi1gIABMxwAgAUSsNA= Date: Mon, 27 Nov 2017 15:13:53 +0000 Message-ID: <20b73046763d48848bfbf152e518e0e4@ausx13mpc120.AMER.DELL.COM> References: <20171123063838.3058-1-kai.heng.feng@canonical.com> <20171123075858.GA31473@kroah.com> <20171123092450.GA26472@kroah.com> <128965DB-9C05-4FEA-9C78-CCE913E41032@canonical.com> In-Reply-To: <128965DB-9C05-4FEA-9C78-CCE913E41032@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vARFE5ER001497 > -----Original Message----- > From: Kai Heng Feng [mailto:kai.heng.feng@canonical.com] > Sent: Thursday, November 23, 2017 9:44 PM > To: Greg KH > Cc: David Miller ; hayeswang@realtek.co; linux- > usb@vger.kernel.org; netdev@vger.kernel.org; LKML kernel@vger.kernel.org>; Limonciello, Mario > Subject: Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock > > > > > On 23 Nov 2017, at 5:24 PM, Greg KH wrote: > > > > On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: > >> > >> What I want to do here is to finding this connection: > >> Realtek r8153 <-> SMSC hub (USD ID: 0424:5537) <-> > >> ASMedia XHCI controller (PCI ID: 1b21:1142). > >> > >> Is there a safer way to do this? > > > > Nope! You can't do that at all from within a USB driver, sorry. As you > > really should not care at all :) > > Got it :) > > The r8153 in Dell TB dock has version information, RTL_VER_05. > We can use it to check for workaround, but many working RTL_VER_05 devices > will also be affected. > Do you think it’s an acceptable compromise? > > >> I have a r8153 <-> USB 3.0 dongle which work just fine. I can’t find any > >> information to differentiate them. Hence I want to use the connection to > >> identify if r8153 is on a Dell TB dock. > > > > Are you sure there is nothing different in the version or release number > > of the device? 'lsusb -v' shows the exact same information for both > > devices? > > Yes. I attached `lsusb -v` for r8153 on Dell TB dock, on a RJ45 <-> USB 3.0 dongle, > and on a RJ45 <-> USB Type-C dongle. > > >> Yes. From what I know, ASMedia is working on it, but not sure how long it > >> will take. In the meantime, I’d like to workaround this issue for the users. > > > > Again, it's a host controller bug, it should be fixed there, don't try > > to paper over the real issue in different individual drivers. > > > > I think I've seen various patches on the linux-usb list for this > > controller already, have you tried them? > > Yes. These patches are all in mainline Linux now. > > >> Actually no. > >> I just plugged r8153 dongle into the same hub, surprisingly the issue > >> doesn’t happen in this scenario. > > > > Then something seems to be wrong with the device itself, as that would > > be the same exact electrical/logical path, right? > > I have no idea why externally plugged one doesn’t have this issue. > Maybe it’s related how it’s wired inside the Dell TB dock... > > Kai-Heng This is quite surprising to me too. The externally plugged in r8153 dongle, was it connected over type C port or over type A port? AFAIK Type C port is actually Alpine ridge pass through port. It is not connected to XHCI controller or USB hub.