From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
Zhangfei Gao <zhangfei.gao@oss.qualcomm.com>,
Bartosz Golaszewski <brgl@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 4/5] arm64: dts: qcom: nord-ride-embedded: Add sound support
Date: Mon, 2 Nov 2026 14:21:08 +0100 [thread overview]
Message-ID: <20c50258-a5cc-433c-836e-92ed8ec1ce7d@oss.qualcomm.com> (raw)
In-Reply-To: <20261021073633.2163128-5-shengchao.guo@oss.qualcomm.com>
On 10/21/26 9:36 AM, Shawn Guo wrote:
> From: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
>
> Enable audio on the nord-ride-embedded board. Add a soundcard node using
> the qcom,nord-sndcard compatible.
>
> Add PCM1681/ADAU1979 codec nodes on I2C18, with the PCM1681 system
> clock supplied via MCLK0. The DAC control lines come off a TCA6408 I/O
> expander on the same bus.
>
> Describe DAC_ENABLE as the enable of two regulator-fixed supplies
> (3.3V and 5V load switches) feeding the PCM1681, and the three MAX9892
> click-and-pop suppressors as one simple-audio-amplifier on
> CLICK_POP_MUTE_N, routed after VOUT1..6, so DAPM controls the mute.
[...]
> + expander0: gpio@20 {
> + compatible = "ti,tca6408";
> + reg = <0x20>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + interrupts-extended = <&pmau0102_l_gpios 6 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&pmau0102_l_gpios 5 GPIO_ACTIVE_LOW>;
> + vcc-supply =<&vreg_per_3p3>;
nit, missing space after assignment
otherwise
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-11-02 13:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 7:36 [PATCH RFC v2 0/5] arm64: dts: qcom: Add audio support for Nord platform Shawn Guo
2026-10-21 7:36 ` [PATCH RFC v2 1/5] soc: qcom: pd-mapper: Add support for Nord Shawn Guo
2026-10-21 9:08 ` Abel Vesa
2026-10-21 9:41 ` Bartosz Golaszewski
2026-10-21 9:56 ` Konrad Dybcio
2026-10-29 9:13 ` Shawn Guo
2026-10-21 7:36 ` [PATCH RFC v2 2/5] arm64: dts: qcom: nord: Add gpr node Shawn Guo
2026-10-21 9:10 ` Abel Vesa
2026-10-21 9:44 ` Bartosz Golaszewski
2026-10-21 7:36 ` [PATCH RFC v2 3/5] arm64: dts: qcom: nord-embedded: Raise i2c18 pad drive strength Shawn Guo
2026-10-21 9:44 ` Bartosz Golaszewski
2026-10-21 7:36 ` [PATCH RFC v2 4/5] arm64: dts: qcom: nord-ride-embedded: Add sound support Shawn Guo
2026-11-02 13:21 ` Konrad Dybcio [this message]
2026-10-21 7:36 ` [PATCH RFC v2 5/5] arm64: dts: qcom: nord-rrd: " Shawn Guo
2026-11-02 13:21 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20c50258-a5cc-433c-836e-92ed8ec1ce7d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=zhangfei.gao@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®