From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932142AbdETTPF (ORCPT ); Sat, 20 May 2017 15:15:05 -0400 Received: from mout.web.de ([212.227.17.11]:60289 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbdETTPC (ORCPT ); Sat, 20 May 2017 15:15:02 -0400 Subject: [PATCH 4/5] fsl_hypervisor: Use kcalloc() in ioctl_memcpy() From: SF Markus Elfring To: Arnd Bergmann , Jan Kara , Jesper Nilsson , Kumar Gala , Lorenzo Stoakes , Michal Hocko , Timur Tabi Cc: LKML , kernel-janitors@vger.kernel.org References: <38a9b933-4cdc-53e7-0a4c-20f96c57648c@users.sourceforge.net> Message-ID: <20c641bb-33af-39ec-9208-cbc560441223@users.sourceforge.net> Date: Sat, 20 May 2017 21:14:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <38a9b933-4cdc-53e7-0a4c-20f96c57648c@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Mp9gDT1F+hYMIZIvBPQ+XN35KcENW3f2CM5Kt/8PuFFpD2Ggak0 Y8H1vto8fmrzu+WDMMIlDzJ4Ntz9ZblBWy5Q9sVhfxD8Zzs7ATSjpVn3NEyoZB+iKlXnAor mSXN5ZwC+eG3ILeuHC903iokRE0hbKVos2U+8RLa39cXPqm+LW1j4B3yfcYTacyxme+P0eh y3Zr88O9rOZrtK/wKNTDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:WxlGL5nXpoY=:47j/x30eBpY9H2UccFXX52 ShAt6MqubMQg+SeukzZyowB+b5JksKUo/hddT+qs30/SZlIq/iB07CKeOPXFp3c9TuN0mCdpc ZtrdlDkiWckeAq+dMJUr3XcwXbv25r5dgQtrJLAsUJaIh24ZbIksHoiNBRl0RrwU3ElM0/ZT4 fwwC9PiR/2WPbEp3zwFavS7yy5gJNZe2/L6mXxDetR+l99ycAU4KYorI6F3TPfbEqJsVwNICL 7k4cEtP3qx5KO3I/PDnE1Lj3IAoKWtgPeqsnglA//+loGzcnUSA1sUunbKiXyt6qap/YtwyPi oBMzbp6qV4s6KW1WZtrqxruZiMBKRyIlanVusxiUNqqrLJxOdydEa3Af+Dpb2BGkunZ/oGMRU DmQYA5RKLRK0C3N4QeiSU60Z8QHum16O8v2yxwiKVMjx8dVSSKwdakgZzUC28R2RM8ntcfaOz A1GpgQPt4O6dbSt+gAF6KAqQ4HMIWdRXVaegV6/VFXVBFhjA0FYOVXzLvwdFnXv64Z9Jkyjwp /B5v3zOoE0en8TWtjHuLGbiWtc3PRmRC4DPuWtrR/VrFhyADsmDrYSeG9vpXe4yz2ntgq0+SY jAZyaPgzxabKjMb/XLbCMZg4NGWFBbb2QhnGaHwFUI9P40DjhUSD1ONopquPa48eGeqjoqD4P 5EOKGmlFbQVLi9bspQZzprZ9otJ/QZlNN/q5X3jkcs1bFz6pT16saGLMMEMhGvjiSeAulYCnm 0WpiMTByZl5+hADdamcKuDxLHcI/U+YrYnb8rtPFzXMMupNcNyQRqNo8rxB10DB0z/1HL2o5c e2Y79nu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 20 May 2017 20:15:57 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/virt/fsl_hypervisor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c index 9e881dc29c6b..4031632b8c9d 100644 --- a/drivers/virt/fsl_hypervisor.c +++ b/drivers/virt/fsl_hypervisor.c @@ -223,5 +223,5 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p) * 'pages' is an array of struct page pointers that's initialized by * get_user_pages(). */ - pages = kzalloc(num_pages * sizeof(struct page *), GFP_KERNEL); + pages = kcalloc(num_pages, sizeof(*pages), GFP_KERNEL); if (!pages) { -- 2.13.0