From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB353E1205 for ; Thu, 23 Jul 2026 09:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784799260; cv=none; b=i+QlPF+iUS1P2w0kG+k4hXaMFDrLyrYh5dBlAs6ADplf3vgkiaeHBnnem46odskOqMUtU009yCkV9yY/8XOc7VuX8D+++qS5I6qs4yFCLGncvVsjxA1mh4WH7pvnRTT7r26KOKuRzBoIpkC77D23W/Lfgk8PoFW2C3KLj2KNfOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784799260; c=relaxed/simple; bh=3ERx3QEm5vOrtZp45kHOZ2Xl4tp4BshFW+OL+xcGQKI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XBUwQnZZqY5VunLTg5DkDRUN9NBuUd+oSrAOS1WVIJyAP4KY0XeyPXL4KBEfihQZLz6qpTuPBjZ6QBPnawRj5I4pr9KbSUtsfcYYHNSQ4LyTYSDAOaILQ7LP+cuLH99WC3cOU1BSw4fNg58nH97IrHM5ELPoNDjVDy3qEPtFVTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YtKbG1Dg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SYcVguHZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YtKbG1Dg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SYcVguHZ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N8qf3n3642610 for ; Thu, 23 Jul 2026 09:34:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SJk/WEf9xX/T6XBL4N4jb2++nwLoZNRVcvk1ujXHkFk=; b=YtKbG1Dgfxa7z2w/ 7xpxdfoVQHDPHg7BwW/FoUJwDpYkEuegAhCV/pZXax6Bbk3OQF9mNH9oLSYxwPLs oofKRX/+r9gn1Z/7B3Ss6XiFtjxzeeaxQQb+IQtNwLWb1+Ek1WdFzli3IyphAyMK mAQGUBYmGKYmOrGNr8rjUi2hIWWu7/TZb0HaKLxKdrudpF3lDEIbTQfCZWj5O3zF NgK+02k9T9bdn3lvTpUDE84HZjuQ4n/SbTtZ5MCZN8UlWgfioAKapkaE3u88fofp eS0ScBnJ/qIjZIcuyXhdhzlpqZD8dvPkPmF4gtfGH+JI9kL3CTsQtuUxg/KOpxhc 98VkIQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fkayh9bkd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 09:34:14 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1e777a15so1479151cf.2 for ; Thu, 23 Jul 2026 02:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784799253; x=1785404053; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SJk/WEf9xX/T6XBL4N4jb2++nwLoZNRVcvk1ujXHkFk=; b=SYcVguHZhsyG1NcVnKgpc818ZhCh2m/S8xxwC02jL8cE7Zab9SrqZGXlQI81yWE89Z KLd7EFhOpzgdsJLtHh+sSRNo7AKa1XVNOwPmJH7j1QJpqvkTMB1jgN4y0eTLHquolv3E NLhj5E8HCMj2WL4aYPQ3Na+VEEn+qvBGLWb+hZP8mBREbTiLcsC+rvYivNu9Jg9RGMCQ X0WaumagehgsoeoB+wHFrYXp6up3C/oNrg2mRNd2ZnaKwCb69Z0g2Fzy67swM288wcwA p/WF6ETv2X3/n/NKLEPgPlH63wec7ufMraWDNIBH3uRGtaO658Q9IQ//4ah97FHuM2V7 rsyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784799253; x=1785404053; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SJk/WEf9xX/T6XBL4N4jb2++nwLoZNRVcvk1ujXHkFk=; b=TNQJfLPSGTndUnnIcWLfBtgf3RIX92Lj7oXvLtVA22RIxYrcsGANioohaq87Dd01l5 wuOlK9+3DF6f/7VNbIywIFXT9/lEYtXjSx70TPX2N5cZTOyZRJBoHxTPoCQ+mn7iCr8o Bc30VWlQNuHEC/oPICH4ezrHDuUWFfOI+mO8Lq5vpbv6C4DdQl5s3SYWsww5iJ32urJB 5RI5P2jQlktgvKXs1D2vitc/vtN+RCOiOGkfhhCq5hqPLtrx8j1KsR6TFZ+u9netWQ8i FQz9WKsdVkt+OUcIUSkBkTmgQ3mpos8ZBRw1JpVK5QyXq6fKGGTl9EfuIUqr53065IfB nNZA== X-Forwarded-Encrypted: i=1; AHgh+RqArPD7rYe7yTVRxuZP70QThrHUzGOI91oydCh90uL4kEdEMi9eCw6O9lX7rkbo/f6dUkVyuJqLizrpPhY=@vger.kernel.org X-Gm-Message-State: AOJu0YwEEccWcKJ8fP95xPthN0olLfpLdbWJEUwyIMnwaQ4R4oOyDknZ fHn26xm6ier7Chu6/PmDj1imxBRAxceh3l9fc/kh5DNFY2cpU5t4EdbbAHWpsCFhUlgzD6HGaXC Ec8vvCOK84FnC7vEes6hgmhxG/x5LPsAoKgPKIKn8kE8fARuS9Fyas/sXsM4EDDNIibk= X-Gm-Gg: AR+sD10sNpmxKiDpv4mmQBL1u0HeGkN+CDGfMW7C3K+uYpi6smWXiUbq4NnCuvgrflx LadJrFWa/BYdW7kCpcj5+k3j0YZOZxMS6fdqJyXjA65BaAS5Z+OokCCQkGYor8QWwXLSfGaYaCo C+wVkcXQqVCs6jA5arILwyYAHrdmZywu0cE3pQrRVYgYBX/vHkX9Vms01pGa3CFEQ9tS0QoMVdD FXCJquKxBCp/RER1Q66CLKNTXdrWniADok4w7CjaZWjPK/ZXFKk1iBO20bc2ruAxsJ59P3nMYJg khW1woGhRhfpPwcpTl1yMIrvj9jR+H+bw1Jw5LqAquPfz0Wuy1O3qqQSsSDj+Fq9kZdyIa3aorZ udWg1gHYkAFyltX+viXkPBNyO X-Received: by 2002:a05:622a:1455:b0:527:7076:7859 with SMTP id d75a77b69052e-5283ded8570mr17983801cf.6.1784799253620; Thu, 23 Jul 2026 02:34:13 -0700 (PDT) X-Received: by 2002:a05:622a:1455:b0:527:7076:7859 with SMTP id d75a77b69052e-5283ded8570mr17983541cf.6.1784799253086; Thu, 23 Jul 2026 02:34:13 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32ac8c3esm210300766b.23.2026.07.23.02.34.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 02:34:12 -0700 (PDT) Message-ID: <20c703b7-306b-4026-842a-a62722d96ad3@oss.qualcomm.com> Date: Thu, 23 Jul 2026 11:34:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] remoteproc: Allow shutdown of crashed processors To: Bjorn Andersson , Bjorn Andersson , Mathieu Poirier , Shengjiu Wang , Fernando Guzman Lugo , Ohad Ben-Cohen Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260723-rproc-rmmod-not-crashing-v1-0-546dfd5de0e6@oss.qualcomm.com> <20260723-rproc-rmmod-not-crashing-v1-1-546dfd5de0e6@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260723-rproc-rmmod-not-crashing-v1-1-546dfd5de0e6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=HZgkiCE8 c=1 sm=1 tr=0 ts=6a61e016 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=2pRFMVAohkf1fqEOkS8A:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: YXBmPhLslRgJz99IZku5avzDNLIQ8JT6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDA5NCBTYWx0ZWRfX002TKlSxC7VH j9ZHtP6cB8cKXNWfhavBMdtc1rm1rfO9/KB3i5cvZHyuYULf7KhXn6tZ2FlEQC1jVRTNT6CvRmT d5z7MH6VUwxPGjs2z1qQ8R0gCx2lsyPi3IoniM62VYFYWCUrrQIvycSpS3dkAbv/vv38WfTlaui ATDHUeUNqdcSo4zZUDRhohSZ1g+2Ixne9XUbzLYfC5qsdzs99Mse0UOk4lK9+clEMXaSU/C5iOF 6xhld4u6Atv+l81PFACnr/rCK8GxJBXjH1liSj8s+biMvkFjLzBJ0OzJ+TwTCEx8JWt07WpValI HGVn2gNIUj4qNqJbdd1XROQaQLelW3WIsChd0gHMuNvvZsjqRc00m3zui6FG1azleTmk+5vfiZ6 +6CIc+MiL69nUzO4hvpFtP0hdVS+h4XHO1/AEiXW+nBvLzapQj1YDf4PROVzWrpq7JwgZ7nsLaw w9JdTksPBQAShCGgfLA== X-Proofpoint-GUID: YXBmPhLslRgJz99IZku5avzDNLIQ8JT6 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDA5NCBTYWx0ZWRfXywBu24JvZroh 0U7KjKfnD0NhOUwAzkiYwWCNbDLSfP6UoUbZjZXLbc31ku7XMz6wKHFvdXAw1EtEyIYQQjepteS bwwAi8q0tKUp2+umxfjNcflj7Dp33Q4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_03,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230094 On 7/23/26 5:52 AM, Bjorn Andersson wrote: > rproc_shutdown() rejects a remoteproc in RPROC_CRASHED state, and > rproc_del() ignores that error. The result of these two decisions is > that a user cannot stop a remoteproc that with recovery disabled that > has entered a crash state, and removal of an associated remoteproc > driver will release resources without first stopping the remoteproc. > > Allow rproc_shutdown() to stop crashed processors. Propagate the crash > state to subdevice teardown, to allow subdevices to dismantle things > appropriately. > > Assisted-by: OpenCode:GPT-5.5 > Fixes: 5e6a0e05270e ("remoteproc: core: Move state checking to remoteproc_core") > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Konrad Dybcio Konrad