From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC9BC4332F for ; Mon, 14 Nov 2022 16:16:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235643AbiKNQQp (ORCPT ); Mon, 14 Nov 2022 11:16:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236703AbiKNQQk (ORCPT ); Mon, 14 Nov 2022 11:16:40 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D5964CA for ; Mon, 14 Nov 2022 08:16:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668442599; x=1699978599; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kiwQ0EsjaVIc5nx8UNug8Up0eAjXuQJy1+lUnlUIbdA=; b=eUhfqKStdPwNr7pNjCRH2D6DJKBoysExQs46D433AzF2gE77JAgqbdsw hVl1GGRgtwcQXMiQJQ9/jrlgh/A0fY+tukns/yFfBgeLWCrnn4ZUQVFPB lCPHLvb+DShy7n14ZU3HZlejcGgXJe6Ggrv1JBooT4tbjYT6rytoQ1Jxy Nf7HiWOo04XKL8MVsi+3IhAs3OTNeIbv39b4Qb8XWrTvYOKwQOueypHsv AiK2ZLUUi6bneIcvR35XnaCi2uP2xoB5fkpfppItouOsA/M+izGNySxlU 6qkF1TK9UdcwSyJULwXLgwXjTcZVjN3vBpecAw7KhwS6gvkBWoajeuRaA g==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="295373422" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="295373422" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 08:16:39 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="638542546" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="638542546" Received: from scewbso01.amr.corp.intel.com (HELO [10.212.76.77]) ([10.212.76.77]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 08:16:37 -0800 Message-ID: <20d36e6d-0c4b-f903-8940-841ac1b65d98@linux.intel.com> Date: Mon, 14 Nov 2022 10:11:34 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v1 0/2] Adds the combination of headset codec ALC5682I-VD + amp rt1019p Content-Language: en-US To: Ajye Huang , linux-kernel@vger.kernel.org Cc: Mark Brown , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Brent Lu , Yong Zhi , Mac Chiang , ye xingchen , Vamshi Krishna , Muralidhar Reddy , Libin Yang , David Lin , alsa-devel@alsa-project.org References: <20221108042716.2930255-1-ajye_huang@compal.corp-partner.google.com> From: Pierre-Louis Bossart In-Reply-To: <20221108042716.2930255-1-ajye_huang@compal.corp-partner.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/7/22 22:27, Ajye Huang wrote: > v1: > - machine driver: > - Adds the combination of headset codec ALC5682I-VD + amp rt1019p. > - Remove the duplicate code in machine driver. > > Ajye Huang (2): > ASoC: Intel: sof_rt5682: add support for ALC5682I-VD with amp rt1019p > ASoC: Intel: sof rt5682: remove the duplicate codes Nice catch on the second patch, this sort of duplicates are hard to detect in code reviews. For the series: Acked-by: Pierre-Louis Bossart > > sound/soc/intel/boards/sof_rt5682.c | 7 +------ > sound/soc/intel/common/soc-acpi-intel-adl-match.c | 4 ++-- > 2 files changed, 3 insertions(+), 8 deletions(-) >