mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<imx@lists.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	Liu Ying <victor.liu@nxp.com>
Subject: Re: [PATCH 1/1] ARM: dts: imx6sx: remove fallback compatible string fsl,imx28-lcdif
Date: Fri, 6 Mar 2026 08:16:37 +0100	[thread overview]
Message-ID: <20d37ab7-308e-4f07-96dc-7ae011af76d0@kernel.org> (raw)
In-Reply-To: <aaoIKmhcgIZdFvbz@lizhi-Precision-Tower-5810>

On 05/03/2026 23:48, Frank Li wrote:
> On Thu, Mar 05, 2026 at 10:34:18PM +0100, Krzysztof Kozlowski wrote:
>> On 05/03/2026 22:23, Frank Li wrote:
>>> i.MX6SX uses the v6 LCDIF controller, while i.MX28 uses the older v4
>>> version. The driver has supported the "fsl,imx6sx-lcdif" compatible string
>>> since the initial commit:
>>>
>>>    commit 45d59d704080 ("drm: Add new driver for MXSFB controller")
>>>
>>> Therefore the fallback compatible string "fsl,imx28-lcdif" is not required
>>> and can be removed.
>>
>> It is required - you are changing the ABI and possibly impacting other
>> users without valid reason ("not required and can be removed" is not a
>> reason).
> 
> In https://lore.kernel.org/imx/42eb2d42-47b0-46b6-92e9-c59473113c2d@nxp.com/
> 
> other known user barebox/uboot already fix it.
> 
> https://lore.barebox.org/barebox/20251107210033.2229781-3-a.fatoum@barebox.org/T/#u
> https://git.pengutronix.de/cgit/barebox/commit/?id=c99b937f3a31

And you have entire commit msg to explain the ABI impact...

Best regards,
Krzysztof

  reply	other threads:[~2026-03-06  7:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 21:23 Frank Li
2026-03-05 21:34 ` Krzysztof Kozlowski
2026-03-05 22:48   ` Frank Li
2026-03-06  7:16     ` Krzysztof Kozlowski [this message]
2026-03-06  3:12   ` Liu Ying
2026-03-06  3:24 ` Liu Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20d37ab7-308e-4f07-96dc-7ae011af76d0@kernel.org \
    --to=krzk@kernel.org \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®