From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07B0E1779A9 for ; Sat, 31 Aug 2024 08:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725093122; cv=none; b=TGaEBIX0an5r1iN1eJ823kUBVOPmUVVb3+hmguXQV52y7VsbHRKq1uLIeKbfFryp1IySkRuTLQpIXUEhbrKAMLCAKEJeVU+9BOS2L5VzeSrGz4t4FtBwOYZVkFLZVvyHp9YbloKygSF9p42mdjNJUyAE/HScP9decuzxIhsWB+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725093122; c=relaxed/simple; bh=ygokJ3EuwP2KVqqlmTrJeAJWWdyXSr8sqWsV9WTAHco=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=CDnpsC7epdtS2wSbz+dpo0mi7Rh0XdKhzwQQ5cKdfyZSFwBhd2Gmgb3BZO435PzmzbXc6LUsHU5vIQRZ5Pi2CN8BkjP3aYV8c2Nhugm8HcUC7qHntnbKXL1rLodH5TPube5GCdNl6wbXgjMbxDmTLza4ye9R/iBhOgDyGeRq6+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Twxkm2zr; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Twxkm2zr" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-374c0a8c7a9so134415f8f.0 for ; Sat, 31 Aug 2024 01:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725093118; x=1725697918; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cYKXU/GRuYajonH8bLwJRIkuKYJn/KULcoZQ/7PWKrE=; b=Twxkm2zr7sDaxXCm1z+Nm3OxpW02sG0MMev4bvEXHSXO+kRL9v/msuKTxiJ+f4uyat lFJ/kwmushDU+bcKITE+++jE2cBtJYMc8zfGOlOCEDa+59TY/0bDnL7uLSfifIHeoaBf yLmlDVWlEkfL1yPYro3Xr0Z9SbUmB8cxH8Nahu1zDCw3m4Hw4JZeK01YRSxHE2PVsz/e I9dgXBdmEk4hSPMUBsxRXbuVfKYXO7KOyBv0YnC3MRjCQcwEG/qx4xOlysgH+ZF/SMtw mKImu8jcMhcLwxiFu7sF8L4AO2UHYj+E2b2aqPzLp/DVy7gx7powT/gTCpEGisi3+zdp F/kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725093118; x=1725697918; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cYKXU/GRuYajonH8bLwJRIkuKYJn/KULcoZQ/7PWKrE=; b=VNW4FYlyFDddTw7i0aUuAN2mphod/B4zCqGn8MOvsdBC4P52jTI6TLWgfUpcMhVuei OnOiytWa1r91MUqdAuj9fMCgdUYpDwfpWcA3YSwMsKJb49vebeK+AUV948FTbPNJIgff Xm3Tcp48P6gxz8oVFJXrhiRcy4XjyRD8SCSFBJqVus+YEDbuYEJyOztOhGcJZ/qU+15X c0ZiRHYf2RYYCE4Kbe70fqAbQpyQwq2gpXahBuOyH3VRR1Tpldwp7X6pWEG3q6Ay3RDC +LkLf4cLKToCbNmrxzA0QEZ2vPlQIcVpFsRAQKcZAjbvWKK7g6vEwRlkxXZzsZN9zfvB 8fsA== X-Forwarded-Encrypted: i=1; AJvYcCVvB0usOGW3xyESUTsJHz8DAj0FlojWzfG4l1SKV+ERppGt6n0ydfZMD8NbL0VNEFbfn3SLAm6wHilITmI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3qeDCEIYgLwVJMIrIMAzcnD4i/K4EktWTrLKUjtfzZPxNY7Og dfaB0SApNvx19Pogin1Aq6m801zdRzdWvkPbgl1DkiDpkC1FbxPu2yswduxc054= X-Google-Smtp-Source: AGHT+IEY8B96yyKAmsk7FOyikce6yeIKfN0PQpvR2+w944msLHKH11XTNcpqiCg0x0+w3FqoiWogJA== X-Received: by 2002:adf:e5c9:0:b0:374:c2e9:28b8 with SMTP id ffacd0b85a97d-374c2e92d16mr52551f8f.18.1725093118067; Sat, 31 Aug 2024 01:31:58 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374c08e07b6sm759594f8f.63.2024.08.31.01.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Aug 2024 01:31:57 -0700 (PDT) Date: Sat, 31 Aug 2024 11:31:53 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Andy Shevchenko , Greg Kroah-Hartman , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Hans de Goede , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, "Rafael J. Wysocki" , Daniel Scally Subject: Re: [PATCH v2 2/4] platform/x86: int3472: Simplify dev_err_probe() usage Message-ID: <20dd56f0-78ea-4255-86ac-32151160b83d@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822130722.1261891-3-andriy.shevchenko@linux.intel.com> Hi Andy, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/driver-core-Ignore-0-in-dev_err_probe/20240826-113856 base: driver-core/driver-core-testing patch link: https://lore.kernel.org/r/20240822130722.1261891-3-andriy.shevchenko%40linux.intel.com patch subject: [PATCH v2 2/4] platform/x86: int3472: Simplify dev_err_probe() usage config: i386-randconfig-141-20240830 (https://download.01.org/0day-ci/archive/20240831/202408310807.sNPe5Mr2-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202408310807.sNPe5Mr2-lkp@intel.com/ smatch warnings: drivers/platform/x86/intel/int3472/discrete.c:292 skl_int3472_handle_gpio_resources() error: uninitialized symbol 'err_msg'. drivers/platform/x86/intel/int3472/discrete.c:292 skl_int3472_handle_gpio_resources() warn: passing zero to 'dev_err_probe' vim +/err_msg +292 drivers/platform/x86/intel/int3472/discrete.c 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 270 case INT3472_GPIO_TYPE_POWER_ENABLE: 53c5f7f6e7930f drivers/platform/x86/intel/int3472/discrete.c Hans de Goede 2023-10-04 271 ret = skl_int3472_register_regulator(int3472, gpio); 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 272 if (ret) 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 273 err_msg = "Failed to map regulator to sensor\n"; 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 274 53c5f7f6e7930f drivers/platform/x86/intel/int3472/discrete.c Hans de Goede 2023-10-04 275 break; 53c5f7f6e7930f drivers/platform/x86/intel/int3472/discrete.c Hans de Goede 2023-10-04 276 default: /* Never reached */ 53c5f7f6e7930f drivers/platform/x86/intel/int3472/discrete.c Hans de Goede 2023-10-04 277 ret = -EINVAL; 53c5f7f6e7930f drivers/platform/x86/intel/int3472/discrete.c Hans de Goede 2023-10-04 278 break; 53c5f7f6e7930f drivers/platform/x86/intel/int3472/discrete.c Hans de Goede 2023-10-04 279 } 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 280 break; 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 281 default: 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 282 dev_warn(int3472->dev, 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 283 "GPIO type 0x%02x unknown; the sensor may not work\n", 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 284 type); 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 285 ret = 1; ^^^^^^^^ 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 286 break; 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 287 } 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 288 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 289 int3472->ngpios++; 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 290 ACPI_FREE(obj); 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 291 5de691bffe57fd drivers/platform/x86/intel-int3472/intel_skl_int3472_discrete.c Daniel Scally 2021-06-03 @292 return dev_err_probe(int3472->dev, ret, err_msg); This is the success path. "err_msg" is only set for the error path. "ret" is 1 so it will use the uninitialized data. But even if ret were zero, it's illegal to pass uninitialized variables to functions which aren't inlined. 1) It's undefined behavior 2) Linus said so 3) It causes UBSan warnings at runtime. regards, dan carpenter -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki