From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Xin Li <xin@zytor.com>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Subject: Re: [PATCH] x86/fred: Fix 64bit identifier in fred_ss
Date: Fri, 15 Aug 2025 09:21:23 -0700 [thread overview]
Message-ID: <20dd9552-65fd-4887-a6f9-667a8d7eed34@zytor.com> (raw)
In-Reply-To: <20250814190436.2555438-1-andrew.cooper3@citrix.com>
On 2025-08-14 12:04, Andrew Cooper wrote:
> FRED can only be enabled in Long Mode. This is the 64bit mode (as opposed to
> compatibility mode) identifier, rather than being something hard-wired at 1.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
[...]
> IIRC, this was wrong in an older version of the FRED spec. I made the same
> mistake in Xen, and I didn't copy Linux's structure.
>
> I don't thinks this warrants backporting, but the fixes tag is:
>
> Fixes: 3c77bf02d0c0 ("x86/ptrace: Add FRED additional information to the pt_regs structure")
Please make it explicit that this patch is "no functional change", i.e.
it is naming-only patch.
Other than that:
Reviewed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
next prev parent reply other threads:[~2025-08-15 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 19:04 Andrew Cooper
2025-08-15 3:55 ` Xin Li
2025-08-15 16:21 ` H. Peter Anvin [this message]
2025-09-02 23:01 ` [PATCH v2] " Andrew Cooper
2025-09-03 0:01 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20dd9552-65fd-4887-a6f9-667a8d7eed34@zytor.com \
--to=hpa@zytor.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®