From: Shreenidhi Shedi <yesshedi@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: dwmw2@infradead.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, sshedi@vmware.com
Subject: Re: [ PATCH v4 1/6] sign-file: refactor argument parsing logic
Date: Mon, 20 Mar 2023 21:17:53 +0530 [thread overview]
Message-ID: <20df2a0e-def9-632a-865a-1b6569071f76@gmail.com> (raw)
In-Reply-To: <3755243.1678810894@warthog.procyon.org.uk>
On Tue, 14-Mar-2023 21:51, David Howells wrote:
> Shreenidhi Shedi <yesshedi@gmail.com> wrote:
>
>> + {"privkey", required_argument, 0, 'p'},
>
> Please don't change the flag assignment - you can add new ones, but don't
> change the existing. This program is used by a lot of scripts.
>
> David
>
David, thanks for the review. I will address the issues and send revised
patches soon.
--
Shedi
prev parent reply other threads:[~2023-03-20 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 17:07 Shreenidhi Shedi
2023-02-21 17:08 ` [ PATCH v4 2/6] sign-file: move file signing logic to its own function Shreenidhi Shedi
2023-02-21 17:08 ` [ PATCH v4 3/6] sign-file: add support sign modules in bulk Shreenidhi Shedi
2023-02-21 17:08 ` [ PATCH v4 4/6] sign-file: cosmetic fix Shreenidhi Shedi
2023-02-21 17:08 ` [ PATCH v4 5/6] sign-file: use const with a global string constant Shreenidhi Shedi
2023-02-21 17:08 ` [ PATCH v4 6/6] sign-file: improve help message Shreenidhi Shedi
2023-02-21 17:18 ` [ PATCH v4 1/6] sign-file: refactor argument parsing logic Greg KH
2023-03-14 16:02 ` David Howells
2023-03-14 16:10 ` [ PATCH v4 2/6] sign-file: move file signing logic to its own function David Howells
2023-03-14 16:13 ` [ PATCH v4 3/6] sign-file: add support sign modules in bulk David Howells
2023-03-14 16:14 ` [ PATCH v4 4/6] sign-file: cosmetic fix David Howells
2023-03-14 16:15 ` [ PATCH v4 5/6] sign-file: use const with a global string constant David Howells
2023-03-14 16:20 ` [ PATCH v4 6/6] sign-file: improve help message David Howells
2023-03-14 16:21 ` [ PATCH v4 1/6] sign-file: refactor argument parsing logic David Howells
2023-03-20 15:47 ` Shreenidhi Shedi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20df2a0e-def9-632a-865a-1b6569071f76@gmail.com \
--to=yesshedi@gmail.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshedi@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®