From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbdJZFBL (ORCPT ); Thu, 26 Oct 2017 01:01:11 -0400 Received: from mout.web.de ([212.227.17.11]:63024 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbdJZFBJ (ORCPT ); Thu, 26 Oct 2017 01:01:09 -0400 Subject: Re: I2C-Octeon: Use common error handling code in octeon_i2c_probe() To: David Daney , David Daney , linux-i2c@vger.kernel.org Cc: Jan Glauber , Wolfram Sang , LKML , kernel-janitors@vger.kernel.org References: <73affb84-9cdd-9f5c-b96a-5a392739e789@users.sourceforge.net> <77df0e64-bf30-b6d0-b28b-ddb3c0574dfe@caviumnetworks.com> From: SF Markus Elfring Message-ID: <20e16385-afab-1d3d-b682-04589568850e@users.sourceforge.net> Date: Thu, 26 Oct 2017 07:00:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <77df0e64-bf30-b6d0-b28b-ddb3c0574dfe@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:5jgX5wgWqJWAVvVzqu1li/kGcT8KuAVplxYIRD+qNBZAXM/Zdam VRXqR4F5hnOPb+G91Y1e1oV612+uyf2jBLWVKuASp56k1FUtkc8Qz0qL+ICfG4GSTYfRi9g rztfrdJ+XccAb7OVYMtARV7OIVVLsrzZ9iz3AE50XoV+8ESx1qHiqe0OAD9agBFON3P7ViQ mXzDkjp2wGmVwQRAXDdQA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Jt4SGi3Ikgo=:HlevXyCTHgaV8kSCU/P1h6 FVwZLbYH1AeBZSjXCXKrIB9IzKE/dH1FL5nobe7EPIuCPoNuxFCaeF3/ZBLdBq8vGFJQOsxMC Oi81G9FEeiSugz3DDZAXdNusr4Led0NnxjBZ/sXbk4/rqTlozrB5jXEDO3hXbSN4OY8ARkd4H 306u6n9/+tkIO//WnfxmqriknX6aikpCNUwOd5VU6WuOWtxDRzJOyksUxSlipmPutu53FWasY kkFKRSu7LMEulw/4aStEkmYA8O9l5zHlYiXr7la9ShaaPRMiQJ90wD+MewhHwTBQRMYybJ/+o a3PpNhqrZ34Vq7L2yXhkyEUNkmHwUR0YJaqQuQVqoMOz3u/mUV9OY88lfVstRpAM6h0/9pdrI Z3ueiT70G4qFcTa4EMg7uskx9ux+idd5aITwQXb+Mmf40uoCR8EhEXYYch20tMWEWIX7gcSN3 uwL0GTC4z/ThZnD34WsQOAIbudltTr/6RjAuEfmt7bipZI0tKIWPGqKYQolqv7d4qfF2PdxCx RL1Cy0MkU1qnK6tmhg3edRF7z/wt/BhGZnx2xxmEZDHDYVmfEgk0Edkfqb/O9Jru5bMTQlyQj hnTvHBf14PF3WWilXnRYIuP0mCoZ4fTWwTB06KH22fjkJH5gGKKxTCtm7WVS/B2qOUeNlwM0m GS8h4CmI0yP9mc7S+LZGuOGv7KhSGbpZehZrTdXNfcW+kTn6cATbFxN5ndPlXQF6rmH/nkTo9 9XJmlBMZle6i8R2uEvh1YBO/e+M4IODa7/v3rx2/2A38X8pS90CvGY0bk+iXYOBP/96Z7+gLi kT68XoxuuqWvqDhe2xYJyCnebEonBJ+Jg7tyTQTKU5BHtnrYNg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > NAK.  We don't need any more Markus Elfring spam. Why do you not like another update suggestion for this use case? >> Add a jump target so that a specific error message is stored only once >> at the end of this function implementation. > > Please read C standard about duplicate literal strings to see > why this is a completely misleading and false statement. * I proposed to adjust the position for one function call, didn't I? * Do you care for a bit of code reduction? * Do you prefer to use an optimisation option like “-fmerge-constants” (instead of integrating the shown small change)? Regards, Markus