From: Amelie Delaunay <amelie.delaunay@foss.st.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Fabien Dessenne <fabien.dessenne@foss.st.com>
Cc: <devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: Fix User button on stm32mp135f-dk
Date: Mon, 16 Jan 2023 12:59:25 +0100 [thread overview]
Message-ID: <20e51ef8-15ae-e0cc-9a90-2694cbbcee7c@foss.st.com> (raw)
In-Reply-To: <98d2af06-8ef3-bb6b-1f29-4e33c1c748d6@linaro.org>
On 1/11/23 11:38, Krzysztof Kozlowski wrote:
> On 11/01/2023 11:07, Amelie Delaunay wrote:
>> This patch fixes the following dtbs_check warning on stm32mp135f-dk:
>> arch/arm/boot/dts/stm32mp135f-dk.dtb: gpio-keys: 'user-pa13' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
>> From schema: Documentation/devicetree/bindings/input/gpio-keys.yaml
>>
>> It renames user-pa13 node into button-user so that it matches gpio-keys
>> bindings.
>>
>> Fixes: 57012d79fefd ("ARM: dts: stm32: add UserPA13 button on stm32mp135f-dk")
>>
>
> No blank lines between the tags, but I would drop the Fixes anyway. This
> is not a bug, but convention and coding style.
>
Blank line + Fixes tag dropped in v2. Thanks
>> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
>> ---
>> arch/arm/boot/dts/stm32mp135f-dk.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp135f-dk.dts b/arch/arm/boot/dts/stm32mp135f-dk.dts
>> index 9ff5a3eaf55b..931877d6ddb9 100644
>> --- a/arch/arm/boot/dts/stm32mp135f-dk.dts
>> +++ b/arch/arm/boot/dts/stm32mp135f-dk.dts
>> @@ -40,7 +40,7 @@ optee@dd000000 {
>> gpio-keys {
>> compatible = "gpio-keys";
>>
>> - user-pa13 {
>> + button-user {
>
> Best regards,
> Krzysztof
>
Regards,
Amelie
prev parent reply other threads:[~2023-01-16 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 10:07 Amelie Delaunay
2023-01-11 10:38 ` Krzysztof Kozlowski
2023-01-16 11:59 ` Amelie Delaunay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e51ef8-15ae-e0cc-9a90-2694cbbcee7c@foss.st.com \
--to=amelie.delaunay@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabien.dessenne@foss.st.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®