From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10AA5CA0FF4 for ; Fri, 1 Sep 2023 18:00:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350468AbjIASAn (ORCPT ); Fri, 1 Sep 2023 14:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234381AbjIASAm (ORCPT ); Fri, 1 Sep 2023 14:00:42 -0400 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2043.outbound.protection.outlook.com [40.107.105.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC06E92; Fri, 1 Sep 2023 11:00:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UH42Pg7xVskRIjRUCMfopOszwBXBVVO1Lr6LDjr2I6Wiw2vpY+vwICee31VM9LC6UBma4YGOLPegKnjNynTcc0Hq7HtTUyapSyrJsAkgMFwQG7lZwBJU3Hw0VSLrR9Kz4CNCvS0NeQAt26HMvLvB9ZG01pJKpPARhHwtBV5N1wHFA04AFbZkcDvnq7LAjdwv4kdQ3IGkx0NkEU59Eh+Xdo+74Rr5eEe23RXDXaXUB07gbpRlVBPXCRted1RBPeHJvhhdqGbLji2MCEpAzpd3gKINQWupDSVrN83/BW2/HL7+PFqYCAOZdwZYjB4c3gaV2rWqsSLhktZR3GYSAIXdjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0x2xyv2ldgVKBrF/v5Np5GXAgsihMax+yTgbqrkZ0vQ=; b=iFQwY/rfZwSCDMHeST1kOGKC/KOcpm+hLucRY1dwJGuj1TQkfQeMbvbW62GGOdJ+tGEzKd2rLxV8y1zBTEBAwPLZcn/yZfK0C4KUvFV55EIiwkPxnKBR9Ext3ZDB7dHamPYEGTzsLsvJi8dH92AF/CcEsv6lAJgogIdgHF18u6mz1zjMJ6yG6/+78DMI2JfOCichLv4hYQzUILnUpciOz0lGjFcM7gSWEOIWyJ1AqjG1vGTzPEy9eXgKQz+iQh30WQyZu9w1hKh8+vk2U5KOKZmHnmna62JSQNSHoUI/Y4rmqSbng9iQB+iewXuMUDFArskppWLX0lelyFy+7bbHLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0x2xyv2ldgVKBrF/v5Np5GXAgsihMax+yTgbqrkZ0vQ=; b=IRM0JN+R/XCusQNydYb6ankdYvBxc4nHyKR32D2JDwg6eO1gOP7/TwMr2peGlxLSeGTcnpHjb0NOuci3wrys724gI1F7bJfn76w46bqhInVGsMyDPMB1XAUu7YssJXv77VlMMaqyoax5sdatkLGCgSN3KKhbSxOii8DzHWGVfp3C2dac8l58jdwHFn2RhaB+nZqKiaucpgW6qkyJynVnM7ZpNdh6tRwAY3u2FQpMqBdjFqnHNUkDx1XOMNiNQ5XvSgIiz1/Exb0npTMkj3/QOf6FumS3bW+aA8YFn3lFLWFqcaBq57O0WRLZGSad7FDJwIZBNJcDNephsRjijx59fQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from PA4PR04MB7790.eurprd04.prod.outlook.com (2603:10a6:102:cc::8) by DUZPR04MB9981.eurprd04.prod.outlook.com (2603:10a6:10:4d8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.21; Fri, 1 Sep 2023 18:00:36 +0000 Received: from PA4PR04MB7790.eurprd04.prod.outlook.com ([fe80::274c:c30b:ac8c:2361]) by PA4PR04MB7790.eurprd04.prod.outlook.com ([fe80::274c:c30b:ac8c:2361%2]) with mapi id 15.20.6745.026; Fri, 1 Sep 2023 18:00:36 +0000 Message-ID: <20f025f9-35d9-1f35-f21e-38e1bb44b74c@suse.com> Date: Fri, 1 Sep 2023 21:00:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [patch 17/17] x86/fpu: Move FPU initialization into arch_cpu_finalize_init() Content-Language: en-US To: Guenter Roeck , Thomas Gleixner Cc: LKML , x86@kernel.org, Linus Torvalds , "Ahmed S. Darwish" , Arnd Bergmann , Russell King , linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, Huacai Chen , WANG Xuerui , loongarch@lists.linux.dev, Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , linux-sh@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Richard Henderson , "James E.J. Bottomley" , Michael Ellerman , Chris Zankel , Tom Lendacky , semenzato@google.com References: <20230613223827.532680283@linutronix.de> <20230613224545.902376621@linutronix.de> From: Nikolay Borisov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::18) To PA4PR04MB7790.eurprd04.prod.outlook.com (2603:10a6:102:cc::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR04MB7790:EE_|DUZPR04MB9981:EE_ X-MS-Office365-Filtering-Correlation-Id: e8681a81-3c6f-4de9-0ebe-08dbab1557e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jht3jVClxqjO0JxUTW/w6t8wWYH9RswhH3PKRVsc+POZuCkt5/9kSPedrLL4L0P5NEr76V42XUobJZNATMzO4+K9yV8CdKj0EyX6np2sNHdTTZ25zjtTf9iICVxjxnQ8Nz/I+PBgVsEgrconixJtFiIW1gpD/vUL3guwcScEyNrbZPjvUpGW3nGty/37EEwD8JggIvI1aWoX/stIC92wK5au8Ta+ZyUyBoG6Okp6AaRG5uZRzWDjIshOjtIWIIyfRRuSc/vu6HeMHR5lDhD5b8HGyyH7yic0fqSs5pKNUHVia8YKGT4bsfVQLWynYsmiRh+ZUwwxZmHytbfYE+yvLAIRcwQliXx0teD3E7ZftibCcV8H8/mxMyKmkp3cfb1r+1xsymM5UXY2ndjFk4MRIEZI3VBdjiN84L7r01bkIrWPuFfAk5ejDaX96DCJfUf3g756vbUhRiihqYU2n2KU+iVNKwr9rxNPNDdhPg32/6fn8McFLVRHkNqXaHIIIlTRCeHlxBn7bBCunP+9Aq9+Mf49t25hhSJWJsITOXx24TajSVvDAp176m6p017OY16pDIBEQ4fCh8sQytVXuoQN57J6es4gmZHpaH4+JtAcoZwoTZqQ7y2CCecamrBAPacO3U5OBMwDJUWsEl2HU5xE9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR04MB7790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(136003)(346002)(376002)(396003)(39860400002)(186009)(1800799009)(451199024)(31686004)(36756003)(110136005)(66556008)(66946007)(2906002)(66476007)(316002)(5660300002)(54906003)(4326008)(8676002)(8936002)(7416002)(7406005)(41300700001)(6486002)(6512007)(6506007)(26005)(6666004)(478600001)(2616005)(31696002)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3RJMTEyMmxYQ0pFM3RRRW5zR3ZRVWVLOW1HYVh2MnRrN3JRWnFvVFZSTk1V?= =?utf-8?B?S0Y0alRtcEVHT0ViM3oremROVnRCSmJiaTR5Vzh2dTZCTFN6VmhSb2U4NXlp?= =?utf-8?B?ZlIweDBVakI1N1pmaFlpS3Vqa3JjN0QrUTVXUC9EcGR0T1RISE9zOS9UMzFG?= =?utf-8?B?VFVwOUg3WFdPUDM1UlZNL24wa2pYZmUyeC9ydkorR01Ma0psUmF2WEw3cVVt?= =?utf-8?B?Yy9wdEE5VTFDMnAzNlhqSTRUMXhBTkpVQ1FPM2tEQnBBeWhmTXY5N3ZnUjVT?= =?utf-8?B?WVoyU2FmellVZXhFazF6NEs2bHFQS0RoUnFUd0g1b09ZMEU3UXoyVXdXVUZn?= =?utf-8?B?Sk8yUGRoZW5mK0dhUjQrd2wwRTY5bnlmc3VIYVN6YmZ5aGpYOExCMGl1OS81?= =?utf-8?B?eGJMaCtDN2JrT2hzZE1kTjQxNGM2bHlwMU9HNlRtMEZTWU9WWThvaEF4ZXJY?= =?utf-8?B?VEpDMjdrSjVMTkgrUUlkenZiakpOWldicHVYbS9mVXF5UDY2TEZ3akZVT3JK?= =?utf-8?B?b1lFZmRYZVZwclJaRmUxa0hKK3o5VVhsSys3VGFTR0Y1SFFNbG40L3p6L1Fj?= =?utf-8?B?WlNobUFUMHFrOUJSeFE0Y3VhZ2RmWmdpN2RaT2kvZm9ETHplMXpEZVhUMWp2?= =?utf-8?B?WnJjRGsxYzB0czdCRElxK05ZSS9xdXV5Q0trckJKMWQ4OU84aVBUVzcrdFc1?= =?utf-8?B?eXcwdWY0UW5nOUpka3JZeCtNeVJSdE8rdTZ6VG1NU1h1VXphMlhTNmRFMElQ?= =?utf-8?B?SVpzRVI4STcwRnhmaHl4dWpYVGlDbkJONlJRQ3p1MjU4WVlKT1NqcXdHYWpX?= =?utf-8?B?aTcyZkJjaDhWUWZkWEZCaXZkMVMzQVJmQUJSSytQUUlaalRGYTgxQ1NvZjJS?= =?utf-8?B?OGh6VlNtNE9mdTEvSkdQS013QnJvVTVWbTdDcnR5VDlPR1lPOGYvaW9BV0ph?= =?utf-8?B?YVovU3hndTl1bHdMTDlrOFczVElCWFhwU3RweVI3V1dseU53SzJlbzlxUVRz?= =?utf-8?B?aDVUS2RxY0NtQ2hMdVBHQWNsV05tTzNqanFqK3NqM28zdzVpY2hVbm01SHhC?= =?utf-8?B?cGs0Rjk1SzRQNEhjN3NBOXRYWVcrejVMblMwZXNsQjBpSlprWERxTVBVb1c5?= =?utf-8?B?bDdwYzQzdDVqVGxBUzk4V3JPOUkvYmN0ZXZhTGtxOUd1V2liWHdNalVBaDNM?= =?utf-8?B?MnJobjBkSTl1Vkc1THVGRURJWDJoNWJrenVtUEJhTVhua0JuRC9ORWRBQ2ZH?= =?utf-8?B?Yk44Q09FTlJxOW9OeGljT0wxeDBpdmFCQ1NHcGoyUUxVa2lhYm50ZzdrZ3l3?= =?utf-8?B?c3hzUmwvV210K3Q1LzY3VytrY1oyc1VGSlNkL2NKZ1c2Rk5oTytudURFeks5?= =?utf-8?B?VFF0a3FpdmdxVlY5NDIwTXdPTVZqNTJ1ejN5VWNaNFBmSjNZLzJPV3BvNmF3?= =?utf-8?B?V2NvcTV5MTJxdjM4UWZiN3gzRldyWDNUanVKS0g4RlRuclUyR2xxMmJJVnVo?= =?utf-8?B?WXpmeTd0VzVoUHBNVkd0d0RsbmFwZDdkcHhzQ041N2dtSmgxcDI3MGdhNkhV?= =?utf-8?B?Y3oyNk9LVEhLY3BwNWFlcTFDcW9EYjRpM1ZXcXBQV0RFdnZ1c05oSDU0d094?= =?utf-8?B?VStCZVJobVpxWUxVWW5henk5NStZSTgxSStaU1A2OG9vbDlOTUFXVlZiV0Z3?= =?utf-8?B?K0VRci9Db3Zsa0ZRMXlqanRaejRvakpaV0dHMlF5TEFZdFlVbDZxejBqMHNs?= =?utf-8?B?Sy9lQXRMb2RadGFrdW96dVRGSnRTQTk4Q2QwcWR3KzlmSDMyK05aS0c2dnRE?= =?utf-8?B?K2w3QUd1VVBlcXczUDdna2hob3p3VkJKSmlVZEF4bmprdThxTDY3OWtoRjM1?= =?utf-8?B?ckw2d1BSNDI0cTMrYlE0SUJyZHFScGhEV0NUV0NQQlB6ejBDME56ZnpJL1FQ?= =?utf-8?B?Q1QwSVpuZFNZTkV3NVdHNlRaMFJPaEk5SnpuSVpwMEoweVpwLzZ6elZrdGsy?= =?utf-8?B?NW1aNzBEcktvdWdRZ2NRSzNSckNLbmkrZzcrR3J1QTRiWVkwTTFaWWNmcW01?= =?utf-8?B?UTJtUjJ0WkhydFluUStyYmFMOFljci9saU9YRnVsVUVQTDNTT2g4MFMzejQy?= =?utf-8?Q?mX4fUuvMzgiKhj3Eg/vcteiW+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8681a81-3c6f-4de9-0ebe-08dbab1557e9 X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2023 18:00:36.2129 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9+zWrrGn6KFeupWOJlHtp8zeAlrG0zDm6zX39WwF3uE5+jn9RRZWNsHNlMf9+v4h02RfpbE3n5VQufopdlFfGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9981 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1.09.23 г. 20:30 ч., Guenter Roeck wrote: > Hi, > > On Wed, Jun 14, 2023 at 01:39:46AM +0200, Thomas Gleixner wrote: >> Initializing the FPU during the early boot process is a pointless >> exercise. Early boot is convoluted and fragile enough. >> >> Nothing requires that the FPU is set up early. It has to be initialized >> before fork_init() because the task_struct size depends on the FPU register >> buffer size. >> >> Move the initialization to arch_cpu_finalize_init() which is the perfect >> place to do so. >> >> No functional change. >> >> This allows to remove quite some of the custom early command line parsing, >> but that's subject to the next installment. >> >> Signed-off-by: Thomas Gleixner > > The backport of this patch into chromeos-5.10 and chromeos-5.15 via stable > relase merges is causing various Chromebooks (not all of them) to crash > early during boot. Subsequent fixes have not addressed the problem for us, > so we already reverted the patch from chromeos-5.15 and will revert it > from chromeos-5.10 as well. > > I don't know if this is a Chromebook specific problem, or if it affects > mainline, so this is just a heads-up in case others experience similar > problems. Looking at 5.15 the following prerequisites are likely missing: af8060279968 ("mm: Move mm_cachep initialization to mm_init()") 5b93a83649c7 ("x86/mm: Initialize text poking earlier") Can you test with those patches backported to 5.15.y and see if it works? > > Thanks, > Guenter